From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from fllv0016.ext.ti.com (fllv0016.ext.ti.com [198.47.19.142]) by arago-project.org (Postfix) with ESMTPS id BE6425297F for ; Thu, 20 Jun 2019 21:04:40 +0000 (UTC) Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id x5KL3wtO010496 for ; Thu, 20 Jun 2019 16:03:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1561064639; bh=VUq67ZhM2Bdm3YlLySM3auvKjIHJIrAt6RII/CnFslU=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=G/VGnb8YzKavGRTFe0tIgJC863gJfQf6SPek9r6IvfN5Q4el8jVxUtVEZKA6KGrMR b74XZ/L4YqygR/hl7iOF6BbVnAePP+n0dLAZdf0msTcukHvzYNm/hsHiLOveEx5pZo CW+6+tc8Jtq7Df0pYaAMfbaDhy3c+hqGdRlWKeNg= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x5KL3wQO016146 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 20 Jun 2019 16:03:58 -0500 Received: from DFLE102.ent.ti.com (10.64.6.23) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Thu, 20 Jun 2019 16:03:58 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5 via Frontend Transport; Thu, 20 Jun 2019 16:03:58 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id x5KL3wp5071116; Thu, 20 Jun 2019 16:03:58 -0500 Date: Thu, 20 Jun 2019 17:03:58 -0400 From: Denys Dmytriyenko To: Yuan Zhao Message-ID: <20190620210358.GC4849@beryl> References: <20190620182230.96572-1-yuanzhao@ti.com> MIME-Version: 1.0 In-Reply-To: <20190620182230.96572-1-yuanzhao@ti.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Cc: meta-arago@arago-project.org Subject: Re: [thud/ti2019.01][PATCH] tidl-api: fix g++ 8.3.0 compilation error X-BeenThere: meta-arago@arago-project.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Arago metadata layer for TI SDKs - OE-Core/Yocto compatible List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jun 2019 21:04:41 -0000 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline On Thu, Jun 20, 2019 at 01:22:30PM -0500, Yuan Zhao wrote: > Signed-off-by: Yuan Zhao > --- > .../0002-tidl-api_gcc_8.3.0_compilation.patch | 52 ++++++++++++++++++++++ > meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc | 3 +- > .../recipes-ti/tidl-api/tidl-api_git.bb | 2 +- > 3 files changed, 55 insertions(+), 2 deletions(-) > create mode 100644 meta-arago-extras/recipes-ti/tidl-api/files/0002-tidl-api_gcc_8.3.0_compilation.patch > > diff --git a/meta-arago-extras/recipes-ti/tidl-api/files/0002-tidl-api_gcc_8.3.0_compilation.patch b/meta-arago-extras/recipes-ti/tidl-api/files/0002-tidl-api_gcc_8.3.0_compilation.patch > new file mode 100644 > index 00000000..6a48203e > --- /dev/null > +++ b/meta-arago-extras/recipes-ti/tidl-api/files/0002-tidl-api_gcc_8.3.0_compilation.patch > @@ -0,0 +1,52 @@ > +commit aa7101256aefcea11d326740c111bf37a48b191e (HEAD -> master_patch) > +Author: Yuan Zhao > +Date: Thu Jun 20 12:01:24 2019 -0500 > + > + Fix g++ 8.3.0 compilation error > + > + - Fix a syntax allowed in g++ 7.2.1 but not in 8.3.0 > + - Make should report error from loop > + > + Upstream-Status: Submitted [Remove this patch when next release is out] > + > + Signed-off-by: Yuan Zhao This doesn't look like a proper git patch, but rather the output of git log? Please use git format-patch command. Thanks. > +diff --git a/examples/Makefile b/examples/Makefile > +index 52b3ff6..9217380 100644 > +--- a/examples/Makefile > ++++ b/examples/Makefile > +@@ -34,7 +34,7 @@ RUN_DIRS := $(filter-out classification, $(DIRS)) > + define make_in_dirs > + @for dir in $(1); do \ > + echo "=============== " $$dir " =================" ; \ > +- $(MAKE) --no-print-directory $(MAKEFILE) -C $$dir $(2); \ > ++ $(MAKE) --no-print-directory $(MAKEFILE) -C $$dir $(2) || exit 1; \ > + done > + endef > + > +diff --git a/examples/classification/main.cpp b/examples/classification/main.cpp > +index 020004b..25361f8 100644 > +--- a/examples/classification/main.cpp > ++++ b/examples/classification/main.cpp > +@@ -699,7 +699,7 @@ int tf_postprocess(uchar *in, int size, int roi_idx, int frame_idx, int f_id) > + int rpt_id = -1; > + > + typedef std::pair val_index; > +- auto constexpr cmp = [](val_index &left, val_index &right) { return left.first > right.first; }; > ++ auto cmp = [](val_index &left, val_index &right) { return left.first > right.first; }; > + std::priority_queue, decltype(cmp)> queue(cmp); > + // initialize priority queue with smallest value on top > + for (int i = 0; i < k; i++) { > +diff --git a/examples/imagenet/main.cpp b/examples/imagenet/main.cpp > +index 937f467..dc1035b 100644 > +--- a/examples/imagenet/main.cpp > ++++ b/examples/imagenet/main.cpp > +@@ -309,7 +309,7 @@ bool WriteFrameOutput(const ExecutionObjectPipeline &eop, > + > + // sort and get k largest values and corresponding indices > + typedef pair val_index; > +- auto constexpr cmp = [](val_index &left, val_index &right) > ++ auto cmp = [](val_index &left, val_index &right) > + { return left.first > right.first; }; > + priority_queue, decltype(cmp)> queue(cmp); > + // initialize priority queue with smallest value on top > diff --git a/meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc b/meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc > index 04049e73..d93aec82 100644 > --- a/meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc > +++ b/meta-arago-extras/recipes-ti/tidl-api/tidl-api.inc > @@ -1,5 +1,5 @@ > PV = "1.3.0" > -INC_PR = "r1" > +INC_PR = "r2" > > LIC_FILES_CHKSUM = "file://license.txt;md5=e3daeabffb9fc131a73f16d16cbdb118" > > @@ -12,4 +12,5 @@ SRCREV = "785170685ca6a5c11876b05ddf74741c419393be" > > # default patchdir is ${S} > SRC_URI += "file://0001-tidl-api_l2_cache_size.patch" > +SRC_URI += "file://0002-tidl-api_gcc_8.3.0_compilation.patch" > S = "${WORKDIR}/git" > diff --git a/meta-arago-extras/recipes-ti/tidl-api/tidl-api_git.bb b/meta-arago-extras/recipes-ti/tidl-api/tidl-api_git.bb > index 1deb59e3..48f4db1d 100644 > --- a/meta-arago-extras/recipes-ti/tidl-api/tidl-api_git.bb > +++ b/meta-arago-extras/recipes-ti/tidl-api/tidl-api_git.bb > @@ -8,7 +8,7 @@ require recipes-ti/includes/ti-paths.inc > > PR = "${INC_PR}.0" > > -COMPATIBLE_MACHINE = "dra7xx-evm|m57xx-evm|am57xx-hs-evm" > +COMPATIBLE_MACHINE = "dra7xx-evm|am57xx-evm|am57xx-hs-evm" > PACKAGE_ARCH = "${MACHINE_ARCH}" > > inherit python3native > -- > 2.14.1 > > _______________________________________________ > meta-arago mailing list > meta-arago@arago-project.org > http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago