From: "Theodore Ts'o" <tytso@mit.edu>
To: Ross Zwisler <zwisler@chromium.org>
Cc: linux-kernel@vger.kernel.org, Ross Zwisler <zwisler@google.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.com>,
linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org, Fletcher Woodruff <fletcherw@google.com>,
Justin TerAvest <teravest@google.com>, Jan Kara <jack@suse.cz>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 2/3] jbd2: introduce jbd2_inode dirty range scoping
Date: Thu, 20 Jun 2019 17:25:17 -0400 [thread overview]
Message-ID: <20190620212517.GC4650@mit.edu> (raw)
In-Reply-To: <20190620151839.195506-3-zwisler@google.com>
On Thu, Jun 20, 2019 at 09:18:38AM -0600, Ross Zwisler wrote:
> diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h
> index 5c04181b7c6d8..0e0393e7f41a4 100644
> --- a/include/linux/jbd2.h
> +++ b/include/linux/jbd2.h
> @@ -1397,6 +1413,12 @@ extern int jbd2_journal_force_commit(journal_t *);
> extern int jbd2_journal_force_commit_nested(journal_t *);
> extern int jbd2_journal_inode_add_write(handle_t *handle, struct jbd2_inode *inode);
> extern int jbd2_journal_inode_add_wait(handle_t *handle, struct jbd2_inode *inode);
> +extern int jbd2_journal_inode_ranged_write(handle_t *handle,
> + struct jbd2_inode *inode, loff_t start_byte,
> + loff_t length);
> +extern int jbd2_journal_inode_ranged_wait(handle_t *handle,
> + struct jbd2_inode *inode, loff_t start_byte,
> + loff_t length);
> extern int jbd2_journal_begin_ordered_truncate(journal_t *journal,
> struct jbd2_inode *inode, loff_t new_size);
> extern void jbd2_journal_init_jbd_inode(struct jbd2_inode *jinode, struct inode *inode);
You're adding two new functions that are called from outside the jbd2
subsystem. To support compiling jbd2 as a module, we also need to add
EXPORT_SYMBOL declarations for these two functions.
I'll take care of this when applying this change.
Thanks, applied.
- Ted
next prev parent reply other threads:[~2019-06-20 21:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 15:18 [PATCH v2 0/3] Add dirty range scoping to jbd2 Ross Zwisler
2019-06-20 15:18 ` [PATCH v2 1/3] mm: add filemap_fdatawait_range_keep_errors() Ross Zwisler
2019-06-20 15:18 ` [PATCH v2 2/3] jbd2: introduce jbd2_inode dirty range scoping Ross Zwisler
2019-06-20 21:25 ` Theodore Ts'o [this message]
2019-06-20 21:29 ` Ross Zwisler
2019-06-20 15:18 ` [PATCH v2 3/3] ext4: use " Ross Zwisler
2019-06-20 21:27 ` Theodore Ts'o
2019-06-23 18:54 ` kbuild test robot
2019-06-24 15:12 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620212517.GC4650@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=fletcherw@google.com \
--cc=jack@suse.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
--cc=teravest@google.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zwisler@chromium.org \
--cc=zwisler@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.