All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ramalingam C <ramalingam.c@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: igt-dev@lists.freedesktop.org, andi@etezian.org
Subject: Re: [igt-dev] [RFC v2 05/43] lib/i915: Helper func for engine class to exec_flag
Date: Fri, 21 Jun 2019 18:22:07 +0530	[thread overview]
Message-ID: <20190621125207.GA21058@intel.com> (raw)
In-Reply-To: <1475616f-dc4f-8b74-a812-37ab4d5dd29f@linux.intel.com>

On 2019-06-21 at 11:49:40 +0100, Tvrtko Ursulin wrote:
> 
> On 21/06/2019 11:03, Ramalingam C wrote:
> > Helper function is defined to get the execbuf flag for a engine of a
> > class mapped for a ctx.
> 
> We need matching on both class and instance. You can take
> https://patchwork.freedesktop.org/patch/312751/?series=62454 from Andi who
> wrote it in the meantime.
Ok Sure.

-Ram
> 
> Regards,
> 
> Tvrtko
> 
> > Signed-off-by: Ramalingam C <ramalingam.c@intel.com>
> > ---
> >   lib/i915/gem_engine_topology.c | 22 ++++++++++++++++++++++
> >   lib/i915/gem_engine_topology.h |  2 ++
> >   2 files changed, 24 insertions(+)
> > 
> > diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
> > index fdd1b951672b..c64f7a4d05bb 100644
> > --- a/lib/i915/gem_engine_topology.c
> > +++ b/lib/i915/gem_engine_topology.c
> > @@ -289,3 +289,25 @@ bool gem_has_engine_topology(int fd)
> >   	return !__gem_context_get_param(fd, &param);
> >   }
> > +
> > +/* Return -EINVAL when the Engine with mentioned class is not found */
> > +int gem_engine_class_to_execbuf_flags(int fd, uint32_t ctx_id, int class)
> > +{
> > +	const struct intel_execution_engine2 *e;
> > +	DEFINE_CONTEXT_ENGINES_PARAM(engines, param, ctx_id, GEM_MAX_ENGINES);
> > +	int i;
> > +
> > +	if (gem_topology_get_param(fd, &param)) {
> > +		__for_each_static_engine(e) {
> > +			if (e->class == class)
> > +				return e->flags;
> > +		}
> > +		return -EINVAL;
> > +	}
> > +
> > +	for (i = 0; i < param.size; i++)
> > +		if (engines.engines[i].engine_class == class)
> > +			return i;
> > +
> > +	return -EINVAL;
> > +}
> > diff --git a/lib/i915/gem_engine_topology.h b/lib/i915/gem_engine_topology.h
> > index 2415fd1e379b..aa934622cab0 100644
> > --- a/lib/i915/gem_engine_topology.h
> > +++ b/lib/i915/gem_engine_topology.h
> > @@ -53,6 +53,8 @@ int gem_context_lookup_engine(int fd, uint64_t engine, uint32_t ctx_id,
> >   void gem_context_set_all_engines(int fd, uint32_t ctx);
> > +int gem_engine_class_to_execbuf_flags(int fd, uint32_t ctx_id, int class);
> > +
> >   #define __for_each_static_engine(e__) \
> >   	for ((e__) = intel_execution_engines2; (e__)->name; (e__)++)
> > 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2019-06-21 12:49 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 10:03 [igt-dev] [RFC v2 00/43] Upgrading the Engine discovery Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 01/43] test/i915: gem_bad_reloc: use the gem_engine_topology library Ramalingam C
2019-06-21 10:02   ` Chris Wilson
2019-06-21 10:05     ` Tvrtko Ursulin
2019-06-21 10:51       ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 02/43] test/i915: gem_exec_async: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 03/43] test/i915: gem_exec_capture: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 04/43] test/i915: gem_exec_params: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 05/43] lib/i915: Helper func for engine class to exec_flag Ramalingam C
2019-06-21 10:49   ` Tvrtko Ursulin
2019-06-21 12:52     ` Ramalingam C [this message]
2019-06-25 11:43   ` Andi Shyti
2019-06-21 10:03 ` [igt-dev] [RFC v2 06/43] test/prime_vgem: use the gem_engine_topology library Ramalingam C
2019-06-21 10:08   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 07/43] tests/i915/gem_exec_reuse: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 08/43] tests/i915/gem_sync: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 09/43] tests/i915/gem_busy: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 10/43] tests/i915/gem_concurrent_all: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 11/43] tests/i915/gem_cs_prefetch: " Ramalingam C
2019-06-21 10:11   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 12/43] tests/i915/gem_ctx_create: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 13/43] tests/i915/gem_ctx_isolation: " Ramalingam C
2019-06-28 22:12   ` Stimson, Dale B
2019-06-21 10:03 ` [igt-dev] [RFC v2 14/43] tests/i915/gem_ctx_switch: " Ramalingam C
2019-06-21 10:14   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 15/43] tests/i915/gem_ctx_thrash: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 16/43] tests/i915/gem_eio: " Ramalingam C
2019-06-21 10:20   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 17/43] tests/i915/gem_exec_await: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 18/43] tests/i915/gem_exec_create: " Ramalingam C
2019-06-21 10:21   ` Chris Wilson
2019-06-25 12:17     ` Andi Shyti
2019-06-21 10:03 ` [igt-dev] [RFC v2 19/43] tests/i915/gem_exec_fence: " Ramalingam C
2019-06-21 10:22   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 20/43] tests/i915/gem_exec_flush: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 21/43] tests/i915/gem_exec_gttfill: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 22/43] tests/i915/gem_exec_latency: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 23/43] tests/i915/gem_exec_nop: " Ramalingam C
2019-06-21 10:23   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 24/43] tests/i915/gem_exec_reloc: " Ramalingam C
2019-06-21 10:24   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 25/43] tests/i915/gem_exec_schedule: " Ramalingam C
2019-06-21 10:25   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 26/43] tests/i915/gem_exec_suspend: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 27/43] tests/i915/gem_exec_whisper: " Ramalingam C
2019-06-21 10:26   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 28/43] tests/i915/gem_mocs_settings: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 29/43] tests/i915/gem_reset_stats: " Ramalingam C
2019-06-21 10:29   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 30/43] tests/i915/gem_ring_sync_loop: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 31/43] tests/i915/gem_ringfill: " Ramalingam C
2019-06-21 10:29   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 32/43] tests/i915/gem_shrink: " Ramalingam C
2019-06-21 10:30   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 33/43] tests/i915/gem_spin_batch: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 34/43] tests/i915/gem_storedw_loop: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 35/43] tests/i915/gem_userptr_blits: " Ramalingam C
2019-06-21 10:32   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 36/43] tests/i915/i915_hangman: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 37/43] tests/i915/i915_module_load: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 38/43] tests/kms_busy: " Ramalingam C
2019-06-21 10:35   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 39/43] tests/prime_busy: " Ramalingam C
2019-06-21 10:36   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 40/43] tests/amdgpu/amd_prime: " Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 41/43] tests/i915/gem_ctx_shared: " Ramalingam C
2019-06-21 10:37   ` Chris Wilson
2019-06-21 10:03 ` [igt-dev] [RFC v2 42/43] lib: replace the legacy funcs with gem_engine_topology libraries Ramalingam C
2019-06-21 10:03 ` [igt-dev] [RFC v2 43/43] lib/gem_engine_topology: rename the macros Ramalingam C
2019-06-21 10:42 ` [igt-dev] ✓ Fi.CI.BAT: success for Upgrading the Engine discovery Patchwork
2019-06-21 16:12 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2019-06-28 22:25 ` [igt-dev] ✗ Fi.CI.BAT: failure for Upgrading the Engine discovery (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190621125207.GA21058@intel.com \
    --to=ramalingam.c@intel.com \
    --cc=andi@etezian.org \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.