From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA447C43613 for ; Fri, 21 Jun 2019 14:15:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B40902089E for ; Fri, 21 Jun 2019 14:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561126553; bh=cKl1ATkQpP+oDNaHNi2VIa2C13hcw38+hSlhNpnDBWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=x8Hoya/yoNI2/3Cmup6Lo47jBY1bzX0CxoB11lakFLEXqg9R7ioUQ4WlKqP37w4+G vWcA+O/bUMFGYHCB9IJzeSDsVeod0A8PW3Vcofgqe14jxktXrsOVDETVBS9LDIHjDs uLmSa/oLWIkOHZhWnVcpvC+MaCoHIotF9Ud+3Hg4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725985AbfFUOPx (ORCPT ); Fri, 21 Jun 2019 10:15:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:46014 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725975AbfFUOPx (ORCPT ); Fri, 21 Jun 2019 10:15:53 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C822F20679; Fri, 21 Jun 2019 14:15:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561126552; bh=cKl1ATkQpP+oDNaHNi2VIa2C13hcw38+hSlhNpnDBWY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SsgU3AMSfzeUXecKcYbTcI4sG8aRDVGY+ybbHMeTH0cdpQEpHre2neo26baNKeXcj YxBd+09SqWak0kpjG4tgMwUmSfVfRQvGEzhucM1m6LY+olmtxYTLMbt0IVZup5NT34 BBEbhR+ZNvO7BxfdS7VUJgWyaMN2BPji7kKs6b2Q= Date: Fri, 21 Jun 2019 09:15:50 -0500 From: Bjorn Helgaas To: Greg KH Cc: Rajat Jain , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: PCI/AER sysfs files violate the rules of how sysfs works Message-ID: <20190621141550.GG82584@google.com> References: <20190621072911.GA21600@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190621072911.GA21600@kroah.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Fri, Jun 21, 2019 at 09:29:11AM +0200, Greg KH wrote: > Hi, > > When working on some documentation scripts to show the > Documentation/ABI/ files in an automated way, I ran across this "gem" of > a sysfs file: Documentation/ABI/testing/sysfs-bus-pci-devices-aer_stats > > In it you describe how the files > /sys/bus/pci/devices//aer_dev_correctable and > /sys/bus/pci/devices//aer_dev_fatal and > /sys/bus/pci/devices//aer_dev_nonfatal > all display a bunch of text on multiple lines. > > This violates the "one value per sysfs file" rule, and should never have > been merged as-is :( > > Please fix it up to be a lot of individual files if your really need all > of those different values. Sorry about that. Do you think we're safe in changing the sysfs ABI by removing the original files and replacing them with new, better ones? This is pretty new and hopefully not widely used yet. Bjorn