From: helgaas at kernel.org (Bjorn Helgaas)
Subject: [Linux-kernel-mentees] [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 11:44:29 -0500 [thread overview]
Message-ID: <20190621164429.GA187016@google.com> (raw)
In-Reply-To: <20190621162024.53620dd9@alans-desktop>
On Fri, Jun 21, 2019 at 04:20:24PM +0100, Alan Cox wrote:
> On Fri, 21 Jun 2019 15:16:04 +0530
> Puranjay Mohan <puranjay12 at gmail.com> wrote:
>
> > This patch series removes the private duplicates of PCI definitions in
> > favour of generic definitions defined in pci_regs.h.
>
> Why bother ? It's an ancient obsolete card ?
That's a fair question.
Is there anything that would indicate that "this file is obsolete and
problems shouldn't be fixed"? Nobody wants to waste time on things
that don't need to be fixed, but I don't know how to tell if something
is obsolete.
My naive assumption is that if something is in the tree, it's fair
game for fixes and cleanups.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: helgaas@kernel.org (Bjorn Helgaas)
Subject: [Linux-kernel-mentees] [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 11:44:29 -0500 [thread overview]
Message-ID: <20190621164429.GA187016@google.com> (raw)
Message-ID: <20190621164429.DbsVwTwqT8z2GJSZWqEJ3bbqjBdMGVNSdX9KrO3ACEU@z> (raw)
In-Reply-To: <20190621162024.53620dd9@alans-desktop>
On Fri, Jun 21, 2019 at 04:20:24PM +0100, Alan Cox wrote:
> On Fri, 21 Jun 2019 15:16:04 +0530
> Puranjay Mohan <puranjay12 at gmail.com> wrote:
>
> > This patch series removes the private duplicates of PCI definitions in
> > favour of generic definitions defined in pci_regs.h.
>
> Why bother ? It's an ancient obsolete card ?
That's a fair question.
Is there anything that would indicate that "this file is obsolete and
problems shouldn't be fixed"? Nobody wants to waste time on things
that don't need to be fixed, but I don't know how to tell if something
is obsolete.
My naive assumption is that if something is in the tree, it's fair
game for fixes and cleanups.
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Alan Cox <gnomes@lxorguk.ukuu.org.uk>
Cc: Puranjay Mohan <puranjay12@gmail.com>,
Shuah Khan <skhan@linuxfoundation.org>,
Bjorn Helgaas <bjorn@helgaas.com>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates
Date: Fri, 21 Jun 2019 11:44:29 -0500 [thread overview]
Message-ID: <20190621164429.GA187016@google.com> (raw)
In-Reply-To: <20190621162024.53620dd9@alans-desktop>
On Fri, Jun 21, 2019 at 04:20:24PM +0100, Alan Cox wrote:
> On Fri, 21 Jun 2019 15:16:04 +0530
> Puranjay Mohan <puranjay12@gmail.com> wrote:
>
> > This patch series removes the private duplicates of PCI definitions in
> > favour of generic definitions defined in pci_regs.h.
>
> Why bother ? It's an ancient obsolete card ?
That's a fair question.
Is there anything that would indicate that "this file is obsolete and
problems shouldn't be fixed"? Nobody wants to waste time on things
that don't need to be fixed, but I don't know how to tell if something
is obsolete.
My naive assumption is that if something is in the tree, it's fair
game for fixes and cleanups.
Bjorn
next prev parent reply other threads:[~2019-06-21 16:44 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 9:46 [Linux-kernel-mentees] [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates puranjay12
2019-06-21 9:46 ` Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] [PATCH v3 1/3] net: fddi: skfp: Rename local PCI defines to match generic PCI defines puranjay12
2019-06-21 9:46 ` Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] [PATCH v3 2/3] net: fddi: skfp: Include generic PCI definitions puranjay12
2019-06-21 9:46 ` Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] [PATCH v3 3/3] net: fddi: skfp: Remove unused private " puranjay12
2019-06-21 9:46 ` Puranjay Mohan
2019-06-21 9:46 ` [Linux-kernel-mentees] " Puranjay Mohan
2019-06-21 14:05 ` [Linux-kernel-mentees] [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates helgaas
2019-06-21 14:05 ` Bjorn Helgaas
2019-06-21 14:05 ` [Linux-kernel-mentees] " Bjorn Helgaas
2019-06-21 15:20 ` gnomes
2019-06-21 15:20 ` Alan Cox
2019-06-21 15:20 ` [Linux-kernel-mentees] " Alan Cox
2019-06-21 16:36 ` skhan
2019-06-21 16:36 ` Shuah Khan
2019-06-21 16:36 ` [Linux-kernel-mentees] " Shuah Khan
2019-06-26 20:03 ` davem
2019-06-26 20:03 ` David Miller
2019-06-26 20:03 ` [Linux-kernel-mentees] " David Miller
2019-06-21 16:44 ` helgaas [this message]
2019-06-21 16:44 ` Bjorn Helgaas
2019-06-21 16:44 ` [Linux-kernel-mentees] " Bjorn Helgaas
2019-06-21 17:59 ` joe
2019-06-21 17:59 ` Joe Perches
2019-06-21 17:59 ` [Linux-kernel-mentees] " Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621164429.GA187016@google.com \
--to=unknown@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.