From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0BB5C43613 for ; Fri, 21 Jun 2019 16:50:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C69C020665 for ; Fri, 21 Jun 2019 16:50:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Cx50ilw3"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="vkm8kqto" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C69C020665 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vLpud2edvcn+UeqRGWIr5ndk4YCY2fucC4lF7H10od4=; b=Cx50ilw3LTozO0 b1IXBwnIBJoe+0GiwUazfFLKIXXXGRrU/kqZYQnMujK2uYiCOQ+A7z7zuu5R2RbzASFOnCreQfixg cBzqB2N/o0LpwrAgrMTVwV5aYPlIv3YiCvnMvpDBjOys1O3F/gzjqY5YJm5mpWR/LCNJCVQVlESne 2IZootdLZ1kjS08QgPUcdIpNebNc+rHQAw7UFaAY0U5LM6KjwNzfoUqtoO8kUUp6biC6v+l7cT6+U kJRKoB8Y/710y1Te4yaj2Rj/nUmrWTyWBuS2Jhd5MmAYCUtvczv0mBR4uoK1xrtyLUGJeEhQ5VVwK X4tRu0wuf/wDD8y+4KLA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1heMjs-0001t2-Nt; Fri, 21 Jun 2019 16:50:12 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1heMjp-0000rc-0C for linux-arm-kernel@lists.infradead.org; Fri, 21 Jun 2019 16:50:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=P71o6R9PwKrxfUlkCzThaAEbYlO5haANQ4Qx+hoNZ6s=; b=vkm8kqtoslv3JIikaTIBorlbNH s88aHYfIZiSu8Iii2S8nQ6MYb1TCC1gZzo2J9oJ+pcto5nZNRyAlbFNKPNqXuNMX4uS+ZLqNRJNUx Pw48ymqe6jF+YDuGxPHtBN6EDChwUDieXpmGsG1Epj6zOsfoE4hAABWRKgxb5GFI8WgI=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1heMjM-0007Ft-HQ; Fri, 21 Jun 2019 18:49:40 +0200 Date: Fri, 21 Jun 2019 18:49:40 +0200 From: Andrew Lunn To: Claudiu Manoil Subject: Re: [PATCH net-next 4/6] arm64: dts: fsl: ls1028a: Add Felix switch port DT node Message-ID: <20190621164940.GL31306@lunn.ch> References: <1561131532-14860-1-git-send-email-claudiu.manoil@nxp.com> <1561131532-14860-5-git-send-email-claudiu.manoil@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1561131532-14860-5-git-send-email-claudiu.manoil@nxp.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190621_095009_203619_A2174952 X-CRM114-Status: GOOD ( 10.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandre Belloni , netdev@vger.kernel.org, alexandru.marginean@nxp.com, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Allan Nielsen , Rob Herring , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jun 21, 2019 at 06:38:50PM +0300, Claudiu Manoil wrote: > The switch device features 6 ports, 4 with external links > and 2 internally facing to the ls1028a SoC and connected via > fixed links to 2 internal enetc ethernet controller ports. Hi Claudiu > + switch@0,5 { > + compatible = "mscc,felix-switch"; > + reg = <0x000500 0 0 0 0>; > + > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* external ports */ > + switch_port0: port@0 { > + reg = <0>; > + }; > + switch_port1: port@1 { > + reg = <1>; > + }; > + switch_port2: port@2 { > + reg = <2>; > + }; > + switch_port3: port@3 { > + reg = <3>; > + }; > + /* internal to-cpu ports */ > + port@4 { > + reg = <4>; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + port@5 { > + reg = <5>; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + }; > + }; This sounds like a DSA setup, where you have SoC ports connected to the switch. With DSA, the CPU ports of the switch are special. We don't create netdev's for them, the binding explicitly list which SoC interface they are bound to, etc. What model are you using here? I'm just trying to understand the setup to ensure it is consistent with the swichdev model. Thanks Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 4/6] arm64: dts: fsl: ls1028a: Add Felix switch port DT node Date: Fri, 21 Jun 2019 18:49:40 +0200 Message-ID: <20190621164940.GL31306@lunn.ch> References: <1561131532-14860-1-git-send-email-claudiu.manoil@nxp.com> <1561131532-14860-5-git-send-email-claudiu.manoil@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1561131532-14860-5-git-send-email-claudiu.manoil@nxp.com> Sender: linux-kernel-owner@vger.kernel.org To: Claudiu Manoil Cc: "David S . Miller" , devicetree@vger.kernel.org, Alexandre Belloni , netdev@vger.kernel.org, alexandru.marginean@nxp.com, linux-kernel@vger.kernel.org, UNGLinuxDriver@microchip.com, Allan Nielsen , Rob Herring , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, Jun 21, 2019 at 06:38:50PM +0300, Claudiu Manoil wrote: > The switch device features 6 ports, 4 with external links > and 2 internally facing to the ls1028a SoC and connected via > fixed links to 2 internal enetc ethernet controller ports. Hi Claudiu > + switch@0,5 { > + compatible = "mscc,felix-switch"; > + reg = <0x000500 0 0 0 0>; > + > + ethernet-ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + /* external ports */ > + switch_port0: port@0 { > + reg = <0>; > + }; > + switch_port1: port@1 { > + reg = <1>; > + }; > + switch_port2: port@2 { > + reg = <2>; > + }; > + switch_port3: port@3 { > + reg = <3>; > + }; > + /* internal to-cpu ports */ > + port@4 { > + reg = <4>; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + port@5 { > + reg = <5>; > + fixed-link { > + speed = <1000>; > + full-duplex; > + }; > + }; > + }; > + }; This sounds like a DSA setup, where you have SoC ports connected to the switch. With DSA, the CPU ports of the switch are special. We don't create netdev's for them, the binding explicitly list which SoC interface they are bound to, etc. What model are you using here? I'm just trying to understand the setup to ensure it is consistent with the swichdev model. Thanks Andrew