From: Wolfram Sang <wsa@the-dreams.de>
To: "Enrico Weigelt, metux IT consult" <info@metux.net>
Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH 1/3] include: linux: i2c: more helpers for declaring i2c drivers
Date: Fri, 21 Jun 2019 23:17:44 +0200 [thread overview]
Message-ID: <20190621211744.GC950@kunai> (raw)
In-Reply-To: <1560796779-17117-1-git-send-email-info@metux.net>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
On Mon, Jun 17, 2019 at 08:39:37PM +0200, Enrico Weigelt, metux IT consult wrote:
> From: Enrico Weigelt <info@metux.net>
>
> Add more helper macros for trivial driver init cases, similar to the
> already existing module_i2c_driver()+friends - now for those which
> are initialized at other stages (eg. by subsys_initcall()).
>
> This helps to further reduce driver init boilerplate.
Uh, no! Using subsys_initcall is an old fashioned hack to work around
boot time dependencies. Unless there are very strong arguments, I
usually do not accept them anymore. So, any simplification of that sends
out the wrong message.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2019-06-21 21:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 18:39 [PATCH 1/3] include: linux: i2c: more helpers for declaring i2c drivers Enrico Weigelt, metux IT consult
2019-06-17 18:39 ` [PATCH 2/3] drivers: gpio: pca953x: use subsys_i2c_driver() Enrico Weigelt, metux IT consult
2019-06-17 18:39 ` [PATCH 3/3] drivers: gpio: pcf857x: " Enrico Weigelt, metux IT consult
2019-06-21 21:17 ` Wolfram Sang [this message]
2019-06-24 5:44 ` [PATCH 1/3] include: linux: i2c: more helpers for declaring i2c drivers Enrico Weigelt, metux IT consult
2019-06-24 8:44 ` Wolfram Sang
2019-06-24 8:59 ` Enrico Weigelt, metux IT consult
2019-08-16 19:56 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190621211744.GC950@kunai \
--to=wsa@the-dreams.de \
--cc=bgolaszewski@baylibre.com \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.