From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCHv2] meson: add per package optional compiler/linker flags
Date: Sun, 23 Jun 2019 17:24:16 +0200 [thread overview]
Message-ID: <20190623152416.GH13664@scaer> (raw)
In-Reply-To: <20190623123614.677b10fd@windsurf>
Thomas, All,
On 2019-06-23 12:36 +0200, Thomas Petazzoni spake thusly:
> On Sat, 22 Jun 2019 22:20:46 +0200
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:
>
> Perhaps the commit should explain that as of today, Meson doesn't allow
> to pass cflags/ldflags on the command line when a cross-compilation
> file is used.
Indeed.
[--SNIP--]
> > +* +FOO_CFLAGS+, to specify compiler arguments added to the package specific
> > + +cross-compile.conf+ file +c_args+ property. By default, empty, so that
> > + the global +TARGET_CFLAGS+ are used.
>
> I find the wording "By default, empty, so that the global
> +TARGET_CFLAGS+ are used" very confusing. Indeed, by default, those
> variables are not empty, they are precisely defined to TARGET_CFLAGS.
>
> For example, in the autotools infra documentation, we say:
>
> * +LIBFOO_AUTORECONF+, tells whether the package should
> be autoreconfigured or not (i.e. if the configure script and
> Makefile.in files should be re-generated by re-running autoconf,
> automake, libtool, etc.). Valid values are +YES+ and
> +NO+. By default, the value is +NO+
>
> So we just say that the default value is NO, not that it is empty and
> that NO is used :)
>
> For extra clarity, it could be rephrased like this:
>
> When no value is specified by the package for this variable,
> the value of +TARGET_CFLAGS+ will be used by the
> +meson-package+ infrastructure.
Yes, that makes sense.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-06-23 15:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-22 20:20 [Buildroot] [PATCHv2] meson: add per package optional compiler/linker flags Yann E. MORIN
2019-06-23 10:36 ` Thomas Petazzoni
2019-06-23 15:24 ` Yann E. MORIN [this message]
2019-06-23 19:21 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623152416.GH13664@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.