From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:adf:c793:0:0:0:0:0 with SMTP id l19csp3655065wrg; Mon, 24 Jun 2019 04:16:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqwLejr9XftBCmbrC1GoG1BJG/SmvpHDRItaYnRnAyISpfcbp8WMoy209PojQ1+kFlVI26iO X-Received: by 2002:a63:6b0a:: with SMTP id g10mr18755379pgc.295.1561375002805; Mon, 24 Jun 2019 04:16:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561375002; cv=none; d=google.com; s=arc-20160816; b=GuYYUXacmJUzonTWdbzpA2/B71ihewO2s4ivxYY56UXszKv4VWsBcCYTg8P4F3H3Xj 2j2WSuaLHxn23pmJlVt7OJNnI9Xx4+PxVtqEVETo09bOo8+iPmbuTbMWeLeKQTuVL0YB +tR0earXka0mPl1iOndZ2aG1y8UwgQrxiRniKwYXiMM1z0503wcLFjsPsczF7smmvm87 aeZMq3aQBzpU+LVEl2T2hxGHcU0VSeIMwKAWZXmaGEj8OL8kdkw7c6N666L5N+DXipXH 8XBZpKcFMp9FrwvRPPRlLN8pCICiLO2stTlBP/ludhUx50NdghYMBGN5Fp+fEAwpnRWT 4m0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=iduIRRC1KtDuVnxlKz6z+P/vzWHUnEPOERjMXVer/sU=; b=D+Lk2X4vW1sqECIeq9d0CBidHKiwadlzGgfVC/5SjGqKijEgzRMIwiQOnkL6H7ScFt 5cCdj3e7JOd5WNXbJNAODHfqxqfcAS2gwxqfHHn6E7OcS1BVyaNlPncQHaE5sem0P634 5aeEC8Gq+8zXOYZQkpegWgGHfpmrxfGrjxpebKwWDIGUlH9tWNHi47u2IjyE03EvY7bI cfJq9O2lw5fAcvxU+7ZXI0Wr3OPJbn18EJ7BRZYjXQh5UIlzF9JfbqQnmeA6niLFviTw W32P9myhNOsq4ASTogRj3QSuTRXpmEcjHpGCIEZhlEr9Pu66V9rvW8b4h31gu9DmM0n8 vRgA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z20si10399437pfa.282.2019.06.24.04.16.41; Mon, 24 Jun 2019 04:16:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of kvm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=kvm-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729668AbfFXLQk convert rfc822-to-8bit (ORCPT + 5 others); Mon, 24 Jun 2019 07:16:40 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52958 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727953AbfFXLQk (ORCPT ); Mon, 24 Jun 2019 07:16:40 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0EC0A4D29; Mon, 24 Jun 2019 11:16:39 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 67D2D1001DD5; Mon, 24 Jun 2019 11:16:33 +0000 (UTC) Date: Mon, 24 Jun 2019 13:16:29 +0200 From: Igor Mammedov To: gengdongjiu Cc: , , , , , , , , , , , , , , , Subject: Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition Message-ID: <20190624131629.7f586861@redhat.com> In-Reply-To: References: <1557832703-42620-1-git-send-email-gengdongjiu@huawei.com> <1557832703-42620-3-git-send-email-gengdongjiu@huawei.com> <20190620141052.370788fb@redhat.com> <20190620170934.39eae310@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 24 Jun 2019 11:16:40 +0000 (UTC) Sender: kvm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org X-TUID: Ur3pBc9m8tGG On Fri, 21 Jun 2019 01:17:48 +0800 gengdongjiu wrote: > On 2019/6/20 23:09, Igor Mammedov wrote: > > On Thu, 20 Jun 2019 22:04:01 +0800 > > gengdongjiu wrote: > > > >> Hi Igor, > >> Thanks for your review. > >> > >> On 2019/6/20 20:10, Igor Mammedov wrote: > >>>> + */ > >>>> +struct AcpiGenericErrorStatus { > >>>> + /* It is a bitmask composed of ACPI_GEBS_xxx macros */ > >>>> + uint32_t block_status; > >>>> + uint32_t raw_data_offset; > >>>> + uint32_t raw_data_length; > >>>> + uint32_t data_length; > >>>> + uint32_t error_severity; > >>>> +} QEMU_PACKED; > >>>> +typedef struct AcpiGenericErrorStatus AcpiGenericErrorStatus; > >>> there shouldn't be packed structures, > >>> is it a leftover from previous version? > >> > >> I remember some people suggest to add QEMU_PACKED before, anyway I will remove it in my next version patch. > > > > Question is why it's there and where it is used? > sorry, it is my carelessness. it should be packed structures. > > I used this structures to get its actual total size and member offset in [PATCH v17 10/10]. > If it is not packed structures, the total size and member offset may be not right. I'd suggest to drop these typedefs and use a macro with size for that purpose, Also it might be good to make it local to the file that would use it. > > > > BTW: > > series doesn't apply to master anymore. > > Do you have a repo somewhere available for testing? > > Thanks, I appreciated that you can have a test. > > I still do not upload repo, you can reset to below commit[1] in master and apply this series. > > BTW： > If test series, you should make an guest memory hardware error, let guest access the error address, then it will happen RAS error. > I provide a software hard code method to test this series, you can refer to https://www.mail-archive.com/qemu-devel@nongnu.org/msg619771.html > > > [1]: > commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8 > Merge: 5f02262 e841257 > Author: Peter Maydell > Date: Fri May 10 14:49:36 2019 +0100 > > > > > > >> > >>> > >>>> + > >>>> +/* > >>>> + * Masks for block_status flags above > >>>> + */ > >>>> +#define ACPI_GEBS_UNCORRECTABLE 1 > >>>> + > >>>> +/* > >> > > > > . > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CCB2C43613 for ; Mon, 24 Jun 2019 11:19:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 151FF212F5 for ; Mon, 24 Jun 2019 11:19:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 151FF212F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:49942 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfN0O-0001LB-6K for qemu-devel@archiver.kernel.org; Mon, 24 Jun 2019 07:19:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57305) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hfMyM-0000Y1-OS for qemu-devel@nongnu.org; Mon, 24 Jun 2019 07:17:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hfMyG-0000Yu-SJ for qemu-devel@nongnu.org; Mon, 24 Jun 2019 07:17:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39922) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hfMy6-0008LB-1P; Mon, 24 Jun 2019 07:17:04 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F0EC0A4D29; Mon, 24 Jun 2019 11:16:39 +0000 (UTC) Received: from localhost (unknown [10.43.2.182]) by smtp.corp.redhat.com (Postfix) with ESMTP id 67D2D1001DD5; Mon, 24 Jun 2019 11:16:33 +0000 (UTC) Date: Mon, 24 Jun 2019 13:16:29 +0200 From: Igor Mammedov To: gengdongjiu Message-ID: <20190624131629.7f586861@redhat.com> In-Reply-To: References: <1557832703-42620-1-git-send-email-gengdongjiu@huawei.com> <1557832703-42620-3-git-send-email-gengdongjiu@huawei.com> <20190620141052.370788fb@redhat.com> <20190620170934.39eae310@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 24 Jun 2019 11:16:40 +0000 (UTC) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.132.183.28 Subject: Re: [Qemu-devel] [PATCH v17 02/10] ACPI: add some GHES structures and macros definition X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, ehabkost@redhat.com, kvm@vger.kernel.org, mst@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, linuxarm@huawei.com, shannon.zhaosl@gmail.com, zhengxiang9@huawei.com, qemu-arm@nongnu.org, james.morse@arm.com, xuwei5@huawei.com, jonathan.cameron@huawei.com, pbonzini@redhat.com, lersek@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, 21 Jun 2019 01:17:48 +0800 gengdongjiu wrote: > On 2019/6/20 23:09, Igor Mammedov wrote: > > On Thu, 20 Jun 2019 22:04:01 +0800 > > gengdongjiu wrote: > > =20 > >> Hi Igor, > >> Thanks for your review. > >> > >> On 2019/6/20 20:10, Igor Mammedov wrote: =20 > >>>> + */ > >>>> +struct AcpiGenericErrorStatus { > >>>> + /* It is a bitmask composed of ACPI_GEBS_xxx macros */ > >>>> + uint32_t block_status; > >>>> + uint32_t raw_data_offset; > >>>> + uint32_t raw_data_length; > >>>> + uint32_t data_length; > >>>> + uint32_t error_severity; > >>>> +} QEMU_PACKED; > >>>> +typedef struct AcpiGenericErrorStatus AcpiGenericErrorStatus; =20 > >>> there shouldn't be packed structures, > >>> is it a leftover from previous version? =20 > >> > >> I remember some people suggest to add QEMU_PACKED before, anyway I wil= l remove it in my next version patch. =20 > >=20 > > Question is why it's there and where it is used? =20 > sorry, it is my carelessness. it should be packed structures. >=20 > I used this structures to get its actual total size and member offset in = [PATCH v17 10/10]. > If it is not packed structures, the total size and member offset may be n= ot right. I'd suggest to drop these typedefs and use a macro with size for that purpo= se, Also it might be good to make it local to the file that would use it. > >=20 > > BTW: > > series doesn't apply to master anymore. > > Do you have a repo somewhere available for testing? =20 >=20 > Thanks, I appreciated that you can have a test. >=20 > I still do not upload repo, you can reset to below commit[1] in master an= d apply this series. >=20 > BTW=EF=BC=9A > If test series, you should make an guest memory hardware error, let guest= access the error address, then it will happen RAS error. > I provide a software hard code method to test this series, you can refer = to https://www.mail-archive.com/qemu-devel@nongnu.org/msg619771.html >=20 >=20 > [1]: > commit efb4f3b62c69383a7308d7b739a3193e7c0ccae8 > Merge: 5f02262 e841257 > Author: Peter Maydell > Date: Fri May 10 14:49:36 2019 +0100 >=20 >=20 >=20 > > =20 > >> =20 > >>> =20 > >>>> + > >>>> +/* > >>>> + * Masks for block_status flags above > >>>> + */ > >>>> +#define ACPI_GEBS_UNCORRECTABLE 1 > >>>> + > >>>> +/* =20 > >> =20 > >=20 > > . > > =20 >=20