From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80310C43613 for ; Mon, 24 Jun 2019 14:26:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 526872133F for ; Mon, 24 Jun 2019 14:26:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="D7YejU7W"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="v79fJ+CG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 526872133F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d9bBNxSVnfmy6d7R2EdjxhDeH6uOiTKCtlinOu1Kbow=; b=D7YejU7W+gFrzo ozsetvtOGSVLmDvPZXB/idNcpJIYmJnM1p6BHo+Sa/ovbh4zZfA14gzgSYpDenDDvkOAkpW7ndvH1 afBaUUFSDUrxtcvgpIg4a/CUiLYkENPv5eVA99JUpYpO4uvX3YIir19vWUhMddzHadGvnbKC3CJPp B2F4V7jC4/h+L9Mfn8/bnYDysBniXfPvEoNcv5N5wl2prqTpL5h23SR1lKTjBQSHC+8h6R38DpaM1 KIhJX9DOX7Am8wjdO5SUP6yHIOVJrpK46BjwmLvHw5wqek8dFMd+HtQTrPDxB50jzYFCdjMvEe5tU FuesivbqiUPVQMW2Vcow==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfPvb-0000k1-9T; Mon, 24 Jun 2019 14:26:39 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfPvX-0000jZ-Sp for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2019 14:26:37 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=N5N6f9ldaRZVCwiVvBP9WWU3rYbAdzLFROiOxUyweJg=; b=v79fJ+CGdaLUV1/cBB/sRLTk9L 4rfzsWfmoOX/OPvFugF8ZIDfiLiCFEc7W2S+tcAbv1bwlwuBbZU1zL+Erwq+xQIxzc3YqhAAOOrjS YHfzlIW7yPBmE2yKC6l1g1MdgFbQyLLtlTk/rb/mX01M9qJC2ru3PDYVb1ToXrk1lsmw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hfPvN-0005nr-N6; Mon, 24 Jun 2019 16:26:25 +0200 Date: Mon, 24 Jun 2019 16:26:25 +0200 From: Andrew Lunn To: Alexandre Belloni Subject: Re: [PATCH net-next 4/6] arm64: dts: fsl: ls1028a: Add Felix switch port DT node Message-ID: <20190624142625.GR31306@lunn.ch> References: <1561131532-14860-1-git-send-email-claudiu.manoil@nxp.com> <1561131532-14860-5-git-send-email-claudiu.manoil@nxp.com> <20190621164940.GL31306@lunn.ch> <20190624115558.GA5690@piout.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190624115558.GA5690@piout.net> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_072636_089396_37A27661 X-CRM114-Status: GOOD ( 11.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , Alexandru Marginean , "linux-kernel@vger.kernel.org" , "UNGLinuxDriver@microchip.com" , Allan Nielsen , Claudiu Manoil , Rob Herring , "David S . Miller" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org > > Yeah, there are 2 ethernet controller ports (managed by the enetc driver) > > connected inside the SoC via SGMII links to 2 of the switch ports, one of > > these switch ports can be configured as CPU port (with follow-up patches). > > > > This configuration may look prettier on DSA, but the main restriction here > > is that the entire functionality is provided by the ocelot driver which is a > > switchdev driver. I don't think it would be a good idea to copy-paste code > > from ocelot to a separate dsa driver. > > > > We should probably make the ocelot driver a DSA driver then... Hi Claudiu, Alexandre An important part of DSA is being able to direct frames out specific ports when they ingress via the CPU port. Does the silicon support this? At the moment, i think it is using polled IO. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH net-next 4/6] arm64: dts: fsl: ls1028a: Add Felix switch port DT node Date: Mon, 24 Jun 2019 16:26:25 +0200 Message-ID: <20190624142625.GR31306@lunn.ch> References: <1561131532-14860-1-git-send-email-claudiu.manoil@nxp.com> <1561131532-14860-5-git-send-email-claudiu.manoil@nxp.com> <20190621164940.GL31306@lunn.ch> <20190624115558.GA5690@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20190624115558.GA5690@piout.net> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni Cc: Claudiu Manoil , "David S . Miller" , "devicetree@vger.kernel.org" , "netdev@vger.kernel.org" , Alexandru Marginean , "linux-kernel@vger.kernel.org" , "UNGLinuxDriver@microchip.com" , Allan Nielsen , Rob Herring , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org > > Yeah, there are 2 ethernet controller ports (managed by the enetc driver) > > connected inside the SoC via SGMII links to 2 of the switch ports, one of > > these switch ports can be configured as CPU port (with follow-up patches). > > > > This configuration may look prettier on DSA, but the main restriction here > > is that the entire functionality is provided by the ocelot driver which is a > > switchdev driver. I don't think it would be a good idea to copy-paste code > > from ocelot to a separate dsa driver. > > > > We should probably make the ocelot driver a DSA driver then... Hi Claudiu, Alexandre An important part of DSA is being able to direct frames out specific ports when they ingress via the CPU port. Does the silicon support this? At the moment, i think it is using polled IO. Andrew