From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: "Russell, Kent" <Kent.Russell-5C7GfCeVMHo@public.gmane.org>
Cc: "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org"
<amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org>
Subject: Re: [bug report] drm/amdkfd: Add procfs-style information for KFD processes
Date: Tue, 25 Jun 2019 03:49:35 +0300 [thread overview]
Message-ID: <20190625004935.GU18776@kadam> (raw)
In-Reply-To: <BN6PR12MB16181F76E1F385E999A2219585E00-/b2+HYfkarRqaFUXYJa4HgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On Mon, Jun 24, 2019 at 06:06:36PM +0000, Russell, Kent wrote:
> HI Dan,
>
> I'll comment inline with [KR] for the most part.
>
> Most of these come from the fact that "failure" here is not critical. If we can't make the procfs, we just comment about it in dmesg and carry on. If we fail to make the procfs structure here, we just report and carry on. The rest of the kernel can function without it, so failure isn't critical. But I should make this clear in the comments. There is no real error handling required, but we can clarify that with comments. I'll try to address this in a coming patch.
>
Part of the reason for error handling is just to silence static checker
warnings because otherwise everyone has to review it to see if the
resource leaks are important. It's easier in the long run to just fix
everything no matter how trivial.
regards,
dan carpenter
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2019-06-25 0:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-24 12:26 [bug report] drm/amdkfd: Add procfs-style information for KFD processes Dan Carpenter
2019-06-24 18:06 ` Russell, Kent
[not found] ` <BN6PR12MB16181F76E1F385E999A2219585E00-/b2+HYfkarRqaFUXYJa4HgdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-06-25 0:49 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625004935.GU18776@kadam \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=Kent.Russell-5C7GfCeVMHo@public.gmane.org \
--cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.