Re: [PATCH v2] xfs: test xfs_info on block device and mountpoint

[Eryu Guan <guaneryu@gmail.com>]

On Mon, Jun 24, 2019 at 09:21:03AM +0800, Zorro Lang wrote:
> On Sun, Jun 23, 2019 at 02:49:19PM -0700, Darrick J. Wong wrote:
> > On Sat, Jun 22, 2019 at 11:38:27PM +0800, Zorro Lang wrote:
> > > There was a bug, xfs_info fails on a mounted block device:
> > > 
> > >   # xfs_info /dev/mapper/testdev
> > >   xfs_info: /dev/mapper/testdev contains a mounted filesystem
> > > 
> > >   fatal error -- couldn't initialize XFS library
> > > 
> > > xfsprogs has fixed it by:
> > > 
> > >   bbb43745 xfs_info: use findmnt to handle mounted block devices
> > > 
> > > Signed-off-by: Zorro Lang <zlang@redhat.com>
> > 
> > Aha!  I remembered something -- xfs/449 already checks for consistency
> > in the various xfs geometry reports that each command provides, so why
> > not just add the $XFS_INFO_PROG $SCRATCH_DEV case at the end?
> 
> Wow, there're so many cases, can't sure what we've covered now:)
> 
> Sure, I can do this change on xfs/449, if Eryu thinks it's fine to increase
> the test coverage of a known case.

Given that we're having more and more tests and the test time grows
quickly, I'm fine now with adding such small & similar test to existing
test case to reuse the test setups, especially when XFS maintainer
agrees to do so :)

Thanks,
Eryu