Re: [PATCH v4 2/2] drm/exynos: trigger build of all modules

[Sam Ravnborg <sam@ravnborg.org>]

Hi Inki.

> > Alpha often needs one to pull in vmalloc.h - where all other
> > architectures get it indirect via other headers.
> > I have never bothered to find out why alpa needs more headers files,
> > but I always make sure to test things using alpha so 0-day do not yell at me.
> 
> I couldn't see any warning message while building your patch after dropping above change.
> Could you check it again on top of below git repo.?
>  git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
> 
> I'm going to request GIT-PULL as soon as you get back to me.

With the COMPILE_TEST patch, but without the extra fix I get:

  CC [M]  drivers/gpu/drm/exynos/exynos_drm_fbdev.o
/home/sam/kernel/drm-exynos/drivers/gpu/drm/exynos/exynos_drm_fbdev.c: In function ‘exynos_drm_fbdev_update’:
/home/sam/kernel/drm-exynos/drivers/gpu/drm/exynos/exynos_drm_fbdev.c:94:40: error: implicit declaration of function ‘vmap’; did you mean ‘bmap’? [-Werror=implicit-function-declaration]
  exynos_gem->kvaddr = (void __iomem *) vmap(exynos_gem->pages, nr_pages,
                                        ^~~~
                                        bmap
/home/sam/kernel/drm-exynos/drivers/gpu/drm/exynos/exynos_drm_fbdev.c:95:5: error: ‘VM_MAP’ undeclared (first use in this function); did you mean ‘VM_MPX’?
     VM_MAP, pgprot_writecombine(PAGE_KERNEL));
     ^~~~~~
     VM_MPX
/home/sam/kernel/drm-exynos/drivers/gpu/drm/exynos/exynos_drm_fbdev.c:95:5: note: each undeclared identifier is reported only once for each function it appears in
/home/sam/kernel/drm-exynos/drivers/gpu/drm/exynos/exynos_drm_fbdev.c: In function ‘exynos_drm_fbdev_destroy’:
/home/sam/kernel/drm-exynos/drivers/gpu/drm/exynos/exynos_drm_fbdev.c:243:2: error: implicit declaration of function ‘vunmap’; did you mean ‘iounmap’? [-Werror=implicit-function-declaration]
  vunmap(exynos_gem->kvaddr);
  ^~~~~~
  iounmap
cc1: some warnings being treated as errors


This is with a freshly pulled tree from drm-exynos.git exynos-drm-next

The warning only appear if you build for alpha.
So the extra fix is indeed needed. But always good to double check -
thanks for asking.

Note:
My gcc version for alpha:
$ alpha-linux-gnu-gcc --version
alpha-linux-gnu-gcc (Ubuntu 8.3.0-6ubuntu1) 8.3.0

	Sam
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel