From: Jeeeun Evans <jeeeunevans@gmail.com>
To: mchehab@kernel.org, gregkh@linuxfoundation.org, code@wizofe.uk,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] staging: media: davinci_vpfe: prefer using BIT macro
Date: Tue, 25 Jun 2019 11:51:13 +0100 [thread overview]
Message-ID: <20190625105113.GA22430@sausage> (raw)
Use BIT(x) instead of (1<<x), reported by checkpatch.pl.
Signed-off-by: Jeeeun Evans <jeeeunevans@gmail.com>
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.h | 2 +-
drivers/staging/media/davinci_vpfe/dm365_isif.h | 4 ++--
drivers/staging/media/davinci_vpfe/dm365_isif_regs.h | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.h b/drivers/staging/media/davinci_vpfe/dm365_ipipe.h
index 866ae12aeb07..de9b04683d82 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.h
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.h
@@ -99,7 +99,7 @@ struct ipipe_module_params {
#define IPIPE_PADS_NUM 2
#define IPIPE_OUTPUT_NONE 0
-#define IPIPE_OUTPUT_RESIZER (1 << 0)
+#define IPIPE_OUTPUT_RESIZER BIT(0)
enum ipipe_input_entity {
IPIPE_INPUT_NONE = 0,
diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif.h b/drivers/staging/media/davinci_vpfe/dm365_isif.h
index 0e1fe472fb2b..288a1211b387 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_isif.h
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif.h
@@ -172,8 +172,8 @@ enum isif_input_entity {
};
#define ISIF_OUTPUT_NONE (0)
-#define ISIF_OUTPUT_MEMORY (1 << 0)
-#define ISIF_OUTPUT_IPIPEIF (1 << 1)
+#define ISIF_OUTPUT_MEMORY BIT(0)
+#define ISIF_OUTPUT_IPIPEIF BIT(1)
struct vpfe_isif_device {
struct v4l2_subdev subdev;
diff --git a/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h b/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
index 6695680817b9..e64b75dc1e5a 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
+++ b/drivers/staging/media/davinci_vpfe/dm365_isif_regs.h
@@ -284,8 +284,8 @@
#define ISIF_LIN_ENTRY_MASK 0x3ff
/* masks and shifts*/
-#define ISIF_SYNCEN_VDHDEN_MASK (1 << 0)
-#define ISIF_SYNCEN_WEN_MASK (1 << 1)
+#define ISIF_SYNCEN_VDHDEN_MASK BIT(0)
+#define ISIF_SYNCEN_WEN_MASK BIT(1)
#define ISIF_SYNCEN_WEN_SHIFT 1
#endif /* _DAVINCI_VPFE_DM365_ISIF_REGS_H */
--
2.22.0
reply other threads:[~2019-06-25 10:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625105113.GA22430@sausage \
--to=jeeeunevans@gmail.com \
--cc=code@wizofe.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.