From: Kalle Valo <kvalo@codeaurora.org>
To: Miaoqing Pan <miaoqing@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
Miaoqing Pan <miaoqing@codeaurora.org>
Subject: Re: [PATCH v2] ath10k: fix failure to set multiple fixed rate
Date: Tue, 25 Jun 2019 13:02:32 +0000 (UTC) [thread overview]
Message-ID: <20190625130232.8582F608A5@smtp.codeaurora.org> (raw)
In-Reply-To: <1559117608-11117-1-git-send-email-miaoqing@codeaurora.org>
Miaoqing Pan <miaoqing@codeaurora.org> wrote:
> Currently, below fixed rate commands are broken,
> iw wlanx set bitrates legacy-<2.4|5> ht-mcs-<2.4|5> vht-mcs-<2.4|5> \
> <NSS:MCSx>
> iw wlanx set bitrates legacy-<2.4|5> <legacy rate> ht-mcs-<2.4|5> \
> vht-mcs-<2.4|5> <NSS:MCSx>
>
> There are two methods to set fixed rate, both failed,
> - Use vdev fixed rate command
> This command only support one single rate, but it's broken due to
> mac80211 change commit e8e4f5280ddd ("mac80211: reject/clear user
> rate mask if not usable"), which requires user to specify at least
> one legacy rate. So we can't use this command to set ht/vht single
> rate any more.
> - Use peer_assoc command
> This command can update rx capability for multiple rates, it will
> work fine for ht mcs rates, as each supported mcs can be advertised
> in ht_mcs index mask. But this will not work with vht rates because,
> as per the vht mcs capability advertisement, there are only two bits
> to indicate the supported mcs. E.g. only support 0-7, 0-8, 0-9.
>
> So introduced new WMI command: WMI_PEER_PARAM_FIXED_RATE. After peer
> assoc, the peer fixed rate cmd will work for that specific peer.
> Remaining peers will use auto rate. If both vdev fixed rate and peer
> fixed rates are given, peer fixed rate will take effect to peers for
> which this cmd is given. Remaining peers in that vdev, will use vdev
> fixed rate.
>
> Tested HW: QCA9984
> Tested FW: 10.4-3.9.0.2-00035
>
> Signed-off-by: Miaoqing Pan <miaoqing@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath-next branch of ath.git, thanks.
8b97b055dc9d ath10k: fix failure to set multiple fixed rate
--
https://patchwork.kernel.org/patch/10966425/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2019-06-25 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 8:13 [PATCH v2] ath10k: fix failure to set multiple fixed rate Miaoqing Pan
2019-05-29 8:13 ` Miaoqing Pan
2019-06-25 13:02 ` Kalle Valo
2019-06-25 13:02 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625130232.8582F608A5@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miaoqing@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.