From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Date: Tue, 25 Jun 2019 20:18:22 +0000 Subject: Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs Message-Id: <201906251312.5059C51334@keescook> List-Id: References: <20190625160103.GA13133@embeddedor> <2bdbbd7909c5c4ad96d32c0c5be4690292132a34.camel@perches.com> <201906251029.08B862130@keescook> <9c0d4ed622d6b8e47e040d398f764d52a9ac396d.camel@perches.com> In-Reply-To: <9c0d4ed622d6b8e47e040d398f764d52a9ac396d.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: linux-fbdev@vger.kernel.org, Michal Marek , Bartlomiej Zolnierkiewicz , Jingoo Han , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Masahiro Yamada , linux-kbuild On Tue, Jun 25, 2019 at 10:49:01AM -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 10:31 -0700, Kees Cook wrote: > > On Tue, Jun 25, 2019 at 09:52:23AM -0700, Joe Perches wrote: > > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > > cases where we are expecting to fall through. > > > [] > > > > This patch is part of the ongoing efforts to enable > > > > -Wimplicit-fallthrough. > > > > > > Just enable the thing already. > > > > Linus has been pretty clear about not wanting warning options enabled > > without first fixing all the cases it warns about first. > > Hey Kees. > > I don't recall that particular tidbit. Got a link? It was spread out over the discussion around removing __deprecated, about enabling -Wvla, and in person at the kernel summit when asking what approach to take for -Wimplicit-fallthrough. -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f196.google.com ([209.85.210.196]:42441 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbfFYUSZ (ORCPT ); Tue, 25 Jun 2019 16:18:25 -0400 Received: by mail-pf1-f196.google.com with SMTP id q10so10050792pff.9 for ; Tue, 25 Jun 2019 13:18:25 -0700 (PDT) Date: Tue, 25 Jun 2019 13:18:22 -0700 From: Kees Cook Subject: Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs Message-ID: <201906251312.5059C51334@keescook> References: <20190625160103.GA13133@embeddedor> <2bdbbd7909c5c4ad96d32c0c5be4690292132a34.camel@perches.com> <201906251029.08B862130@keescook> <9c0d4ed622d6b8e47e040d398f764d52a9ac396d.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9c0d4ed622d6b8e47e040d398f764d52a9ac396d.camel@perches.com> Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: Joe Perches Cc: "Gustavo A. R. Silva" , Jingoo Han , Bartlomiej Zolnierkiewicz , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Masahiro Yamada , Michal Marek , linux-kbuild On Tue, Jun 25, 2019 at 10:49:01AM -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 10:31 -0700, Kees Cook wrote: > > On Tue, Jun 25, 2019 at 09:52:23AM -0700, Joe Perches wrote: > > > On Tue, 2019-06-25 at 11:01 -0500, Gustavo A. R. Silva wrote: > > > > In preparation to enabling -Wimplicit-fallthrough, mark switch > > > > cases where we are expecting to fall through. > > > [] > > > > This patch is part of the ongoing efforts to enable > > > > -Wimplicit-fallthrough. > > > > > > Just enable the thing already. > > > > Linus has been pretty clear about not wanting warning options enabled > > without first fixing all the cases it warns about first. > > Hey Kees. > > I don't recall that particular tidbit. Got a link? It was spread out over the discussion around removing __deprecated, about enabling -Wvla, and in person at the kernel summit when asking what approach to take for -Wimplicit-fallthrough. -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kees Cook Subject: Re: [PATCH] video: fbdev: s3c-fb: Mark expected switch fall-throughs Date: Tue, 25 Jun 2019 13:18:22 -0700 Message-ID: <201906251312.5059C51334@keescook> References: <20190625160103.GA13133@embeddedor> <2bdbbd7909c5c4ad96d32c0c5be4690292132a34.camel@perches.com> <201906251029.08B862130@keescook> <9c0d4ed622d6b8e47e040d398f764d52a9ac396d.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf1-x444.google.com (mail-pf1-x444.google.com [IPv6:2607:f8b0:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1102D6E20F for ; Tue, 25 Jun 2019 20:18:25 +0000 (UTC) Received: by mail-pf1-x444.google.com with SMTP id 81so10035844pfy.13 for ; Tue, 25 Jun 2019 13:18:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <9c0d4ed622d6b8e47e040d398f764d52a9ac396d.camel@perches.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Joe Perches Cc: linux-fbdev@vger.kernel.org, Michal Marek , Bartlomiej Zolnierkiewicz , Jingoo Han , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Masahiro Yamada , linux-kbuild List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMjUsIDIwMTkgYXQgMTA6NDk6MDFBTSAtMDcwMCwgSm9lIFBlcmNoZXMgd3Jv dGU6Cj4gT24gVHVlLCAyMDE5LTA2LTI1IGF0IDEwOjMxIC0wNzAwLCBLZWVzIENvb2sgd3JvdGU6 Cj4gPiBPbiBUdWUsIEp1biAyNSwgMjAxOSBhdCAwOTo1MjoyM0FNIC0wNzAwLCBKb2UgUGVyY2hl cyB3cm90ZToKPiA+ID4gT24gVHVlLCAyMDE5LTA2LTI1IGF0IDExOjAxIC0wNTAwLCBHdXN0YXZv IEEuIFIuIFNpbHZhIHdyb3RlOgo+ID4gPiA+IEluIHByZXBhcmF0aW9uIHRvIGVuYWJsaW5nIC1X aW1wbGljaXQtZmFsbHRocm91Z2gsIG1hcmsgc3dpdGNoCj4gPiA+ID4gY2FzZXMgd2hlcmUgd2Ug YXJlIGV4cGVjdGluZyB0byBmYWxsIHRocm91Z2guCj4gPiA+IFtdCj4gPiA+ID4gVGhpcyBwYXRj aCBpcyBwYXJ0IG9mIHRoZSBvbmdvaW5nIGVmZm9ydHMgdG8gZW5hYmxlCj4gPiA+ID4gLVdpbXBs aWNpdC1mYWxsdGhyb3VnaC4KPiA+ID4gCj4gPiA+IEp1c3QgZW5hYmxlIHRoZSB0aGluZyBhbHJl YWR5Lgo+ID4gCj4gPiBMaW51cyBoYXMgYmVlbiBwcmV0dHkgY2xlYXIgYWJvdXQgbm90IHdhbnRp bmcgd2FybmluZyBvcHRpb25zIGVuYWJsZWQKPiA+IHdpdGhvdXQgZmlyc3QgZml4aW5nIGFsbCB0 aGUgY2FzZXMgaXQgd2FybnMgYWJvdXQgZmlyc3QuCj4gCj4gSGV5IEtlZXMuCj4gCj4gSSBkb24n dCByZWNhbGwgdGhhdCBwYXJ0aWN1bGFyIHRpZGJpdC4gIEdvdCBhIGxpbms/ICAKCkl0IHdhcyBz cHJlYWQgb3V0IG92ZXIgdGhlIGRpc2N1c3Npb24gYXJvdW5kIHJlbW92aW5nIF9fZGVwcmVjYXRl ZCwKYWJvdXQgZW5hYmxpbmcgLVd2bGEsIGFuZCBpbiBwZXJzb24gYXQgdGhlIGtlcm5lbCBzdW1t aXQgd2hlbiBhc2tpbmcKd2hhdCBhcHByb2FjaCB0byB0YWtlIGZvciAtV2ltcGxpY2l0LWZhbGx0 aHJvdWdoLgoKLS0gCktlZXMgQ29vawpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9kcmktZGV2ZWw=