From: Stefano Brivio <sbrivio@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: ssuryaextr@gmail.com, netdev@vger.kernel.org, dsahern@gmail.com
Subject: Re: [PATCH net] ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop
Date: Tue, 25 Jun 2019 21:59:12 +0200 [thread overview]
Message-ID: <20190625215912.7f95ac1a@redhat.com> (raw)
In-Reply-To: <20190625.124738.1945131933038317898.davem@davemloft.net>
On Tue, 25 Jun 2019 12:47:38 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:
> From: Stephen Suryaputra <ssuryaextr@gmail.com>
> Date: Mon, 24 Jun 2019 20:14:06 -0400
>
> > In commit 19e4e768064a8 ("ipv4: Fix raw socket lookup for local
> > traffic"), the dif argument to __raw_v4_lookup() is coming from the
> > returned value of inet_iif() but the change was done only for the first
> > lookup. Subsequent lookups in the while loop still use skb->dev->ifIndex.
> >
> > Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com>
>
> Applied and queued up for -stable.
>
> I added the appropriate Fixes: tag, please do so next time.
I was about to point that out, but then I noticed that this
doesn't actually fix 19e4e768064a8 ("ipv4: Fix raw socket lookup for
local traffic"), it's just related as it fixes the same issue in
another (very likely) path in the same function.
I think this should have been:
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
I *guess* for -stable purposes the effect is the same.
--
Stefano
prev parent reply other threads:[~2019-06-25 19:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 0:14 [PATCH net] ipv4: Use return value of inet_iif() for __raw_v4_lookup in the while loop Stephen Suryaputra
2019-06-25 17:51 ` David Ahern
2019-06-25 19:47 ` David Miller
2019-06-25 19:59 ` Stefano Brivio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190625215912.7f95ac1a@redhat.com \
--to=sbrivio@redhat.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ssuryaextr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.