Re: [PATCH 1/1] clk: clk-cdce925: Add regulator support

[Stephen Boyd <sboyd@kernel.org>]

Quoting Phil Reid (2019-06-13 20:52:43)
> The cdce925 power supplies could be controllable on some platforms.
> Enable them before communicating with the cdce925.
> 
> Signed-off-by: Phil Reid <preid@electromag.com.au>
> ---
> 
> Notes:
>     We see a kernel panic later in the boot if the regulator is not
>     enabled. Unsure what in the driver is causing that. Something
>     to do with regmap perhaps?
> 
>  drivers/clk/clk-cdce925.c | 34 ++++++++++++++++++++++++++++++++++
>  1 file changed, 34 insertions(+)
> 
> diff --git a/drivers/clk/clk-cdce925.c b/drivers/clk/clk-cdce925.c
> index a98b3f19..2678ee6 100644
> --- a/drivers/clk/clk-cdce925.c
> +++ b/drivers/clk/clk-cdce925.c
> @@ -16,6 +16,7 @@
>  #include <linux/module.h>
>  #include <linux/i2c.h>
>  #include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
>  #include <linux/slab.h>
>  #include <linux/gcd.h>
>  
> @@ -602,6 +603,30 @@ static int cdce925_regmap_i2c_read(void *context,
>         return &data->clk[idx].hw;
>  }
>  
> +static void cdce925_regulator_disable(void *regulator)
> +{
> +       regulator_disable(regulator);
> +}
> +
> +static int cdce925_regulator_enable(struct device *dev, const char *name)
> +{
> +       struct regulator *regulator;
> +       int err;
> +
> +       regulator = devm_regulator_get(dev, name);
> +       if (IS_ERR(regulator))
> +               return PTR_ERR(regulator);
> +
> +       err = regulator_enable(regulator);

The regulator is never turned off though. Are these regulators really
just always on regulators that don't need to be managed by this driver?

Also, is there an update to the DT binding somewhere?