From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Date: Tue, 25 Jun 2019 23:17:29 +0000 Subject: Re: [PATCH] drm: return -EFAULT if copy_one_buf() fails Message-Id: <20190625231729.GK17978@ZenIV.linux.org.uk> List-Id: References: <20190618125623.GA24896@mwanda> In-Reply-To: <20190618125623.GA24896@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Maxime Ripard , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Sean Paul On Tue, Jun 18, 2019 at 03:56:23PM +0300, Dan Carpenter wrote: > The copy_to_user() function returns the number of bytes remaining to be > copied, but we want to return -EFAULT. This function is called from > __drm_legacy_infobufs() which expects negative error codes. > > Fixes: 5c7640ab6258 ("switch compat_drm_infobufs() to drm_ioctl_kernel()") > Signed-off-by: Dan Carpenter > --- > This goes through Al's tree and not through drm. Presumably this patch > will just get folded into the original. Wha..? The original has been in mainline since v4.13, so it's a bit too late to fold anything into it... From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH] drm: return -EFAULT if copy_one_buf() fails Date: Wed, 26 Jun 2019 00:17:29 +0100 Message-ID: <20190625231729.GK17978@ZenIV.linux.org.uk> References: <20190618125623.GA24896@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [195.92.253.2]) by gabe.freedesktop.org (Postfix) with ESMTPS id B44E16E162 for ; Tue, 25 Jun 2019 23:35:33 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190618125623.GA24896@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter Cc: Maxime Ripard , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, David Airlie , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMTgsIDIwMTkgYXQgMDM6NTY6MjNQTSArMDMwMCwgRGFuIENhcnBlbnRlciB3 cm90ZToKPiBUaGUgY29weV90b191c2VyKCkgZnVuY3Rpb24gcmV0dXJucyB0aGUgbnVtYmVyIG9m IGJ5dGVzIHJlbWFpbmluZyB0byBiZQo+IGNvcGllZCwgYnV0IHdlIHdhbnQgdG8gcmV0dXJuIC1F RkFVTFQuICBUaGlzIGZ1bmN0aW9uIGlzIGNhbGxlZCBmcm9tCj4gX19kcm1fbGVnYWN5X2luZm9i dWZzKCkgd2hpY2ggZXhwZWN0cyBuZWdhdGl2ZSBlcnJvciBjb2Rlcy4KPiAKPiBGaXhlczogNWM3 NjQwYWI2MjU4ICgic3dpdGNoIGNvbXBhdF9kcm1faW5mb2J1ZnMoKSB0byBkcm1faW9jdGxfa2Vy bmVsKCkiKQo+IFNpZ25lZC1vZmYtYnk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3Jh Y2xlLmNvbT4KPiAtLS0KPiBUaGlzIGdvZXMgdGhyb3VnaCBBbCdzIHRyZWUgYW5kIG5vdCB0aHJv dWdoIGRybS4gIFByZXN1bWFibHkgdGhpcyBwYXRjaAo+IHdpbGwganVzdCBnZXQgZm9sZGVkIGlu dG8gdGhlIG9yaWdpbmFsLgoKV2hhLi4/ICBUaGUgb3JpZ2luYWwgaGFzIGJlZW4gaW4gbWFpbmxp bmUgc2luY2UgdjQuMTMsIHNvIGl0J3MgYSBiaXQgdG9vCmxhdGUgdG8gZm9sZCBhbnl0aGluZyBp bnRvIGl0Li4uCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==