From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <damien.lemoal@wdc.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH V2 1/3] block: Allow mapping of vmalloc-ed buffers
Date: Wed, 26 Jun 2019 08:10:16 +0200 [thread overview]
Message-ID: <20190626061016.GA23902@lst.de> (raw)
In-Reply-To: <20190626014759.15285-2-damien.lemoal@wdc.com>
On Wed, Jun 26, 2019 at 10:47:57AM +0900, Damien Le Moal wrote:
> @@ -1501,9 +1502,14 @@ struct bio *bio_map_kern(struct request_queue *q, void *data, unsigned int len,
> unsigned long end = (kaddr + len + PAGE_SIZE - 1) >> PAGE_SHIFT;
> unsigned long start = kaddr >> PAGE_SHIFT;
> const int nr_pages = end - start;
> + bool is_vmalloc = is_vmalloc_addr(data);
> + struct page *page;
> int offset, i;
> struct bio *bio;
>
> + if (is_vmalloc)
> + invalidate_kernel_vmap_range(data, len);
That is not correct.
The submission path needs an unconditional flush_kernel_vmap_range call,
and the read completion path will additionally need the
invalidate_kernel_vmap_range call.
next prev parent reply other threads:[~2019-06-26 6:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 1:47 [PATCH V2 0/3] Fix zone revalidation memory allocation failures Damien Le Moal
2019-06-26 1:47 ` [PATCH V2 1/3] block: Allow mapping of vmalloc-ed buffers Damien Le Moal
2019-06-26 6:10 ` Christoph Hellwig [this message]
2019-06-26 6:17 ` Damien Le Moal
2019-06-26 1:47 ` [PATCH V2 2/3] sd_zbc: Fix report zones buffer allocation Damien Le Moal
2019-06-26 1:47 ` [PATCH V2 3/3] block: Limit zone array allocation size Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626061016.GA23902@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=damien.lemoal@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.