From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mga09.intel.com ([134.134.136.24]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfuJQ-0000KO-IY for ath10k@lists.infradead.org; Tue, 25 Jun 2019 22:53:18 +0000 Date: Wed, 26 Jun 2019 06:52:59 +0800 From: kbuild test robot Subject: Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags Message-ID: <201906260657.2cnctJGF%lkp@intel.com> References: <20190625031726.12173-5-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20190625031726.12173-5-alastair@au1.ibm.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Alastair D'Silva Cc: linux-fbdev@vger.kernel.org, Stanislaw Gruszka , Petr Mladek , David Airlie , Joonas Lahtinen , dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, Jassi Brar , ath10k@lists.infradead.org, Steven Rostedt , alastair@d-silva.org, intel-gfx@lists.freedesktop.org, Dan Carpenter , Jose Abreu , Tom Lendacky , "James E.J. Bottomley" , Jani Nikula , linux-fsdevel@vger.kernel.org, Alexander Viro , Rodrigo Vivi , Benson Leung , Kalle Valo , Karsten Keil , "Martin K. Petersen" , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky , David Laight , kbuild-all@01.org, Daniel Vetter , netdev@vger.kernel.org, Enric Balletbo i Serra , Andrew Morton , "David S. Miller" Hi Alastair, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.2-rc6 next-20190625] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alastair-D-Silva/Hexdump-Enhancements/20190625-224046 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) sound/soc/intel/skylake/skl-debug.c:191:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] *to @@ got eref] *to @@ sound/soc/intel/skylake/skl-debug.c:191:34: sparse: expected void [noderef] *to sound/soc/intel/skylake/skl-debug.c:191:34: sparse: got unsigned char * sound/soc/intel/skylake/skl-debug.c:191:51: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const *from @@ got void [noderef] void const *from @@ sound/soc/intel/skylake/skl-debug.c:191:51: sparse: expected void const *from sound/soc/intel/skylake/skl-debug.c:191:51: sparse: got void [noderef] *[assigned] fw_reg_addr >> sound/soc/intel/skylake/skl-debug.c:195:35: sparse: sparse: too many arguments for function hex_dump_to_buffer -- >> drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c:93:27: sparse: sparse: too many arguments for function hex_dump_to_buffer -- >> sound/soc/sof/xtensa/core.c:125:35: sparse: sparse: too many arguments for function hex_dump_to_buffer vim +195 sound/soc/intel/skylake/skl-debug.c d14700a0 Vinod Koul 2017-06-30 170 bdd0384a Vunny Sodhi 2017-06-30 171 static ssize_t fw_softreg_read(struct file *file, char __user *user_buf, bdd0384a Vunny Sodhi 2017-06-30 172 size_t count, loff_t *ppos) bdd0384a Vunny Sodhi 2017-06-30 173 { bdd0384a Vunny Sodhi 2017-06-30 174 struct skl_debug *d = file->private_data; bdd0384a Vunny Sodhi 2017-06-30 175 struct sst_dsp *sst = d->skl->skl_sst->dsp; bdd0384a Vunny Sodhi 2017-06-30 176 size_t w0_stat_sz = sst->addr.w0_stat_sz; bdd0384a Vunny Sodhi 2017-06-30 177 void __iomem *in_base = sst->mailbox.in_base; bdd0384a Vunny Sodhi 2017-06-30 178 void __iomem *fw_reg_addr; bdd0384a Vunny Sodhi 2017-06-30 179 unsigned int offset; bdd0384a Vunny Sodhi 2017-06-30 180 char *tmp; bdd0384a Vunny Sodhi 2017-06-30 181 ssize_t ret = 0; bdd0384a Vunny Sodhi 2017-06-30 182 bdd0384a Vunny Sodhi 2017-06-30 183 tmp = kzalloc(FW_REG_BUF, GFP_KERNEL); bdd0384a Vunny Sodhi 2017-06-30 184 if (!tmp) bdd0384a Vunny Sodhi 2017-06-30 185 return -ENOMEM; bdd0384a Vunny Sodhi 2017-06-30 186 bdd0384a Vunny Sodhi 2017-06-30 187 fw_reg_addr = in_base - w0_stat_sz; bdd0384a Vunny Sodhi 2017-06-30 188 memset(d->fw_read_buff, 0, FW_REG_BUF); bdd0384a Vunny Sodhi 2017-06-30 189 bdd0384a Vunny Sodhi 2017-06-30 190 if (w0_stat_sz > 0) bdd0384a Vunny Sodhi 2017-06-30 @191 __iowrite32_copy(d->fw_read_buff, fw_reg_addr, w0_stat_sz >> 2); bdd0384a Vunny Sodhi 2017-06-30 192 bdd0384a Vunny Sodhi 2017-06-30 193 for (offset = 0; offset < FW_REG_SIZE; offset += 16) { bdd0384a Vunny Sodhi 2017-06-30 194 ret += snprintf(tmp + ret, FW_REG_BUF - ret, "%#.4x: ", offset); bdd0384a Vunny Sodhi 2017-06-30 @195 hex_dump_to_buffer(d->fw_read_buff + offset, 16, 16, 4, bdd0384a Vunny Sodhi 2017-06-30 196 tmp + ret, FW_REG_BUF - ret, 0); bdd0384a Vunny Sodhi 2017-06-30 197 ret += strlen(tmp + ret); bdd0384a Vunny Sodhi 2017-06-30 198 bdd0384a Vunny Sodhi 2017-06-30 199 /* print newline for each offset */ bdd0384a Vunny Sodhi 2017-06-30 200 if (FW_REG_BUF - ret > 0) bdd0384a Vunny Sodhi 2017-06-30 201 tmp[ret++] = '\n'; bdd0384a Vunny Sodhi 2017-06-30 202 } bdd0384a Vunny Sodhi 2017-06-30 203 bdd0384a Vunny Sodhi 2017-06-30 204 ret = simple_read_from_buffer(user_buf, count, ppos, tmp, ret); bdd0384a Vunny Sodhi 2017-06-30 205 kfree(tmp); bdd0384a Vunny Sodhi 2017-06-30 206 bdd0384a Vunny Sodhi 2017-06-30 207 return ret; bdd0384a Vunny Sodhi 2017-06-30 208 } bdd0384a Vunny Sodhi 2017-06-30 209 :::::: The code at line 195 was first introduced by commit :::::: bdd0384a5ada8bb5745e5f29c10a5ba88827efad ASoC: Intel: Skylake: Add support to read firmware registers :::::: TO: Vunny Sodhi :::::: CC: Mark Brown --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Date: Tue, 25 Jun 2019 22:52:59 +0000 Subject: Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags Message-Id: <201906260657.2cnctJGF%lkp@intel.com> List-Id: References: <20190625031726.12173-5-alastair@au1.ibm.com> In-Reply-To: <20190625031726.12173-5-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alastair D'Silva Cc: linux-fbdev@vger.kernel.org, Stanislaw Gruszka , Petr Mladek , David Airlie , dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, Jassi Brar , ath10k@lists.infradead.org, Steven Rostedt , alastair@d-silva.org, intel-gfx@lists.freedesktop.org, Dan Carpenter , Jose Abreu , Tom Lendacky , "James E.J. Bottomley" , linux-fsdevel@vger.kernel.org, Alexander Viro , Kalle Valo , Karsten Keil , "Martin K. Petersen" , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky Hi Alastair, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.2-rc6 next-20190625] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alastair-D-Silva/Hexdump-Enhancements/20190625-224046 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) sound/soc/intel/skylake/skl-debug.c:191:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] *to @@ got eref] *to @@ sound/soc/intel/skylake/skl-debug.c:191:34: sparse: expected void [noderef] *to sound/soc/intel/skylake/skl-debug.c:191:34: sparse: got unsigned char * sound/soc/intel/skylake/skl-debug.c:191:51: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const *from @@ got void [noderef] void const *from @@ sound/soc/intel/skylake/skl-debug.c:191:51: sparse: expected void const *from sound/soc/intel/skylake/skl-debug.c:191:51: sparse: got void [noderef] *[assigned] fw_reg_addr >> sound/soc/intel/skylake/skl-debug.c:195:35: sparse: sparse: too many arguments for function hex_dump_to_buffer -- >> drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c:93:27: sparse: sparse: too many arguments for function hex_dump_to_buffer -- >> sound/soc/sof/xtensa/core.c:125:35: sparse: sparse: too many arguments for function hex_dump_to_buffer vim +195 sound/soc/intel/skylake/skl-debug.c d14700a0 Vinod Koul 2017-06-30 170 bdd0384a Vunny Sodhi 2017-06-30 171 static ssize_t fw_softreg_read(struct file *file, char __user *user_buf, bdd0384a Vunny Sodhi 2017-06-30 172 size_t count, loff_t *ppos) bdd0384a Vunny Sodhi 2017-06-30 173 { bdd0384a Vunny Sodhi 2017-06-30 174 struct skl_debug *d = file->private_data; bdd0384a Vunny Sodhi 2017-06-30 175 struct sst_dsp *sst = d->skl->skl_sst->dsp; bdd0384a Vunny Sodhi 2017-06-30 176 size_t w0_stat_sz = sst->addr.w0_stat_sz; bdd0384a Vunny Sodhi 2017-06-30 177 void __iomem *in_base = sst->mailbox.in_base; bdd0384a Vunny Sodhi 2017-06-30 178 void __iomem *fw_reg_addr; bdd0384a Vunny Sodhi 2017-06-30 179 unsigned int offset; bdd0384a Vunny Sodhi 2017-06-30 180 char *tmp; bdd0384a Vunny Sodhi 2017-06-30 181 ssize_t ret = 0; bdd0384a Vunny Sodhi 2017-06-30 182 bdd0384a Vunny Sodhi 2017-06-30 183 tmp = kzalloc(FW_REG_BUF, GFP_KERNEL); bdd0384a Vunny Sodhi 2017-06-30 184 if (!tmp) bdd0384a Vunny Sodhi 2017-06-30 185 return -ENOMEM; bdd0384a Vunny Sodhi 2017-06-30 186 bdd0384a Vunny Sodhi 2017-06-30 187 fw_reg_addr = in_base - w0_stat_sz; bdd0384a Vunny Sodhi 2017-06-30 188 memset(d->fw_read_buff, 0, FW_REG_BUF); bdd0384a Vunny Sodhi 2017-06-30 189 bdd0384a Vunny Sodhi 2017-06-30 190 if (w0_stat_sz > 0) bdd0384a Vunny Sodhi 2017-06-30 @191 __iowrite32_copy(d->fw_read_buff, fw_reg_addr, w0_stat_sz >> 2); bdd0384a Vunny Sodhi 2017-06-30 192 bdd0384a Vunny Sodhi 2017-06-30 193 for (offset = 0; offset < FW_REG_SIZE; offset += 16) { bdd0384a Vunny Sodhi 2017-06-30 194 ret += snprintf(tmp + ret, FW_REG_BUF - ret, "%#.4x: ", offset); bdd0384a Vunny Sodhi 2017-06-30 @195 hex_dump_to_buffer(d->fw_read_buff + offset, 16, 16, 4, bdd0384a Vunny Sodhi 2017-06-30 196 tmp + ret, FW_REG_BUF - ret, 0); bdd0384a Vunny Sodhi 2017-06-30 197 ret += strlen(tmp + ret); bdd0384a Vunny Sodhi 2017-06-30 198 bdd0384a Vunny Sodhi 2017-06-30 199 /* print newline for each offset */ bdd0384a Vunny Sodhi 2017-06-30 200 if (FW_REG_BUF - ret > 0) bdd0384a Vunny Sodhi 2017-06-30 201 tmp[ret++] = '\n'; bdd0384a Vunny Sodhi 2017-06-30 202 } bdd0384a Vunny Sodhi 2017-06-30 203 bdd0384a Vunny Sodhi 2017-06-30 204 ret = simple_read_from_buffer(user_buf, count, ppos, tmp, ret); bdd0384a Vunny Sodhi 2017-06-30 205 kfree(tmp); bdd0384a Vunny Sodhi 2017-06-30 206 bdd0384a Vunny Sodhi 2017-06-30 207 return ret; bdd0384a Vunny Sodhi 2017-06-30 208 } bdd0384a Vunny Sodhi 2017-06-30 209 :::::: The code at line 195 was first introduced by commit :::::: bdd0384a5ada8bb5745e5f29c10a5ba88827efad ASoC: Intel: Skylake: Add support to read firmware registers :::::: TO: Vunny Sodhi :::::: CC: Mark Brown --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation From mboxrd@z Thu Jan 1 00:00:00 1970 From: kbuild test robot Subject: Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags Date: Wed, 26 Jun 2019 06:52:59 +0800 Message-ID: <201906260657.2cnctJGF%lkp@intel.com> References: <20190625031726.12173-5-alastair@au1.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190625031726.12173-5-alastair@au1.ibm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Alastair D'Silva Cc: linux-fbdev@vger.kernel.org, Stanislaw Gruszka , Petr Mladek , David Airlie , dri-devel@lists.freedesktop.org, devel@driverdev.osuosl.org, linux-scsi@vger.kernel.org, Jassi Brar , ath10k@lists.infradead.org, Steven Rostedt , alastair@d-silva.org, intel-gfx@lists.freedesktop.org, Dan Carpenter , Jose Abreu , Tom Lendacky , "James E.J. Bottomley" , linux-fsdevel@vger.kernel.org, Alexander Viro , Kalle Valo , Karsten Keil , "Martin K. Petersen" , Greg Kroah-Hartman , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Sergey Senozhatsky List-Id: linux-scsi@vger.kernel.org SGkgQWxhc3RhaXIsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaCEgUGVyaGFwcyBzb21ldGhpbmcg dG8gaW1wcm92ZToKClthdXRvIGJ1aWxkIHRlc3QgV0FSTklORyBvbiBsaW51cy9tYXN0ZXJdClth bHNvIGJ1aWxkIHRlc3QgV0FSTklORyBvbiB2NS4yLXJjNiBuZXh0LTIwMTkwNjI1XQpbaWYgeW91 ciBwYXRjaCBpcyBhcHBsaWVkIHRvIHRoZSB3cm9uZyBnaXQgdHJlZSwgcGxlYXNlIGRyb3AgdXMg YSBub3RlIHRvIGhlbHAgaW1wcm92ZSB0aGUgc3lzdGVtXQoKdXJsOiAgICBodHRwczovL2dpdGh1 Yi5jb20vMGRheS1jaS9saW51eC9jb21taXRzL0FsYXN0YWlyLUQtU2lsdmEvSGV4ZHVtcC1Fbmhh bmNlbWVudHMvMjAxOTA2MjUtMjI0MDQ2CnJlcHJvZHVjZToKICAgICAgICAjIGFwdC1nZXQgaW5z dGFsbCBzcGFyc2UKICAgICAgICAjIHNwYXJzZSB2ZXJzaW9uOiB2MC42LjEtcmMxLTctZzJiOTZj ZDgtZGlydHkKICAgICAgICBtYWtlIEFSQ0g9eDg2XzY0IGFsbG1vZGNvbmZpZwogICAgICAgIG1h a2UgQz0xIENGPSctZmRpYWdub3N0aWMtcHJlZml4IC1EX19DSEVDS19FTkRJQU5fXycKCklmIHlv dSBmaXggdGhlIGlzc3VlLCBraW5kbHkgYWRkIGZvbGxvd2luZyB0YWcKUmVwb3J0ZWQtYnk6IGti dWlsZCB0ZXN0IHJvYm90IDxsa3BAaW50ZWwuY29tPgoKCnNwYXJzZSB3YXJuaW5nczogKG5ldyBv bmVzIHByZWZpeGVkIGJ5ID4+KQoKICAgc291bmQvc29jL2ludGVsL3NreWxha2Uvc2tsLWRlYnVn LmM6MTkxOjM0OiBzcGFyc2U6IHNwYXJzZTogaW5jb3JyZWN0IHR5cGUgaW4gYXJndW1lbnQgMSAo ZGlmZmVyZW50IGFkZHJlc3Mgc3BhY2VzKSBAQCAgICBleHBlY3RlZCB2b2lkIFtub2RlcmVmXSA8 YXNuOjI+ICp0byBAQCAgICBnb3QgZXJlZl0gPGFzbjoyPiAqdG8gQEAKICAgc291bmQvc29jL2lu dGVsL3NreWxha2Uvc2tsLWRlYnVnLmM6MTkxOjM0OiBzcGFyc2U6ICAgIGV4cGVjdGVkIHZvaWQg W25vZGVyZWZdIDxhc246Mj4gKnRvCiAgIHNvdW5kL3NvYy9pbnRlbC9za3lsYWtlL3NrbC1kZWJ1 Zy5jOjE5MTozNDogc3BhcnNlOiAgICBnb3QgdW5zaWduZWQgY2hhciAqCiAgIHNvdW5kL3NvYy9p bnRlbC9za3lsYWtlL3NrbC1kZWJ1Zy5jOjE5MTo1MTogc3BhcnNlOiBzcGFyc2U6IGluY29ycmVj dCB0eXBlIGluIGFyZ3VtZW50IDIgKGRpZmZlcmVudCBhZGRyZXNzIHNwYWNlcykgQEAgICAgZXhw ZWN0ZWQgdm9pZCBjb25zdCAqZnJvbSBAQCAgICBnb3Qgdm9pZCBbbm9kZXJlZl0gPGFzbjoyPiB2 b2lkIGNvbnN0ICpmcm9tIEBACiAgIHNvdW5kL3NvYy9pbnRlbC9za3lsYWtlL3NrbC1kZWJ1Zy5j OjE5MTo1MTogc3BhcnNlOiAgICBleHBlY3RlZCB2b2lkIGNvbnN0ICpmcm9tCiAgIHNvdW5kL3Nv Yy9pbnRlbC9za3lsYWtlL3NrbC1kZWJ1Zy5jOjE5MTo1MTogc3BhcnNlOiAgICBnb3Qgdm9pZCBb bm9kZXJlZl0gPGFzbjoyPiAqW2Fzc2lnbmVkXSBmd19yZWdfYWRkcgo+PiBzb3VuZC9zb2MvaW50 ZWwvc2t5bGFrZS9za2wtZGVidWcuYzoxOTU6MzU6IHNwYXJzZTogc3BhcnNlOiB0b28gbWFueSBh cmd1bWVudHMgZm9yIGZ1bmN0aW9uIGhleF9kdW1wX3RvX2J1ZmZlcgotLQo+PiBkcml2ZXJzL2dw dS9kcm0vdGlueWRybS9jb3JlL3Rpbnlkcm0taGVscGVycy5jOjkzOjI3OiBzcGFyc2U6IHNwYXJz ZTogdG9vIG1hbnkgYXJndW1lbnRzIGZvciBmdW5jdGlvbiBoZXhfZHVtcF90b19idWZmZXIKLS0K Pj4gc291bmQvc29jL3NvZi94dGVuc2EvY29yZS5jOjEyNTozNTogc3BhcnNlOiBzcGFyc2U6IHRv byBtYW55IGFyZ3VtZW50cyBmb3IgZnVuY3Rpb24gaGV4X2R1bXBfdG9fYnVmZmVyCgp2aW0gKzE5 NSBzb3VuZC9zb2MvaW50ZWwvc2t5bGFrZS9za2wtZGVidWcuYwoKZDE0NzAwYTAgVmlub2QgS291 bCAgMjAxNy0wNi0zMCAgMTcwICAKYmRkMDM4NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCAgMTcx ICBzdGF0aWMgc3NpemVfdCBmd19zb2Z0cmVnX3JlYWQoc3RydWN0IGZpbGUgKmZpbGUsIGNoYXIg X191c2VyICp1c2VyX2J1ZiwKYmRkMDM4NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCAgMTcyICAJ CQkgICAgICAgc2l6ZV90IGNvdW50LCBsb2ZmX3QgKnBwb3MpCmJkZDAzODRhIFZ1bm55IFNvZGhp IDIwMTctMDYtMzAgIDE3MyAgewpiZGQwMzg0YSBWdW5ueSBTb2RoaSAyMDE3LTA2LTMwICAxNzQg IAlzdHJ1Y3Qgc2tsX2RlYnVnICpkID0gZmlsZS0+cHJpdmF0ZV9kYXRhOwpiZGQwMzg0YSBWdW5u eSBTb2RoaSAyMDE3LTA2LTMwICAxNzUgIAlzdHJ1Y3Qgc3N0X2RzcCAqc3N0ID0gZC0+c2tsLT5z a2xfc3N0LT5kc3A7CmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDE3NiAgCXNpemVf dCB3MF9zdGF0X3N6ID0gc3N0LT5hZGRyLncwX3N0YXRfc3o7CmJkZDAzODRhIFZ1bm55IFNvZGhp IDIwMTctMDYtMzAgIDE3NyAgCXZvaWQgX19pb21lbSAqaW5fYmFzZSA9IHNzdC0+bWFpbGJveC5p bl9iYXNlOwpiZGQwMzg0YSBWdW5ueSBTb2RoaSAyMDE3LTA2LTMwICAxNzggIAl2b2lkIF9faW9t ZW0gKmZ3X3JlZ19hZGRyOwpiZGQwMzg0YSBWdW5ueSBTb2RoaSAyMDE3LTA2LTMwICAxNzkgIAl1 bnNpZ25lZCBpbnQgb2Zmc2V0OwpiZGQwMzg0YSBWdW5ueSBTb2RoaSAyMDE3LTA2LTMwICAxODAg IAljaGFyICp0bXA7CmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDE4MSAgCXNzaXpl X3QgcmV0ID0gMDsKYmRkMDM4NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCAgMTgyICAKYmRkMDM4 NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCAgMTgzICAJdG1wID0ga3phbGxvYyhGV19SRUdfQlVG LCBHRlBfS0VSTkVMKTsKYmRkMDM4NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCAgMTg0ICAJaWYg KCF0bXApCmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDE4NSAgCQlyZXR1cm4gLUVO T01FTTsKYmRkMDM4NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCAgMTg2ICAKYmRkMDM4NGEgVnVu bnkgU29kaGkgMjAxNy0wNi0zMCAgMTg3ICAJZndfcmVnX2FkZHIgPSBpbl9iYXNlIC0gdzBfc3Rh dF9zejsKYmRkMDM4NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCAgMTg4ICAJbWVtc2V0KGQtPmZ3 X3JlYWRfYnVmZiwgMCwgRldfUkVHX0JVRik7CmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYt MzAgIDE4OSAgCmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDE5MCAgCWlmICh3MF9z dGF0X3N6ID4gMCkKYmRkMDM4NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCBAMTkxICAJCV9faW93 cml0ZTMyX2NvcHkoZC0+ZndfcmVhZF9idWZmLCBmd19yZWdfYWRkciwgdzBfc3RhdF9zeiA+PiAy KTsKYmRkMDM4NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCAgMTkyICAKYmRkMDM4NGEgVnVubnkg U29kaGkgMjAxNy0wNi0zMCAgMTkzICAJZm9yIChvZmZzZXQgPSAwOyBvZmZzZXQgPCBGV19SRUdf U0laRTsgb2Zmc2V0ICs9IDE2KSB7CmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDE5 NCAgCQlyZXQgKz0gc25wcmludGYodG1wICsgcmV0LCBGV19SRUdfQlVGIC0gcmV0LCAiJSMuNHg6 ICIsIG9mZnNldCk7CmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgQDE5NSAgCQloZXhf ZHVtcF90b19idWZmZXIoZC0+ZndfcmVhZF9idWZmICsgb2Zmc2V0LCAxNiwgMTYsIDQsCmJkZDAz ODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDE5NiAgCQkJCSAgIHRtcCArIHJldCwgRldfUkVH X0JVRiAtIHJldCwgMCk7CmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDE5NyAgCQly ZXQgKz0gc3RybGVuKHRtcCArIHJldCk7CmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAg IDE5OCAgCmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDE5OSAgCQkvKiBwcmludCBu ZXdsaW5lIGZvciBlYWNoIG9mZnNldCAqLwpiZGQwMzg0YSBWdW5ueSBTb2RoaSAyMDE3LTA2LTMw ICAyMDAgIAkJaWYgKEZXX1JFR19CVUYgLSByZXQgPiAwKQpiZGQwMzg0YSBWdW5ueSBTb2RoaSAy MDE3LTA2LTMwICAyMDEgIAkJCXRtcFtyZXQrK10gPSAnXG4nOwpiZGQwMzg0YSBWdW5ueSBTb2Ro aSAyMDE3LTA2LTMwICAyMDIgIAl9CmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDIw MyAgCmJkZDAzODRhIFZ1bm55IFNvZGhpIDIwMTctMDYtMzAgIDIwNCAgCXJldCA9IHNpbXBsZV9y ZWFkX2Zyb21fYnVmZmVyKHVzZXJfYnVmLCBjb3VudCwgcHBvcywgdG1wLCByZXQpOwpiZGQwMzg0 YSBWdW5ueSBTb2RoaSAyMDE3LTA2LTMwICAyMDUgIAlrZnJlZSh0bXApOwpiZGQwMzg0YSBWdW5u eSBTb2RoaSAyMDE3LTA2LTMwICAyMDYgIApiZGQwMzg0YSBWdW5ueSBTb2RoaSAyMDE3LTA2LTMw ICAyMDcgIAlyZXR1cm4gcmV0OwpiZGQwMzg0YSBWdW5ueSBTb2RoaSAyMDE3LTA2LTMwICAyMDgg IH0KYmRkMDM4NGEgVnVubnkgU29kaGkgMjAxNy0wNi0zMCAgMjA5ICAKCjo6Ojo6OiBUaGUgY29k ZSBhdCBsaW5lIDE5NSB3YXMgZmlyc3QgaW50cm9kdWNlZCBieSBjb21taXQKOjo6Ojo6IGJkZDAz ODRhNWFkYThiYjU3NDVlNWYyOWMxMGE1YmE4ODgyN2VmYWQgQVNvQzogSW50ZWw6IFNreWxha2U6 IEFkZCBzdXBwb3J0IHRvIHJlYWQgZmlybXdhcmUgcmVnaXN0ZXJzCgo6Ojo6OjogVE86IFZ1bm55 IFNvZGhpIDx2dW5ueXguc29kaGlAaW50ZWwuY29tPgo6Ojo6OjogQ0M6IE1hcmsgQnJvd24gPGJy b29uaWVAa2VybmVsLm9yZz4KCi0tLQowLURBWSBrZXJuZWwgdGVzdCBpbmZyYXN0cnVjdHVyZSAg ICAgICAgICAgICAgICBPcGVuIFNvdXJjZSBUZWNobm9sb2d5IENlbnRlcgpodHRwczovL2xpc3Rz LjAxLm9yZy9waXBlcm1haWwva2J1aWxkLWFsbCAgICAgICAgICAgICAgICAgICBJbnRlbCBDb3Jw b3JhdGlvbgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E615C48BD5 for ; Tue, 25 Jun 2019 22:53:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D66F220665 for ; Tue, 25 Jun 2019 22:53:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726422AbfFYWxQ (ORCPT ); Tue, 25 Jun 2019 18:53:16 -0400 Received: from mga03.intel.com ([134.134.136.65]:27018 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726357AbfFYWxP (ORCPT ); Tue, 25 Jun 2019 18:53:15 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Jun 2019 15:53:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,417,1557212400"; d="scan'208";a="188447174" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by fmsmga002.fm.intel.com with ESMTP; 25 Jun 2019 15:53:08 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1hfuJH-000Cwq-Tu; Wed, 26 Jun 2019 06:53:07 +0800 Date: Wed, 26 Jun 2019 06:52:59 +0800 From: kbuild test robot To: Alastair D'Silva Cc: kbuild-all@01.org, alastair@d-silva.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Dan Carpenter , Karsten Keil , Jassi Brar , Tom Lendacky , "David S. Miller" , Jose Abreu , Kalle Valo , Stanislaw Gruszka , Benson Leung , Enric Balletbo i Serra , "James E.J. Bottomley" , "Martin K. Petersen" , Greg Kroah-Hartman , Alexander Viro , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , David Laight , Andrew Morton , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fbdev@vger.kernel.org, devel@driverdev.osuosl.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags Message-ID: <201906260657.2cnctJGF%lkp@intel.com> References: <20190625031726.12173-5-alastair@au1.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190625031726.12173-5-alastair@au1.ibm.com> X-Patchwork-Hint: ignore User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi Alastair, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.2-rc6 next-20190625] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Alastair-D-Silva/Hexdump-Enhancements/20190625-224046 reproduce: # apt-get install sparse # sparse version: v0.6.1-rc1-7-g2b96cd8-dirty make ARCH=x86_64 allmodconfig make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' If you fix the issue, kindly add following tag Reported-by: kbuild test robot sparse warnings: (new ones prefixed by >>) sound/soc/intel/skylake/skl-debug.c:191:34: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] *to @@ got eref] *to @@ sound/soc/intel/skylake/skl-debug.c:191:34: sparse: expected void [noderef] *to sound/soc/intel/skylake/skl-debug.c:191:34: sparse: got unsigned char * sound/soc/intel/skylake/skl-debug.c:191:51: sparse: sparse: incorrect type in argument 2 (different address spaces) @@ expected void const *from @@ got void [noderef] void const *from @@ sound/soc/intel/skylake/skl-debug.c:191:51: sparse: expected void const *from sound/soc/intel/skylake/skl-debug.c:191:51: sparse: got void [noderef] *[assigned] fw_reg_addr >> sound/soc/intel/skylake/skl-debug.c:195:35: sparse: sparse: too many arguments for function hex_dump_to_buffer -- >> drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c:93:27: sparse: sparse: too many arguments for function hex_dump_to_buffer -- >> sound/soc/sof/xtensa/core.c:125:35: sparse: sparse: too many arguments for function hex_dump_to_buffer vim +195 sound/soc/intel/skylake/skl-debug.c d14700a0 Vinod Koul 2017-06-30 170 bdd0384a Vunny Sodhi 2017-06-30 171 static ssize_t fw_softreg_read(struct file *file, char __user *user_buf, bdd0384a Vunny Sodhi 2017-06-30 172 size_t count, loff_t *ppos) bdd0384a Vunny Sodhi 2017-06-30 173 { bdd0384a Vunny Sodhi 2017-06-30 174 struct skl_debug *d = file->private_data; bdd0384a Vunny Sodhi 2017-06-30 175 struct sst_dsp *sst = d->skl->skl_sst->dsp; bdd0384a Vunny Sodhi 2017-06-30 176 size_t w0_stat_sz = sst->addr.w0_stat_sz; bdd0384a Vunny Sodhi 2017-06-30 177 void __iomem *in_base = sst->mailbox.in_base; bdd0384a Vunny Sodhi 2017-06-30 178 void __iomem *fw_reg_addr; bdd0384a Vunny Sodhi 2017-06-30 179 unsigned int offset; bdd0384a Vunny Sodhi 2017-06-30 180 char *tmp; bdd0384a Vunny Sodhi 2017-06-30 181 ssize_t ret = 0; bdd0384a Vunny Sodhi 2017-06-30 182 bdd0384a Vunny Sodhi 2017-06-30 183 tmp = kzalloc(FW_REG_BUF, GFP_KERNEL); bdd0384a Vunny Sodhi 2017-06-30 184 if (!tmp) bdd0384a Vunny Sodhi 2017-06-30 185 return -ENOMEM; bdd0384a Vunny Sodhi 2017-06-30 186 bdd0384a Vunny Sodhi 2017-06-30 187 fw_reg_addr = in_base - w0_stat_sz; bdd0384a Vunny Sodhi 2017-06-30 188 memset(d->fw_read_buff, 0, FW_REG_BUF); bdd0384a Vunny Sodhi 2017-06-30 189 bdd0384a Vunny Sodhi 2017-06-30 190 if (w0_stat_sz > 0) bdd0384a Vunny Sodhi 2017-06-30 @191 __iowrite32_copy(d->fw_read_buff, fw_reg_addr, w0_stat_sz >> 2); bdd0384a Vunny Sodhi 2017-06-30 192 bdd0384a Vunny Sodhi 2017-06-30 193 for (offset = 0; offset < FW_REG_SIZE; offset += 16) { bdd0384a Vunny Sodhi 2017-06-30 194 ret += snprintf(tmp + ret, FW_REG_BUF - ret, "%#.4x: ", offset); bdd0384a Vunny Sodhi 2017-06-30 @195 hex_dump_to_buffer(d->fw_read_buff + offset, 16, 16, 4, bdd0384a Vunny Sodhi 2017-06-30 196 tmp + ret, FW_REG_BUF - ret, 0); bdd0384a Vunny Sodhi 2017-06-30 197 ret += strlen(tmp + ret); bdd0384a Vunny Sodhi 2017-06-30 198 bdd0384a Vunny Sodhi 2017-06-30 199 /* print newline for each offset */ bdd0384a Vunny Sodhi 2017-06-30 200 if (FW_REG_BUF - ret > 0) bdd0384a Vunny Sodhi 2017-06-30 201 tmp[ret++] = '\n'; bdd0384a Vunny Sodhi 2017-06-30 202 } bdd0384a Vunny Sodhi 2017-06-30 203 bdd0384a Vunny Sodhi 2017-06-30 204 ret = simple_read_from_buffer(user_buf, count, ppos, tmp, ret); bdd0384a Vunny Sodhi 2017-06-30 205 kfree(tmp); bdd0384a Vunny Sodhi 2017-06-30 206 bdd0384a Vunny Sodhi 2017-06-30 207 return ret; bdd0384a Vunny Sodhi 2017-06-30 208 } bdd0384a Vunny Sodhi 2017-06-30 209 :::::: The code at line 195 was first introduced by commit :::::: bdd0384a5ada8bb5745e5f29c10a5ba88827efad ASoC: Intel: Skylake: Add support to read firmware registers :::::: TO: Vunny Sodhi :::::: CC: Mark Brown --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation