From: Kalle Valo <kvalo@codeaurora.org>
To: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
Cc: ath11k@lists.infradead.org
Subject: Re: [PATCH] ath11k: Fix NULL pointer dereference in sta_statistics() callback
Date: Wed, 26 Jun 2019 07:55:21 +0000 (UTC) [thread overview]
Message-ID: <20190626075521.DBAD360E5A@smtp.codeaurora.org> (raw)
In-Reply-To: <1561439898-24320-1-git-send-email-vthiagar@codeaurora.org>
Vasanthakumar Thiagarajan <vthiagar@codeaurora.org> wrote:
> It is possible to dereference NULL arsta->rx_stats memory to get
> rssi information after STA disconnection. Instead of dereferencing
> a memory which is allocated/freed in sta_state() callback, add a
> new member for rssi in arsta itself and use it in sta_statistics().
>
> ath11k c000000.wifi1: Station 8c:fd:f0:0a:90:f3 moved to disassociated state
> ath11k c000000.wifi1: Removed peer: 8c:fd:f0:0a:90:f3 for VDEV: 0
> Unable to handle kernel NULL pointer dereference at virtual address 00000218
> Internal error: Oops: 5 [#1] PREEMPT SMP ARM
> PC is at ath11k_sta_statistics+0x90/0xa0 [ath11k]
> LR is at sta_set_sinfo+0xb8/0xcb4 [mac80211]
>
> Fixes: ecdb3adeda5c ("ath11k: Fix Rx signal strength reporting")
> Reported-by: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
> Signed-off-by: Vasanthakumar Thiagarajan <vthiagar@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Patch applied to ath11k-bringup branch of ath.git, thanks.
38934d6b0c2c ath11k: Fix NULL pointer dereference in sta_statistics() callback
--
https://patchwork.kernel.org/patch/11014709/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k
prev parent reply other threads:[~2019-06-26 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 5:18 [PATCH] ath11k: Fix NULL pointer dereference in sta_statistics() callback Vasanthakumar Thiagarajan
2019-06-26 7:55 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626075521.DBAD360E5A@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=ath11k@lists.infradead.org \
--cc=vthiagar@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.