All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefano Brivio <sbrivio@redhat.com>
To: Eric Dumazet <edumazet@google.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	netdev <netdev@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	David Ahern <dsahern@gmail.com>
Subject: Re: [PATCH net] ipv6: fix suspicious RCU usage in rt6_dump_route()
Date: Wed, 26 Jun 2019 12:34:36 +0200	[thread overview]
Message-ID: <20190626123436.2dd2f11d@redhat.com> (raw)
In-Reply-To: <20190626100528.218097-1-edumazet@google.com>

On Wed, 26 Jun 2019 03:05:28 -0700
Eric Dumazet <edumazet@google.com> wrote:

> syzbot reminded us that rt6_nh_dump_exceptions() needs to be called
> with rcu_read_lock()
> 
> net/ipv6/route.c:1593 suspicious rcu_dereference_check() usage!

Thanks for fixing this too.

Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

-- 
Stefano

  parent reply	other threads:[~2019-06-26 10:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26 10:05 [PATCH net] ipv6: fix suspicious RCU usage in rt6_dump_route() Eric Dumazet
2019-06-26 10:09 ` Eric Dumazet
2019-06-26 10:34 ` Stefano Brivio [this message]
2019-06-26 16:08 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626123436.2dd2f11d@redhat.com \
    --to=sbrivio@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=edumazet@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.