All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: Annaliese McDermond <nh6z@nh6z.net>
Cc: f.fainelli@gmail.com, wahrenst@gmx.net, swarren@wwwdotorg.org,
	team@nwdigitalradio.com, eric@anholt.net,
	linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] i2c: bcm2835: Move IRQ request after clock code in probe
Date: Wed, 26 Jun 2019 15:16:11 +0200	[thread overview]
Message-ID: <20190626131611.GD801@ninjato> (raw)
In-Reply-To: <20190621105250.19858-2-nh6z@nh6z.net>


[-- Attachment #1.1: Type: text/plain, Size: 535 bytes --]

On Fri, Jun 21, 2019 at 03:52:49AM -0700, Annaliese McDermond wrote:
> If any of the clock code in the probe fails and returns, the IRQ
> will not be freed.  Moving the IRQ request to last allows it to
> be freed on any errors further up in the probe function.  devm_
> calls can apparently not be used because there are some potential
> race conditions that will arise.
> 
> Fixes: bebff81fb8b9 ("i2c: bcm2835: Model Divider in CCF")
> 
> Signed-off-by: Annaliese McDermond <nh6z@nh6z.net>

Applied to for-next, thanks!


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-06-26 13:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-21 10:52 [PATCH v2 0/2] i2c: bcm2835: Fixes for clock changes in probe function Annaliese McDermond
2019-06-21 10:52 ` Annaliese McDermond
2019-06-21 10:52 ` [PATCH v2 1/2] i2c: bcm2835: Move IRQ request after clock code in probe Annaliese McDermond
2019-06-21 10:52   ` Annaliese McDermond
2019-06-26 13:16   ` Wolfram Sang [this message]
2019-06-21 10:52 ` [PATCH v2 2/2] i2c: bcm2835: Ensure clock exists when probing Annaliese McDermond
2019-06-21 10:52   ` Annaliese McDermond
2019-06-26 13:16   ` Wolfram Sang
2019-06-21 17:11 ` [PATCH v2 0/2] i2c: bcm2835: Fixes for clock changes in probe function Stefan Wahren
2019-06-21 17:11   ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626131611.GD801@ninjato \
    --to=wsa@the-dreams.de \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nh6z@nh6z.net \
    --cc=swarren@wwwdotorg.org \
    --cc=team@nwdigitalradio.com \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.