From: "Woods, Brian" <Brian.Woods@amd.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
"Woods, Brian" <Brian.Woods@amd.com>,
"Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>,
Jan Beulich <JBeulich@suse.com>
Subject: Re: [Xen-devel] [PATCH v2] AMD/IOMMU: don't "add" IOMMUs
Date: Wed, 26 Jun 2019 16:46:53 +0000 [thread overview]
Message-ID: <20190626164650.GA8299@amd.com> (raw)
In-Reply-To: <7ade78af-578a-3614-8f1e-f378c5cf7184@citrix.com>
On Wed, Jun 26, 2019 at 01:30:28PM +0100, Andy Cooper wrote:
> On 04/06/2019 13:15, Jan Beulich wrote:
> > For find_iommu_for_device() to consistently (independent of ACPI tables)
> > return NULL for the PCI devices corresponding to IOMMUs, make sure
> > IOMMUs don't get mapped to themselves by ivrs_mappings[].
> >
> > While amd_iommu_add_device() won't be called for IOMMUs from
> > pci_add_device(), as IOMMUs have got marked r/o,
> > _setup_hwdom_pci_devices() calls there nevertheless. Avoid issuing the
> > bogus debugging only "No iommu for ...; cannot be handed to ..." log
> > message as well as the non-debugging "setup ... for ... failed (-19)"
> > one.
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Brian Woods <brian.woods@amd.com>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
--
Brian Woods
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-06-26 16:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 12:15 [Xen-devel] [PATCH v2] AMD/IOMMU: don't "add" IOMMUs Jan Beulich
2019-06-26 12:30 ` Andrew Cooper
2019-06-26 16:46 ` Woods, Brian [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190626164650.GA8299@amd.com \
--to=brian.woods@amd.com \
--cc=JBeulich@suse.com \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.