From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
git@vger.kernel.org, jeffhost@microsoft.com
Subject: Re: [PATCH] trace2: correct typo in technical documentation
Date: Thu, 27 Jun 2019 12:49:09 +0200 [thread overview]
Message-ID: <20190627104909.GA21574@szeder.dev> (raw)
In-Reply-To: <20190626200303.9834-1-carenas@gmail.com>
On Wed, Jun 26, 2019 at 01:03:03PM -0700, Carlo Marcelo Arenas Belón wrote:
> an apparent typo for the environment variable was included with 81567caf87
> ("trace2: update docs to describe system/global config settings",
> 2019-04-15), and was missed when renamed variables by e4b75d6a1d
> ("trace2: rename environment variables to GIT_TRACE2*", 2019-05-19)
>
> Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
> ---
> Documentation/technical/api-trace2.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/technical/api-trace2.txt b/Documentation/technical/api-trace2.txt
> index 23c3cc7a37..f7ffe7d599 100644
> --- a/Documentation/technical/api-trace2.txt
> +++ b/Documentation/technical/api-trace2.txt
> @@ -35,7 +35,7 @@ Format details are given in a later section.
> === The Normal Format Target
>
> The normal format target is a tradition printf format and similar
> -to GIT_TRACE format. This format is enabled with the `GIT_TR`
> +to GIT_TRACE format. This format is enabled with the `GIT_TRACE2`
Carlo, thanks for catching this.
Junio, this patch should be applied on top of 'sg/trace2-rename' which
contains e4b75d6a1d. In current 'pu' it's applied on top of
'jh/trace2-sid-fix', which doesn't contain that commit and therefore
the rest of the codebase doesn't know about GIT_TRACE2 yet.
prev parent reply other threads:[~2019-06-27 10:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 20:03 [PATCH] trace2: correct typo in technical documentation Carlo Marcelo Arenas Belón
2019-06-26 20:14 ` Jeff Hostetler
2019-06-27 10:49 ` SZEDER Gábor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190627104909.GA21574@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.