Re: [PATCH] drm/panel: make drm_panel.h self-contained

From: Thierry Reding <thierry.reding@gmail.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: Boris Brezillon <boris.brezillon@bootlin.com>,
	intel-gfx@lists.freedesktop.org,
	Thierry Reding <treding@nvidia.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/panel: make drm_panel.h self-contained
Date: Thu, 27 Jun 2019 14:31:22 +0200	[thread overview]
Message-ID: <20190627123122.GC21242@ulmo> (raw)
In-Reply-To: <20190627110103.7539-1-jani.nikula@intel.com>


[-- Attachment #1.1: Type: text/plain, Size: 1239 bytes --]

On Thu, Jun 27, 2019 at 02:01:03PM +0300, Jani Nikula wrote:
> Fix build warning if drm_panel.h is built with CONFIG_OF=n or
> CONFIG_DRM_PANEL=n and included without the prerequisite err.h:
> 
> ./include/drm/drm_panel.h: In function ‘of_drm_find_panel’:
> ./include/drm/drm_panel.h:203:9: error: implicit declaration of function ‘ERR_PTR’ [-Werror=implicit-function-declaration]
>   return ERR_PTR(-ENODEV);
>          ^~~~~~~
> ./include/drm/drm_panel.h:203:9: error: returning ‘int’ from a function with return type ‘struct drm_panel *’ makes pointer from integer without a cast [-Werror=int-conversion]
>   return ERR_PTR(-ENODEV);
>          ^~~~~~~~~~~~~~~~
> 
> Fixes: 5fa8e4a22182 ("drm/panel: Make of_drm_find_panel() return an ERR_PTR() instead of NULL")
> Cc: Boris Brezillon <boris.brezillon@bootlin.com>
> Cc: Thierry Reding <treding@nvidia.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> 
> ---
> 
> I don't know if there's a combo where this actually fails, so I'm not
> adding cc: stable. It's just something I hit when playing with other
> code.
> ---
>  include/drm/drm_panel.h | 1 +
>  1 file changed, 1 insertion(+)

Acked-by: Thierry Reding <treding@nvidia.com>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx