From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B50C48BD7 for ; Thu, 27 Jun 2019 17:07:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 84CD4205F4 for ; Thu, 27 Jun 2019 17:07:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IccTeOGW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 84CD4205F4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=L/i0N2cfw+mnyPyheupG5FGSZMwXUmduPflVCOqmx9Y=; b=IccTeOGWrYdvKl 36mgSO2fUJfTa/aM0hsjYPeIO6/D+N52ds/NCNX253nQAzZ6tU4E+Byno1YM0B8epqT26gM56YWCZ BZ72CcJ5yU6G5KUwDWB0I2IJ1kutK8hOZKKL/X7r5F4Ehala97kCk14MlqMW0+idT0djDZ6e/bVeB FdKL3rFAobbFbP8T5mEq7/KqfIdWhXkrUJRyY4yk5gdo0wDL7rDmcztnIQjohT17xlhvN0TQssrPf +SWgz16jcZz20EX9L9IMECLeFEAXzn2rWOFwsMuXfOIsQbwDJwF1f3/Niv7cFJrnbg3+AYOUOVB0Z YYtGDiB21d5lxFel3p8A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgXrY-0006hW-5g; Thu, 27 Jun 2019 17:07:08 +0000 Received: from relay10.mail.gandi.net ([217.70.178.230]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgXrT-0006eM-Av for linux-mtd@lists.infradead.org; Thu, 27 Jun 2019 17:07:05 +0000 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 8FDC2240003; Thu, 27 Jun 2019 17:06:46 +0000 (UTC) Date: Thu, 27 Jun 2019 19:06:44 +0200 From: Miquel Raynal To: Schrempf Frieder Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Message-ID: <20190627190644.25aaaf31@xps13> In-Reply-To: <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> <20190625030807.GA11074@kroah.com> <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190627_100703_679098_3B80188D X-CRM114-Status: GOOD ( 14.86 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vignesh Raghavendra , Boris Brezillon , Greg KH , "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , liaoweixiong , Marek Vasut , "linux-mtd@lists.infradead.org" , Richard Weinberger , Brian Norris , Chuanhong Guo , David Woodhouse Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org SGVsbG8sCgpTY2hyZW1wZiBGcmllZGVyIDxmcmllZGVyLnNjaHJlbXBmQGtvbnRyb24uZGU+IHdy b3RlIG9uIFR1ZSwgMjUgSnVuCjIwMTkgMDc6MDQ6MDYgKzAwMDA6Cgo+IEhpIGxpYW93ZWl4aW9u ZywKPiAKPiBPbiAyNS4wNi4xOSAwNTowOCwgR3JlZyBLSCB3cm90ZToKPiA+IE9uIFR1ZSwgSnVu IDI1LCAyMDE5IGF0IDA5OjAyOjI5QU0gKzA4MDAsIGxpYW93ZWl4aW9uZyB3cm90ZTogIAo+ID4+ IEluIGNhc2Ugb2YgdGhlIGxhc3QgcGFnZSBjb250YWluaW5nIGJpdGZsaXBzIChyZXQgPiAwKSwK PiA+PiBzcGluYW5kX210ZF9yZWFkKCkgd2lsbCByZXR1cm4gdGhhdCBudW1iZXIgb2YgYml0Zmxp cHMgZm9yIHRoZSBsYXN0Cj4gPj4gcGFnZS4gQnV0IHRvIG1lIGl0IGxvb2tzIGxpa2UgaXQgc2hv dWxkIGluc3RlYWQgcmV0dXJuIG1heF9iaXRmbGlwcyBsaWtlCj4gPj4gaXQgZG9lcyB3aGVuIHRo ZSBsYXN0IHBhZ2UgcmVhZCByZXR1cm5zIHdpdGggMC4KPiA+Pgo+ID4+IFNpZ25lZC1vZmYtYnk6 IGxpYW93ZWl4aW9uZyA8bGlhb3dlaXhpb25nQGFsbHdpbm5lcnRlY2guY29tPgoKUGxlYXNlIHdy aXRlIHlvdXIgZW50aXJlIG9mZmljaWFsIGZpcnN0L2xhc3QgbmFtZShzKQoKPiA+PiBSZXZpZXdl ZC1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AY29sbGFib3JhLmNvbT4KPiA+ PiBSZXZpZXdlZC1ieTogRnJpZWRlciBTY2hyZW1wZiA8ZnJpZWRlci5zY2hyZW1wZkBrb250cm9u LmRlPgoKSSBhbSB3YWl0aW5nIHlvdXIgbmV4dCB2ZXJzaW9uIHdpdGggQWNrZWQtYnkgaW5zdGVh ZCBvZiBSZXdpZXZlZC1ieQp0YWdzIGFuZCBHcmVnJ3MgY29tbWVudCBhZGRyZXNzZWQuCj4gPj4g Rml4ZXM6IDc1MjlkZjQ2NTI0OCAoIm10ZDogbmFuZDogQWRkIGNvcmUgaW5mcmFzdHJ1Y3R1cmUg dG8gc3VwcG9ydCBTUEkgTkFORHMiKQoKRmluYWxseSwgd2hlbiB3ZSBhc2sgeW91IHRvIHJlc2Vu ZCBhIHBhdGNoLCBpdCBtZWFucyBzZW5kaW5nIGEgbmV3CnZlcnNpb24gb2YgdGhlIHBhdGNoLiBT byBpbiB0aGUgc3ViamVjdCwgeW91IHNob3VsZCBub3QgdXNlIHRoZQpbUkVTRU5EXSBrZXl3b3Jk ICh3aGljaCBtZWFucyB5b3UgYXJlIHNlbmRpbmcgc29tZXRoaW5nIGFnYWluIGV4YWN0bHkKYXMg aXQgd2FzIGJlZm9yZSwgeW91IGp1c3QgZ290IGlnbm9yZWQsIGZvciBleGFtcGxlKSBidXQgaW5z dGVhZCB5b3UKc2hvdWxkIGluY3JlbWVudCB0aGUgdmVyc2lvbiBudW1iZXIgKHYzKSBhbmQgYWxz byB3cml0ZSBhIG5pY2UKY2hhbmdlbG9nIGFmdGVyIHRoZSB0aHJlZSBkYXNoZXMgJy0tLScgKHdp bGwgYmUgaWdub3JlZCBieSBHaXQgd2hlbgphcHBseWluZykuCgpJIHdvdWxkIGxpa2UgdG8gcXVl dWUgdGhpcyBmb3IgdGhlIG5leHQgcmVsZWFzZSBzbyBpZiB5b3UgY2FuIGRvIGl0CkFTQVAsIHRo YXQgd291bGQgYmUgZ3JlYXQuCgpUaGFuayB5b3UsCk1pcXXDqGwKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lv biBtYWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5m by9saW51eC1tdGQvCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4037FC48BD9 for ; Thu, 27 Jun 2019 17:06:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1991A2146E for ; Thu, 27 Jun 2019 17:06:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726632AbfF0RGz convert rfc822-to-8bit (ORCPT ); Thu, 27 Jun 2019 13:06:55 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:48951 "EHLO relay10.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726405AbfF0RGz (ORCPT ); Thu, 27 Jun 2019 13:06:55 -0400 Received: from xps13 (unknown [91.224.148.103]) (Authenticated sender: miquel.raynal@bootlin.com) by relay10.mail.gandi.net (Postfix) with ESMTPSA id 8FDC2240003; Thu, 27 Jun 2019 17:06:46 +0000 (UTC) Date: Thu, 27 Jun 2019 19:06:44 +0200 From: Miquel Raynal To: Schrempf Frieder Cc: liaoweixiong , Greg KH , Vignesh Raghavendra , Boris Brezillon , "Richard Weinberger" , "linux-kernel@vger.kernel.org" , Chuanhong Guo , "Marek Vasut" , "linux-mtd@lists.infradead.org" , "stable@vger.kernel.org" , Brian Norris , David Woodhouse Subject: Re: [RESEND PATCH v2] mtd: spinand: read return badly if the last page has bitflips Message-ID: <20190627190644.25aaaf31@xps13> In-Reply-To: <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> References: <1561424549-784-1-git-send-email-liaoweixiong@allwinnertech.com> <20190625030807.GA11074@kroah.com> <97adf58f-4771-90f1-bdaf-5a9d00eef768@kontron.de> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Schrempf Frieder wrote on Tue, 25 Jun 2019 07:04:06 +0000: > Hi liaoweixiong, > > On 25.06.19 05:08, Greg KH wrote: > > On Tue, Jun 25, 2019 at 09:02:29AM +0800, liaoweixiong wrote: > >> In case of the last page containing bitflips (ret > 0), > >> spinand_mtd_read() will return that number of bitflips for the last > >> page. But to me it looks like it should instead return max_bitflips like > >> it does when the last page read returns with 0. > >> > >> Signed-off-by: liaoweixiong Please write your entire official first/last name(s) > >> Reviewed-by: Boris Brezillon > >> Reviewed-by: Frieder Schrempf I am waiting your next version with Acked-by instead of Rewieved-by tags and Greg's comment addressed. > >> Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") Finally, when we ask you to resend a patch, it means sending a new version of the patch. So in the subject, you should not use the [RESEND] keyword (which means you are sending something again exactly as it was before, you just got ignored, for example) but instead you should increment the version number (v3) and also write a nice changelog after the three dashes '---' (will be ignored by Git when applying). I would like to queue this for the next release so if you can do it ASAP, that would be great. Thank you, Miquèl