From mboxrd@z Thu Jan 1 00:00:00 1970 From: Xin Ji Subject: Re: [PATCH v1] Adjust analogix chip driver location Date: Fri, 28 Jun 2019 02:47:15 +0000 Message-ID: <20190628024706.GA15852@xin-VirtualBox> References: <20190627112939.GA4832@xin-VirtualBox> <20190627115705.GB5021@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190627115705.GB5021@pendragon.ideasonboard.com> Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: Laurent Pinchart Cc: "gregkh@linuxfoundation.org" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , "sjoerd.simons@collabora.co.uk" , David Airlie , Daniel Vetter , "dri-devel@lists.freedesktop.org" , Sheng Pan List-Id: dri-devel@lists.freedesktop.org On Thu, Jun 27, 2019 at 07:57:05PM +0800, Laurent Pinchart wrote: > Hello Xin Ji, >=20 > Thank you for the patch. >=20 > On Thu, Jun 27, 2019 at 11:29:47AM +0000, Xin Ji wrote: > > Move analogix chip ANX78XX bridge driver into "analogix" directory. > >=20 > > Signed-off-by: Xin Ji > > --- > > drivers/gpu/drm/bridge/Kconfig | 10 --------= -- > > drivers/gpu/drm/bridge/Makefile | 3 +-- > > drivers/gpu/drm/bridge/analogix/Kconfig | 10 ++++++++= ++ > > drivers/gpu/drm/bridge/analogix/Makefile | 2 ++ > > drivers/gpu/drm/bridge/{ =3D> analogix}/analogix-anx78xx.c | 0 > > drivers/gpu/drm/bridge/{ =3D> analogix}/analogix-anx78xx.h | 0 > > 6 files changed, 13 insertions(+), 12 deletions(-) > > rename drivers/gpu/drm/bridge/{ =3D> analogix}/analogix-anx78xx.c (100= %) > > rename drivers/gpu/drm/bridge/{ =3D> analogix}/analogix-anx78xx.h (100= %) > >=20 > > diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kc= onfig > > index ee77746..862789b 100644 > > --- a/drivers/gpu/drm/bridge/Kconfig > > +++ b/drivers/gpu/drm/bridge/Kconfig > > @@ -16,16 +16,6 @@ config DRM_PANEL_BRIDGE > > menu "Display Interface Bridges" > > depends on DRM && DRM_BRIDGE > > =20 > > -config DRM_ANALOGIX_ANX78XX > > - tristate "Analogix ANX78XX bridge" > > - select DRM_KMS_HELPER > > - select REGMAP_I2C > > - ---help--- > > - ANX78XX is an ultra-low Full-HD SlimPort transmitter > > - designed for portable devices. The ANX78XX transforms > > - the HDMI output of an application processor to MyDP > > - or DisplayPort. > > - > > config DRM_CDNS_DSI > > tristate "Cadence DPI/DSI bridge" > > select DRM_KMS_HELPER > > diff --git a/drivers/gpu/drm/bridge/Makefile b/drivers/gpu/drm/bridge/M= akefile > > index 4934fcf..02cb4cd 100644 > > --- a/drivers/gpu/drm/bridge/Makefile > > +++ b/drivers/gpu/drm/bridge/Makefile > > @@ -1,5 +1,4 @@ > > # SPDX-License-Identifier: GPL-2.0 > > -obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) +=3D analogix-anx78xx.o > > obj-$(CONFIG_DRM_CDNS_DSI) +=3D cdns-dsi.o > > obj-$(CONFIG_DRM_DUMB_VGA_DAC) +=3D dumb-vga-dac.o > > obj-$(CONFIG_DRM_LVDS_ENCODER) +=3D lvds-encoder.o > > @@ -12,8 +11,8 @@ obj-$(CONFIG_DRM_SII9234) +=3D sii9234.o > > obj-$(CONFIG_DRM_THINE_THC63LVD1024) +=3D thc63lvd1024.o > > obj-$(CONFIG_DRM_TOSHIBA_TC358764) +=3D tc358764.o > > obj-$(CONFIG_DRM_TOSHIBA_TC358767) +=3D tc358767.o > > -obj-$(CONFIG_DRM_ANALOGIX_DP) +=3D analogix/ > > obj-$(CONFIG_DRM_I2C_ADV7511) +=3D adv7511/ > > obj-$(CONFIG_DRM_TI_SN65DSI86) +=3D ti-sn65dsi86.o > > obj-$(CONFIG_DRM_TI_TFP410) +=3D ti-tfp410.o > > obj-y +=3D synopsys/ > > +obj-y +=3D analogix/ >=20 > Could you place that line just above the synopsys/ directory, to have > them alphabetically sorted (this could also be done while applying) ? > Apart from that the patch looks good to me, so OK, I'll submit new patch, thanks! >=20 > Reviewed-by: Laurent Pinchart >=20 > > diff --git a/drivers/gpu/drm/bridge/analogix/Kconfig b/drivers/gpu/drm/= bridge/analogix/Kconfig > > index e930ff9..dfe84f5 100644 > > --- a/drivers/gpu/drm/bridge/analogix/Kconfig > > +++ b/drivers/gpu/drm/bridge/analogix/Kconfig > > @@ -1,4 +1,14 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > +config DRM_ANALOGIX_ANX78XX > > + tristate "Analogix ANX78XX bridge" > > + select DRM_KMS_HELPER > > + select REGMAP_I2C > > + ---help--- > > + ANX78XX is an ultra-low Full-HD SlimPort transmitter > > + designed for portable devices. The ANX78XX transforms > > + the HDMI output of an application processor to MyDP > > + or DisplayPort. > > + > > config DRM_ANALOGIX_DP > > tristate > > depends on DRM > > diff --git a/drivers/gpu/drm/bridge/analogix/Makefile b/drivers/gpu/drm= /bridge/analogix/Makefile > > index fdbf3fd..d4c54ac 100644 > > --- a/drivers/gpu/drm/bridge/analogix/Makefile > > +++ b/drivers/gpu/drm/bridge/analogix/Makefile > > @@ -1,3 +1,5 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > +obj-$(CONFIG_DRM_ANALOGIX_ANX78XX) +=3D analogix-anx78xx.o > > + > > analogix_dp-objs :=3D analogix_dp_core.o analogix_dp_reg.o > > obj-$(CONFIG_DRM_ANALOGIX_DP) +=3D analogix_dp.o > > diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.c b/drivers/gpu/dr= m/bridge/analogix/analogix-anx78xx.c > > similarity index 100% > > rename from drivers/gpu/drm/bridge/analogix-anx78xx.c > > rename to drivers/gpu/drm/bridge/analogix/analogix-anx78xx.c > > diff --git a/drivers/gpu/drm/bridge/analogix-anx78xx.h b/drivers/gpu/dr= m/bridge/analogix/analogix-anx78xx.h > > similarity index 100% > > rename from drivers/gpu/drm/bridge/analogix-anx78xx.h > > rename to drivers/gpu/drm/bridge/analogix/analogix-anx78xx.h >=20 > --=20 > Regards, >=20 > Laurent Pinchart