All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nikolaus Voss <nikolaus.voss@loewensteinmedical.de>
Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	nv@vosn.de
Subject: Re: [PATCH] drivers/usb/typec/tps6598x.c: fix two bugs
Date: Fri, 28 Jun 2019 10:18:46 +0200	[thread overview]
Message-ID: <20190628081846.GA19778@kroah.com> (raw)
In-Reply-To: <20190628081235.19205-1-nikolaus.voss@loewensteinmedical.de>

On Fri, Jun 28, 2019 at 10:12:35AM +0200, Nikolaus Voss wrote:
> 1. Portinfo bit field is 3 bits wide, not 2 bits. This led to
>    a wrong driver configuration for some tps6598x configurations.
> 
> 2. Writing 4CC commands with tps6598x_write_4cc() already has
>    a pointer arg, don't reference it when using as arg to
>    tps6598x_block_write(). Correcting this enforces the constness
>    of the pointer to propagate to tps6598x_block_write(), so add
>    the const qualifier there to avoid the warning.

Please split this up into two seprate patches as these are doing two
different things.

thanks,

greg k-h

  reply	other threads:[~2019-06-28  8:18 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  8:12 [PATCH] drivers/usb/typec/tps6598x.c: fix two bugs Nikolaus Voss
2019-06-28  8:18 ` Greg Kroah-Hartman [this message]
2019-06-28  8:34 ` Heikki Krogerus
2019-06-28  9:01   ` [PATCH 1/2] drivers/usb/typec/tps6598x.c: fix portinfo width Nikolaus Voss
2019-06-28  9:58     ` Heikki Krogerus
2019-06-28 10:10       ` Nikolaus Voss
2019-07-03 16:39         ` Greg Kroah-Hartman
2019-07-03 17:25           ` Nikolaus Voss
2019-07-03 17:37             ` Greg Kroah-Hartman
2019-06-28  9:01   ` [PATCH 2/2] drivers/usb/typec/tps6598x.c: fix 4CC cmd write Nikolaus Voss
2019-06-28  9:59     ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628081846.GA19778@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nikolaus.voss@loewensteinmedical.de \
    --cc=nv@vosn.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.