All of lore.kernel.org
 help / color / mirror / Atom feed
From: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Ingo Molnar <mingo@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Frederic Weisbecker <frederic@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH RESEND v3] sched/isolation: Prefer housekeeping cpu in local node
Date: Fri, 28 Jun 2019 08:44:38 +0000	[thread overview]
Message-ID: <20190628084438.GA22550@linux.vnet.ibm.com> (raw)
In-Reply-To: <CANRm+Cz4R5OOga34DDepCP_yOtXXCqTxD8bs_rvgtQbjS8d1hw@mail.gmail.com>

> 
> -#endif /* CONFIG_NUMA */
> -
>  /*
>   * sched_numa_find_closest() - given the NUMA topology, find the cpu
>   *                             closest to @cpu from @cpumask.
>   * cpumask: cpumask to find a cpu from
>   * cpu: cpu to be close to
>   *
> - * returns: cpu, or >= nr_cpu_ids when nothing found (or !NUMA).
> + * returns: cpu, or nr_cpu_ids when nothing found.
>   */
>  int sched_numa_find_closest(const struct cpumask *cpus, int cpu)
>  {
> -#ifdef CONFIG_NUMA
>      int i, j = cpu_to_node(cpu);
> 
>      for (i = 0; i < sched_domains_numa_levels; i++) {
> @@ -1754,10 +1751,11 @@ int sched_numa_find_closest(const struct
> cpumask *cpus, int cpu)
>          if (cpu < nr_cpu_ids)
>              return cpu;
>      }
> -#endif
>      return nr_cpu_ids;
>  }
> 
> +#endif /* CONFIG_NUMA */
> +
>  static int __sdt_alloc(const struct cpumask *cpu_map)
>  {
>      struct sched_domain_topology_level *tl;
> 

Looks good to me.

Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>

-- 
Thanks and Regards
Srikar Dronamraju


  reply	other threads:[~2019-06-28  8:44 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  0:43 [PATCH v2] sched/nohz: Optimize get_nohz_timer_target() Wanpeng Li
2019-06-28  0:43 ` [PATCH RESEND v3] sched/isolation: Prefer housekeeping cpu in local node Wanpeng Li
2019-06-28  1:18   ` Frederic Weisbecker
2019-06-28  6:58   ` Srikar Dronamraju
2019-06-28  7:19     ` Wanpeng Li
2019-06-28  8:44       ` Srikar Dronamraju [this message]
2019-06-28  1:10 ` [PATCH v2] sched/nohz: Optimize get_nohz_timer_target() Frederic Weisbecker
2019-10-23  8:16   ` Wanpeng Li
2019-10-23  8:29     ` Thomas Gleixner
2019-10-23  9:25       ` Wanpeng Li
2020-01-06  6:21       ` Wanpeng Li
2020-01-10 14:12         ` Thomas Gleixner
2020-01-13  1:32           ` Wanpeng Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628084438.GA22550@linux.vnet.ibm.com \
    --to=srikar@linux.vnet.ibm.com \
    --cc=frederic@kernel.org \
    --cc=kernellwp@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.