Re: [dpdk-dev] [PATCH 1/2] eal: fix duplicate experimental tag

[Stephen Hemminger <stephen@networkplumber.org>]

On Fri, 28 Jun 2019 17:56:34 +0200
Adrien Mazarguil <adrien.mazarguil@6wind.com> wrote:

> Its presence on the function prototype in the header file is enough.
> 
> Fixes: 5f4ed3f05849 ("eal: introduce random generator with upper bound")
> Cc: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
> 
> Signed-off-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
> ---
>  lib/librte_eal/common/rte_random.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_eal/common/rte_random.c b/lib/librte_eal/common/rte_random.c
> index 3d9b9b7d8..f85119048 100644
> --- a/lib/librte_eal/common/rte_random.c
> +++ b/lib/librte_eal/common/rte_random.c
> @@ -137,7 +137,7 @@ rte_rand(void)
>  	return __rte_rand_lfsr258(state);
>  }
>  
> -uint64_t __rte_experimental
> +uint64_t
>  rte_rand_max(uint64_t upper_bound)
>  {
>  	struct rte_rand_state *state;

Almost any __rte_experimental in a .c file is wrong.
The experimental tag is supposed to be on the prototype in the header.

This seems to be a common problem:
./drivers/net/atlantic/rte_pmd_atlantic.c
./drivers/net/dpaa2/dpaa2_ethdev.c
./drivers/net/ixgbe/rte_pmd_ixgbe.c
./lib/librte_bbdev/rte_bbdev.c
./lib/librte_bpf/bpf.c
./lib/librte_bpf/bpf_exec.c
./lib/librte_bpf/bpf_load.c
./lib/librte_bpf/bpf_load_elf.c
./lib/librte_bpf/bpf_pkt.c
./lib/librte_compressdev/rte_comp.c
./lib/librte_compressdev/rte_compressdev.c
./lib/librte_compressdev/rte_compressdev_pmd.c
./lib/librte_cryptodev/rte_cryptodev.c
./lib/librte_eal/common/eal_common_class.c
./lib/librte_eal/common/eal_common_dev.c
./lib/librte_eal/common/eal_common_fbarray.c
./lib/librte_eal/common/eal_common_log.c
./lib/librte_eal/common/eal_common_memory.c
./lib/librte_eal/common/eal_common_proc.c
./lib/librte_eal/common/eal_common_timer.c
./lib/librte_eal/common/rte_malloc.c
./lib/librte_eal/common/rte_option.c
./lib/librte_eal/common/rte_random.c
./lib/librte_eal/common/rte_service.c
./lib/librte_eal/freebsd/eal/eal.c
./lib/librte_eal/freebsd/eal/eal_dev.c
./lib/librte_eal/freebsd/eal/eal_interrupts.c
./lib/librte_eal/linux/eal/eal_dev.c
./lib/librte_eal/linux/eal/eal_interrupts.c
./lib/librte_eal/linux/eal/eal_vfio.c
./lib/librte_ethdev/rte_ethdev.c
./lib/librte_ethdev/rte_flow.c
./lib/librte_ethdev/rte_mtr.c
./lib/librte_eventdev/rte_event_eth_rx_adapter.c
./lib/librte_flow_classify/rte_flow_classify.c
./lib/librte_hash/rte_cuckoo_hash.c
./lib/librte_ip_frag/rte_ip_frag_common.c
./lib/librte_ipsec/sa.c
./lib/librte_ipsec/ses.c
./lib/librte_kni/rte_kni.c
./lib/librte_kvargs/rte_kvargs.c
./lib/librte_mbuf/rte_mbuf.c
./lib/librte_meter/rte_meter.c
./lib/librte_net/rte_arp.c
./lib/librte_net/rte_net.c
./lib/librte_power/rte_power_empty_poll.c
./lib/librte_rcu/rte_rcu_qsbr.c
./lib/librte_sched/rte_sched.c
./lib/librte_security/rte_security.c
./lib/librte_telemetry/rte_telemetry.c
./lib/librte_telemetry/rte_telemetry_parser.c
./lib/librte_timer/rte_timer.c
./lib/librte_vhost/vdpa.c
./lib/librte_vhost/vhost_crypto.c