All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Crispin <john@phrozen.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: John Crispin <john@phrozen.org>,
	ath11k@lists.infradead.org,
	Rajkumar Manoharan <rmanohar@qti.qualcomm.com>
Subject: [RFC 2/2] ath11k: drop memset in tx status hotpath
Date: Fri, 28 Jun 2019 12:11:27 +0200	[thread overview]
Message-ID: <20190628101127.6044-2-john@phrozen.org> (raw)
In-Reply-To: <20190628101127.6044-1-john@phrozen.org>

This in a small but measurable performance increase.

Signed-off-by: John Crispin <john@phrozen.org>
---
 drivers/net/wireless/ath/ath11k/dp_tx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c
index b3d5995fc657..8c5db3c88a87 100644
--- a/drivers/net/wireless/ath/ath11k/dp_tx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_tx.c
@@ -448,7 +448,6 @@ void ath11k_dp_tx_completion_handler(struct ath11k_base *ab, int ring_id)
 	int hal_ring_id = dp->tx_ring[ring_id].tcl_comp_ring.ring_id;
 	struct hal_srng *status_ring = &ab->hal.srng_list[hal_ring_id];
 	struct sk_buff *msdu;
-	struct hal_tx_status ts;
 	struct dp_tx_ring *tx_ring = &dp->tx_ring[ring_id];
 	u32 msdu_id;
 	u32 *desc;
@@ -459,7 +458,8 @@ void ath11k_dp_tx_completion_handler(struct ath11k_base *ab, int ring_id)
 	ath11k_hal_srng_access_begin(ab, status_ring);
 
 	while ((desc = ath11k_hal_srng_dst_get_next_entry(ab, status_ring))) {
-		memset(&ts, 0, sizeof(ts));
+		struct hal_tx_status ts = { 0 };
+
 		ath11k_hal_tx_status_parse(ab,
 					   (struct hal_wbm_release_ring *)desc,
 					   &ts);
-- 
2.20.1


_______________________________________________
ath11k mailing list
ath11k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath11k

  reply	other threads:[~2019-06-28 10:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 10:11 [RFC 1/2] ath11k: drop tx_status_fifo John Crispin
2019-06-28 10:11 ` John Crispin [this message]
2019-06-28 11:21   ` [RFC 2/2] ath11k: drop memset in tx status hotpath Kalle Valo
2019-06-28 11:07 ` [RFC 1/2] ath11k: drop tx_status_fifo Vasanthakumar Thiagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628101127.6044-2-john@phrozen.org \
    --to=john@phrozen.org \
    --cc=ath11k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=rmanohar@qti.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.