From: "Theodore Ts'o" <tytso@mit.edu>
To: Eryu Guan <guaneryu@gmail.com>
Cc: fstests@vger.kernel.org
Subject: Re: [PATCH 1/5] shared,ext4: move ext4-specific tests out of shared/
Date: Fri, 28 Jun 2019 10:35:36 -0400 [thread overview]
Message-ID: <20190628143536.GD6181@mit.edu> (raw)
In-Reply-To: <20190628094030.GD7943@desktop>
On Fri, Jun 28, 2019 at 05:40:30PM +0800, Eryu Guan wrote:
> >
> > shared/001 --> ext4/036
> > shared/003 --> ext4/037
> > shared/004 --> ext4/038
> > shared/272 --> ext4/039
>
> Looks like shared/001 and shared/004 are not journal related and could
> run with ext2 as well. So the two tests should be part of patch 3?
Orphaned inodes is something which is only a thing with ext3/ext4.
The fact that these tests pass on ext2 is purely a happy accident ---
because ext2 completely ignores the orphaned list. I suppose I should
just remove ext2 from the supported list, but these tests take a super
small amount of time so why the tests are kinda pointless for ext2, it
doesn't cost much time, either.
> And I guess we should update "_supported_fs" field in ext4/037 and
> ext4/039 too, so they only support ext4.
ext4/037 should have be marked as only supported by ext3 and ext4.
It's passing by accident on my system because I have
CONFIG_EXT4_USE_FOR_EXT2, and so the lack of the noload mount option
wasn't tripping up the test and causing a test failure. (The fact
that no one has complained is actually a really strong suggestion that
most people running xfstests have EXT4_USE_FOR_EXT2 enabled.) I'll fix this.
ext4/039 is right as is; it makes sense for ext3 and ext4, and if
someone is testing with FSTYP=ext3 we do want to run that test.
I'll adjust some of the supported_fs lines in the next version.
- Ted
prev parent reply other threads:[~2019-06-28 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 23:09 [PATCH 1/5] shared,ext4: move ext4-specific tests out of shared/ Theodore Ts'o
2019-06-23 23:09 ` [PATCH 2/5] check: add ext4 group list when testing ext2 and ext3 Theodore Ts'o
2019-06-23 23:09 ` [PATCH 3/5] shared,ext4: move ext[234]-specific tests out of shared/ Theodore Ts'o
2019-06-23 23:09 ` [PATCH 4/5] shared,generic: move shared/006 to generic/ Theodore Ts'o
2019-06-28 9:47 ` Eryu Guan
2019-06-23 23:09 ` [PATCH 5/5] shared,generic: move tests using duperemove " Theodore Ts'o
2019-06-24 1:27 ` Theodore Ts'o
2019-06-28 9:40 ` [PATCH 1/5] shared,ext4: move ext4-specific tests out of shared/ Eryu Guan
2019-06-28 14:35 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628143536.GD6181@mit.edu \
--to=tytso@mit.edu \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.