From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Enrico Weigelt <info@metux.net>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Andrew Morton <akpm@linux-foundation.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] devres: allow const resource arguments
Date: Fri, 28 Jun 2019 17:12:26 +0200 [thread overview]
Message-ID: <20190628151226.GA14736@kroah.com> (raw)
In-Reply-To: <20190628150049.1108048-1-arnd@arndb.de>
On Fri, Jun 28, 2019 at 04:59:45PM +0200, Arnd Bergmann wrote:
> devm_ioremap_resource() does not currently take 'const' arguments,
> which results in a warning from the first driver trying to do it
> anyway:
>
> drivers/gpio/gpio-amd-fch.c: In function 'amd_fch_gpio_probe':
> drivers/gpio/gpio-amd-fch.c:171:49: error: passing argument 2 of 'devm_ioremap_resource' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> priv->base = devm_ioremap_resource(&pdev->dev, &amd_fch_gpio_iores);
> ^~~~~~~~~~~~~~~~~~~
>
> Change the prototype to allow it, as there is no real reason not to.
>
> Fixes: 9bb2e0452508 ("gpio: amd: Make resource struct const")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> The warning is currently in Linus Walleij's gpio tree, so I would
> suggest he can queue up this fix as well, if Greg (or whoever
> feels responsible for devres) agrees.
That's fine with me if Linus takes it:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2019-06-28 15:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 14:59 [PATCH] devres: allow const resource arguments Arnd Bergmann
2019-06-28 15:12 ` Greg Kroah-Hartman [this message]
2019-07-02 20:26 ` Enrico Weigelt, metux IT consult
2019-07-03 8:09 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628151226.GA14736@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=akpm@linux-foundation.org \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=heikki.krogerus@linux.intel.com \
--cc=info@metux.net \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.