From: Eric Biggers <ebiggers@kernel.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Arnd Bergmann <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [v2] crypto: serpent - mark __serpent_setkey_sbox noinline
Date: Fri, 28 Jun 2019 10:04:38 -0700 [thread overview]
Message-ID: <20190628170437.GA103946@gmail.com> (raw)
In-Reply-To: <20190628041912.qprczc23gzeelag7@gondor.apana.org.au>
On Fri, Jun 28, 2019 at 12:19:12PM +0800, Herbert Xu wrote:
> On Tue, Jun 18, 2019 at 01:19:42PM +0200, Arnd Bergmann wrote:
> > The same bug that gcc hit in the past is apparently now showing
> > up with clang, which decides to inline __serpent_setkey_sbox:
> >
> > crypto/serpent_generic.c:268:5: error: stack frame size of 2112 bytes in function '__serpent_setkey' [-Werror,-Wframe-larger-than=]
> >
> > Marking it 'noinline' reduces the stack usage from 2112 bytes to
> > 192 and 96 bytes, respectively, and seems to generate more
> > useful object code.
> >
> > Fixes: c871c10e4ea7 ("crypto: serpent - improve __serpent_setkey with UBSAN")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> > v2: style improvements suggested by Eric Biggers
> > ---
> > crypto/serpent_generic.c | 8 +++++++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
>
> Patch applied. Thanks.
> --
Hi Herbert, seems you forgot to push? I don't see this in cryptodev.
- Eric
next prev parent reply other threads:[~2019-06-28 17:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 11:19 [PATCH] [v2] crypto: serpent - mark __serpent_setkey_sbox noinline Arnd Bergmann
2019-06-18 18:05 ` Eric Biggers
2019-06-28 4:19 ` Herbert Xu
2019-06-28 17:04 ` Eric Biggers [this message]
2019-06-29 1:15 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628170437.GA103946@gmail.com \
--to=ebiggers@kernel.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.