From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39795C4321A for ; Fri, 28 Jun 2019 19:35:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 04367208E3 for ; Fri, 28 Jun 2019 19:35:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561750558; bh=+f+wmqDt7OEzXd5WamzVHMgvUtZ43luLwvAdtczdRY8=; h=In-Reply-To:References:To:From:Subject:Cc:Date:List-ID:From; b=0T5huO/3R+mT+R7y7P4zyhRUnsWbkHO/JVE8S1FcaFVAdlChBV58qxVPWU7QsOnsd 1fnoHm1p1c9jJW1ORiacp6e+r9jxKT/g7oRFK9o7zjutmPPkI5T4Tckh5s8RvGEoeY /E/GqP223+06E6429TdIW1n6xRADw77qoftkeNtw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726859AbfF1Tf5 (ORCPT ); Fri, 28 Jun 2019 15:35:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:49864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726819AbfF1Tf5 (ORCPT ); Fri, 28 Jun 2019 15:35:57 -0400 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC814208CB; Fri, 28 Jun 2019 19:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561750556; bh=+f+wmqDt7OEzXd5WamzVHMgvUtZ43luLwvAdtczdRY8=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=iL0s/4YikWl3EPOokIoNf34p44svd7uNFw7JGPiX49tbjgIyR+hhfFRDMJD79BseK IjOkipIq8Ufc42HhIIhhkJJEa2xB33lie/9hOGBvjYIMjm+9o7X+6UpOsHrdwWf+Xo PFlh/nhPESvbgA5Opxw9Chj+brSaFXlWd4dx1w30= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <0c12208398cadb7450b6b7745e99c55770c0ccf8.1561709827.git.leonard.crestez@nxp.com> To: Geert Uytterhoeven , Leonard Crestez From: Stephen Boyd Subject: Re: [PATCH v2] clk: Add clk_min/max_rate entries in debugfs Cc: Geert Uytterhoeven , Michael Turquette , linux-clk , Linux ARM User-Agent: alot/0.8.1 Date: Fri, 28 Jun 2019 12:35:55 -0700 Message-Id: <20190628193556.BC814208CB@mail.kernel.org> Sender: linux-clk-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org Quoting Geert Uytterhoeven (2019-06-28 04:58:27) > On Fri, Jun 28, 2019 at 10:19 AM Leonard Crestez >=20 > > --- a/drivers/clk/clk.c > > +++ b/drivers/clk/clk.c > > @@ -591,10 +591,12 @@ static void clk_core_get_boundaries(struct clk_co= re *core, > > unsigned long *min_rate, > > unsigned long *max_rate) > > { > > struct clk *clk_user; > > > > + lockdep_assert_held(&prepare_lock); > > + >=20 > I guess the clock maintainers want to see the addition of this check > spun off into a separate patch.... Yes. I'm not sure we should have the assertion in there. I seem to recall that we thought it might not always be necessary to have the lock, but maybe that was wrong. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51987C4321A for ; Fri, 28 Jun 2019 19:36:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1541A214AF for ; Fri, 28 Jun 2019 19:36:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ItKXFRLt"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="iL0s/4Yi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1541A214AF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:From:To: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mRTcKx5uFwtGfm7M1LyEq1M9p9aHIpOpMZiekvWQv8A=; b=ItKXFRLtdxVHdo C9absBl+BQhpRtXEM/eI/ibX+3qPVmtQVcyEXcgzFfvnR1O/RkG1oz0yhHMRmJJuB6kREUy2Jh+22 ++FoGqFl8XBe17NCzxOowzxN/9ICo+yf44wLZtvvBPhAWy0XkMPaz1qrh7JnGYQFgfr89o03cangn 5NsdzNHFCZIgV/nL1OFCWWEoLoaY2+LnuQHmZ319e4uAWPfoUDiAAI0sZPz31Cqp8bRSjy7pTa4cZ c7wcASglIPeqTH77BFY9nnOTLeJn1lWwoex7VK3hT0n/wAIKa2qQGR5eZ+xSAzZQHK0rADCMtS154 gu5XICJhgz5SOi3GqcaA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgwfC-00024I-7v; Fri, 28 Jun 2019 19:36:02 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgwf8-00023U-2n for linux-arm-kernel@lists.infradead.org; Fri, 28 Jun 2019 19:36:00 +0000 Received: from kernel.org (unknown [104.132.0.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id BC814208CB; Fri, 28 Jun 2019 19:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561750556; bh=+f+wmqDt7OEzXd5WamzVHMgvUtZ43luLwvAdtczdRY8=; h=In-Reply-To:References:To:From:Subject:Cc:Date:From; b=iL0s/4YikWl3EPOokIoNf34p44svd7uNFw7JGPiX49tbjgIyR+hhfFRDMJD79BseK IjOkipIq8Ufc42HhIIhhkJJEa2xB33lie/9hOGBvjYIMjm+9o7X+6UpOsHrdwWf+Xo PFlh/nhPESvbgA5Opxw9Chj+brSaFXlWd4dx1w30= MIME-Version: 1.0 In-Reply-To: References: <0c12208398cadb7450b6b7745e99c55770c0ccf8.1561709827.git.leonard.crestez@nxp.com> To: Geert Uytterhoeven , Leonard Crestez From: Stephen Boyd Subject: Re: [PATCH v2] clk: Add clk_min/max_rate entries in debugfs User-Agent: alot/0.8.1 Date: Fri, 28 Jun 2019 12:35:55 -0700 Message-Id: <20190628193556.BC814208CB@mail.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190628_123558_139055_789E285B X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux ARM , Michael Turquette , linux-clk , Geert Uytterhoeven Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Geert Uytterhoeven (2019-06-28 04:58:27) > On Fri, Jun 28, 2019 at 10:19 AM Leonard Crestez > > > --- a/drivers/clk/clk.c > > +++ b/drivers/clk/clk.c > > @@ -591,10 +591,12 @@ static void clk_core_get_boundaries(struct clk_core *core, > > unsigned long *min_rate, > > unsigned long *max_rate) > > { > > struct clk *clk_user; > > > > + lockdep_assert_held(&prepare_lock); > > + > > I guess the clock maintainers want to see the addition of this check > spun off into a separate patch.... Yes. I'm not sure we should have the assertion in there. I seem to recall that we thought it might not always be necessary to have the lock, but maybe that was wrong. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel