From: Eduardo Habkost <ehabkost@redhat.com>
To: Sergio Lopez <slp@redhat.com>
Cc: pbonzini@redhat.com, rth@twiddle.net, qemu-devel@nongnu.org,
mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH 1/4] hw/i386: Factorize CPU routine
Date: Fri, 28 Jun 2019 17:03:28 -0300 [thread overview]
Message-ID: <20190628200328.GI1862@habkost.net> (raw)
In-Reply-To: <20190628115349.60293-2-slp@redhat.com>
On Fri, Jun 28, 2019 at 01:53:46PM +0200, Sergio Lopez wrote:
[...]
> /* Enables contiguous-apic-ID mode, for compatibility */
> -static bool compat_apic_id_mode;
> +bool compat_apic_id_mode;
We can get rid of this global variable, see the patch I have just
sent:
[PATCH] pc: Move compat_apic_id_mode variable to PCMachineClass
--
Eduardo
next prev parent reply other threads:[~2019-06-28 20:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 11:53 [Qemu-devel] [PATCH 0/4] Introduce the microvm machine type Sergio Lopez
2019-06-28 11:53 ` [Qemu-devel] [PATCH 1/4] hw/i386: Factorize CPU routine Sergio Lopez
2019-06-28 20:03 ` Eduardo Habkost [this message]
2019-06-28 21:44 ` Sergio Lopez
2019-07-01 9:25 ` Michael S. Tsirkin
2019-06-28 11:53 ` [Qemu-devel] [PATCH 2/4] hw/virtio: Factorize virtio-mmio headers Sergio Lopez
2019-06-28 14:03 ` Michael S. Tsirkin
2019-06-28 20:50 ` Sergio Lopez
2019-06-30 21:36 ` Michael S. Tsirkin
2019-07-02 8:19 ` Gerd Hoffmann
2019-07-02 13:22 ` Michael S. Tsirkin
2019-06-28 11:53 ` [Qemu-devel] [PATCH 3/4] hw/i386: Add an Intel MPTable generator Sergio Lopez
2019-06-28 11:53 ` [Qemu-devel] [PATCH 4/4] hw/i386: Introduce the microvm machine type Sergio Lopez
2019-06-28 14:06 ` Michael S. Tsirkin
2019-06-28 20:56 ` Sergio Lopez
2019-06-28 22:17 ` Paolo Bonzini
2019-06-30 21:37 ` Michael S. Tsirkin
2019-06-28 19:15 ` Maran Wilson
2019-06-28 21:05 ` Sergio Lopez
2019-06-28 21:54 ` Maran Wilson
2019-06-28 22:23 ` Sergio Lopez
2019-06-28 21:56 ` Paolo Bonzini
2019-06-28 19:47 ` Eduardo Habkost
2019-06-28 21:42 ` Sergio Lopez
2019-06-28 21:57 ` Paolo Bonzini
2019-06-28 13:21 ` [Qemu-devel] [PATCH 0/4] " Paolo Bonzini
2019-06-28 20:49 ` Sergio Lopez
2019-06-28 16:32 ` no-reply
2019-06-28 18:16 ` no-reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628200328.GI1862@habkost.net \
--to=ehabkost@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=slp@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.