From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from userp2130.oracle.com ([156.151.31.86]:37862 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbfF1WTZ (ORCPT ); Fri, 28 Jun 2019 18:19:25 -0400 Date: Fri, 28 Jun 2019 15:19:14 -0700 From: "Darrick J. Wong" Subject: Re: [PATCH] xfs: fix iclog allocation size Message-ID: <20190628221914.GD1404256@magnolia> References: <20190627143950.19558-1-hch@lst.de> <20190628220253.GF30113@42.do-not-panic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190628220253.GF30113@42.do-not-panic.com> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Luis Chamberlain Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, syzbot+b75afdbe271a0d7ac4f6@syzkaller.appspotmail.com On Fri, Jun 28, 2019 at 10:02:53PM +0000, Luis Chamberlain wrote: > On Thu, Jun 27, 2019 at 04:39:50PM +0200, Christoph Hellwig wrote: > > Properly allocate the space for the bio_vecs instead of just one byte > > per bio_vec. > > > > Fixes: 991fc1d2e65e ("xfs: use bios directly to write log buffers") > > I cannot find 991fc1d2e65e on Linus' tree, nor can I find the subject > name patch on Linus' tree. I'm probably missing some context here? This patch fixes a bug in for-next. :) --D > > Reported-by: syzbot+b75afdbe271a0d7ac4f6@syzkaller.appspotmail.com > > Signed-off-by: Christoph Hellwig > > --- > > fs/xfs/xfs_log.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c > > index 0f849b4095d6..e230f3c18ceb 100644 > > --- a/fs/xfs/xfs_log.c > > +++ b/fs/xfs/xfs_log.c > > @@ -1415,7 +1415,8 @@ xlog_alloc_log( > > */ > > ASSERT(log->l_iclog_size >= 4096); > > for (i = 0; i < log->l_iclog_bufs; i++) { > > - size_t bvec_size = howmany(log->l_iclog_size, PAGE_SIZE); > > + size_t bvec_size = howmany(log->l_iclog_size, PAGE_SIZE) * > > + sizeof(struct bio_vec); > > > > iclog = kmem_zalloc(sizeof(*iclog) + bvec_size, KM_MAYFAIL); > > if (!iclog) > > -- > > 2.20.1 > >