From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f196.google.com ([209.85.215.196]:38060 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726563AbfF1WcD (ORCPT ); Fri, 28 Jun 2019 18:32:03 -0400 Received: by mail-pg1-f196.google.com with SMTP id z75so3195895pgz.5 for ; Fri, 28 Jun 2019 15:32:03 -0700 (PDT) Date: Fri, 28 Jun 2019 22:32:00 +0000 From: Luis Chamberlain Subject: Re: [PATCH] xfs: fix iclog allocation size Message-ID: <20190628223200.GO19023@42.do-not-panic.com> References: <20190627143950.19558-1-hch@lst.de> <20190628220253.GF30113@42.do-not-panic.com> <20190628221914.GD1404256@magnolia> <20190628222310.GL19023@42.do-not-panic.com> <20190628222548.GE1404256@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190628222548.GE1404256@magnolia> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, syzbot+b75afdbe271a0d7ac4f6@syzkaller.appspotmail.com On Fri, Jun 28, 2019 at 03:25:48PM -0700, Darrick J. Wong wrote: > On Fri, Jun 28, 2019 at 10:23:10PM +0000, Luis Chamberlain wrote: > > On Fri, Jun 28, 2019 at 03:19:14PM -0700, Darrick J. Wong wrote: > > > On Fri, Jun 28, 2019 at 10:02:53PM +0000, Luis Chamberlain wrote: > > > > On Thu, Jun 27, 2019 at 04:39:50PM +0200, Christoph Hellwig wrote: > > > > > Properly allocate the space for the bio_vecs instead of just one byte > > > > > per bio_vec. > > > > > > > > > > Fixes: 991fc1d2e65e ("xfs: use bios directly to write log buffers") > > > > > > > > I cannot find 991fc1d2e65e on Linus' tree, nor can I find the subject > > > > name patch on Linus' tree. I'm probably missing some context here? > > > > > > This patch fixes a bug in for-next. :) > > > > I figured as much but the commit in question is not even on linux-next > > for today, so I take it that line would be removed from the commit log? > > It looks like it is to me... > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20190628&id=991fc1d2e65e381fe8db9038d9a139d45c948f4f Yes but commits on linux-next make no sense for Linus' tree, as they change day to day, is my point. So if merged eventually as-is on Linus' tree, someone looking at the git history would not find 991fc1d2e65e, and could also throw errors on scripts which scrape for these tags. Yes, they exist, and distros do use them to evaluate possible fixes. In this case I think just referring to the subject would do it. Unless it just so happens to be that what is on for-next *does* always maintain the same commit IDs one it goes to Linus' tree? Does that actually happen? Luis