All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
Cc: stable@vger.kernel.org, Gen Zhang <blackgod016574@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	akaher@vmware.com, srinidhir@vmware.com, bvikas@vmware.com,
	amakhalov@vmware.com, srivatsab@vmware.com
Subject: Re: [4.19.y PATCH 2/3] ip_sockglue: Fix missing-check bug in ip_ra_control()
Date: Sat, 29 Jun 2019 08:58:09 +0200	[thread overview]
Message-ID: <20190629065809.GB365@kroah.com> (raw)
In-Reply-To: <156174734089.34985.7694357051190385114.stgit@srivatsa-ubuntu>

On Fri, Jun 28, 2019 at 11:42:30AM -0700, Srivatsa S. Bhat wrote:
> From: Gen Zhang <blackgod016574@gmail.com>
> 
> commit 425aa0e1d01513437668fa3d4a971168bbaa8515 upstream.
> 
> In function ip_ra_control(), the pointer new_ra is allocated a memory
> space via kmalloc(). And it is used in the following codes. However,
> when  there is a memory allocation error, kmalloc() fails. Thus null
> pointer dereference may happen. And it will cause the kernel to crash.
> Therefore, we should check the return value and handle the error.
> 
> Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
> Signed-off-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
> ---
> 
>  net/ipv4/ip_sockglue.c |    2 ++
>  1 file changed, 2 insertions(+)

Unless you can actually trigger these kmalloc failures, I do not want to
take these patches as they are not worth it at all.

thanks,

greg k-h

  reply	other threads:[~2019-06-29  6:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 18:41 [4.19.y PATCH 0/3] Backported fixes for 4.19 stable tree Srivatsa S. Bhat
2019-06-28 18:42 ` [4.19.y PATCH 1/3] efi/x86/Add missing error handling to old_memmap 1:1 mapping code Srivatsa S. Bhat
2019-06-29  6:57   ` Greg KH
2019-06-29  8:47     ` Ard Biesheuvel
2019-06-29  8:57       ` Gen Zhang
2019-06-29  9:10       ` Greg KH
2019-06-29 21:11         ` Ard Biesheuvel
2019-06-29 21:49           ` Srivatsa S. Bhat
2019-06-28 18:42 ` [4.19.y PATCH 2/3] ip_sockglue: Fix missing-check bug in ip_ra_control() Srivatsa S. Bhat
2019-06-29  6:58   ` Greg KH [this message]
2019-06-28 18:42 ` [4.19.y PATCH 3/3] ipv6_sockglue: Fix a missing-check bug in ip6_ra_control() Srivatsa S. Bhat
2019-06-28 20:44 ` [4.19.y PATCH 0/3] Backported fixes for 4.19 stable tree Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190629065809.GB365@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=akaher@vmware.com \
    --cc=amakhalov@vmware.com \
    --cc=blackgod016574@gmail.com \
    --cc=bvikas@vmware.com \
    --cc=davem@davemloft.net \
    --cc=srinidhir@vmware.com \
    --cc=srivatsa@csail.mit.edu \
    --cc=srivatsab@vmware.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.