From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Cc: netdev@vger.kernel.org, jaswinder.singh@linaro.org,
ard.biesheuvel@linaro.org, bjorn.topel@intel.com,
magnus.karlsson@intel.com, daniel@iogearbox.net, ast@kernel.org,
makita.toshiaki@lab.ntt.co.jp, jakub.kicinski@netronome.com,
john.fastabend@gmail.com, davem@davemloft.net,
maciejromanfijalkowski@gmail.com, brouer@redhat.com
Subject: Re: [net-next, PATCH 3/3, v2] net: netsec: add XDP support
Date: Sat, 29 Jun 2019 12:36:30 +0200 [thread overview]
Message-ID: <20190629123630.58fc82b1@carbon> (raw)
In-Reply-To: <1561785805-21647-4-git-send-email-ilias.apalodimas@linaro.org>
On Sat, 29 Jun 2019 08:23:25 +0300
Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote:
> The interface only supports 1 Tx queue so locking is introduced on
> the Tx queue if XDP is enabled to make sure .ndo_start_xmit and
> .ndo_xdp_xmit won't corrupt Tx ring
>
> - Performance (SMMU off)
>
> Benchmark XDP_SKB XDP_DRV
> xdp1 291kpps 344kpps
> rxdrop 282kpps 342kpps
>
> - Performance (SMMU on)
> Benchmark XDP_SKB XDP_DRV
> xdp1 167kpps 324kpps
> rxdrop 164kpps 323kpps
>
> Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
This version looks okay to me. I don't have the hardware, so I've not
tested it...
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-06-29 10:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 5:23 [PATCH 0/3, net-next, v2] net: netsec: Add XDP Support Ilias Apalodimas
2019-06-29 5:23 ` [net-next, PATCH 1/3, v2] net: netsec: Use page_pool API Ilias Apalodimas
2019-06-29 5:23 ` [net-next, PATCH 2/3, v2] net: page_pool: add helper function for retrieving dma direction Ilias Apalodimas
2019-06-29 5:23 ` [net-next, PATCH 3/3, v2] net: netsec: add XDP support Ilias Apalodimas
2019-06-29 10:36 ` Jesper Dangaard Brouer [this message]
2019-06-30 16:20 ` Ivan Khoronzhuk
2019-06-30 16:34 ` Ilias Apalodimas
2019-06-30 16:45 ` Ivan Khoronzhuk
2019-06-30 16:50 ` Ilias Apalodimas
2019-06-30 16:25 ` Ivan Khoronzhuk
2019-06-30 16:32 ` Ilias Apalodimas
2019-06-30 16:41 ` Ivan Khoronzhuk
2019-06-30 16:47 ` Ilias Apalodimas
2019-06-30 16:51 ` Ivan Khoronzhuk
2019-06-30 17:09 ` Ivan Khoronzhuk
2019-07-02 2:27 ` [PATCH 0/3, net-next, v2] net: netsec: Add XDP Support David Miller
2019-07-02 3:18 ` Ilias Apalodimas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629123630.58fc82b1@carbon \
--to=brouer@redhat.com \
--cc=ard.biesheuvel@linaro.org \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=ilias.apalodimas@linaro.org \
--cc=jakub.kicinski@netronome.com \
--cc=jaswinder.singh@linaro.org \
--cc=john.fastabend@gmail.com \
--cc=maciejromanfijalkowski@gmail.com \
--cc=magnus.karlsson@intel.com \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.