From: Sasha Levin <sashal@kernel.org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: peterhuewe@gmx.de, jgg@ziepe.ca, corbet@lwn.net,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-kernel@microsoft.com,
thiruan@microsoft.com, bryankel@microsoft.com,
tee-dev@lists.linaro.org, ilias.apalodimas@linaro.org,
sumit.garg@linaro.org, rdunlap@infradead.org
Subject: Re: [PATCH v7 1/2] fTPM: firmware TPM running in TEE
Date: Sat, 29 Jun 2019 11:01:45 -0400 [thread overview]
Message-ID: <20190629150145.GL11506@sasha-vm> (raw)
In-Reply-To: <673dd30d03e8ed9825bb46ef21b2efef015f6f2a.camel@linux.intel.com>
On Thu, Jun 27, 2019 at 02:31:35AM +0300, Jarkko Sakkinen wrote:
>On Tue, 2019-06-25 at 16:13 -0400, Sasha Levin wrote:
>> +static const uuid_t ftpm_ta_uuid =
>> + UUID_INIT(0xBC50D971, 0xD4C9, 0x42C4,
>> + 0x82, 0xCB, 0x34, 0x3F, 0xB7, 0xF3, 0x78, 0x96);
>> +
>> +/**
>> + * ftpm_tee_tpm_op_recv - retrieve fTPM response.
>> + *
>
>Should not have an empty line here.
>
>> + * @chip: the tpm_chip description as specified in driver/char/tpm/tpm.h.
>> + * @buf: the buffer to store data.
>> + * @count: the number of bytes to read.
Jarkko, w.r.t your comment above, there is an empty line between the
function name and variables in drivers/char/tpm, and in particular
tpm_crb.c which you authored and I used as reference. Do you want us to
diverge here?
--
Thanks,
Sasha
next prev parent reply other threads:[~2019-06-29 15:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-25 20:13 [PATCH v7 0/2] fTPM: firmware TPM running in TEE Sasha Levin
2019-06-25 20:13 ` [PATCH v7 1/2] " Sasha Levin
2019-06-26 23:31 ` Jarkko Sakkinen
2019-06-26 23:56 ` Sasha Levin
2019-06-27 13:17 ` Jarkko Sakkinen
2019-06-27 13:19 ` Jarkko Sakkinen
2019-06-27 13:30 ` Ilias Apalodimas
2019-06-27 16:32 ` Jarkko Sakkinen
2019-07-02 14:21 ` Ilias Apalodimas
2019-07-02 16:54 ` Thirupathaiah Annapureddy
2019-07-03 6:58 ` Ilias Apalodimas
2019-07-03 8:12 ` Ilias Apalodimas
2019-07-03 10:03 ` Sumit Garg
2019-07-03 14:16 ` Joakim Bech
2019-07-04 6:28 ` Thirupathaiah Annapureddy
2019-07-04 18:11 ` Ilias Apalodimas
2019-07-05 2:40 ` Thirupathaiah Annapureddy
2019-07-10 12:13 ` Ilias Apalodimas
2019-06-28 5:50 ` Sumit Garg
2019-06-29 15:01 ` Sasha Levin [this message]
2019-07-04 9:20 ` Jarkko Sakkinen
2019-06-25 20:13 ` [PATCH v7 2/2] fTPM: add documentation for ftpm driver Sasha Levin
2019-06-25 23:13 ` Randy Dunlap
2019-06-26 23:34 ` Jarkko Sakkinen
2019-06-26 23:59 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190629150145.GL11506@sasha-vm \
--to=sashal@kernel.org \
--cc=bryankel@microsoft.com \
--cc=corbet@lwn.net \
--cc=ilias.apalodimas@linaro.org \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@microsoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=rdunlap@infradead.org \
--cc=sumit.garg@linaro.org \
--cc=tee-dev@lists.linaro.org \
--cc=thiruan@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.