From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sat, 29 Jun 2019 11:59:26 -0700 From: Bjorn Andersson Subject: Re: [PATCH] remoteproc: recopy parent dma_pfn_offset for vdev Message-ID: <20190629185926.GD23094@builder> References: <20190612095521.4703-1-cleger@kalray.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190612095521.4703-1-cleger@kalray.eu> To: Clement Leger Cc: Ohad Ben-Cohen , linux-remoteproc List-ID: On Wed 12 Jun 02:55 PDT 2019, Clement Leger wrote: > When preparing the subdevice for the vdev, also copy dma_pfn_offset > since this is used for sub device dma allocations. Without that, there > is incoherency between the parent dma settings and the childs one, > potentially leading to dma_alloc_coherent failure (due to phys_to_dma > using dma_pfn_offset for translation). Hi Clement, This looks reasonable, but I can't merge it without your Signed-off-by. Can you please resubmit the change, with the Fixes: and Loic's ack? Regards, Bjorn > --- > drivers/remoteproc/remoteproc_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 263e9c9614a8..3b56ca043231 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -520,6 +520,7 @@ static int rproc_handle_vdev(struct rproc *rproc, struct fw_rsc_vdev *rsc, > /* Initialise vdev subdevice */ > snprintf(name, sizeof(name), "vdev%dbuffer", rvdev->index); > rvdev->dev.parent = rproc->dev.parent; > + rvdev->dev.dma_pfn_offset = rproc->dev.parent->dma_pfn_offset; > rvdev->dev.release = rproc_rvdev_release; > dev_set_name(&rvdev->dev, "%s#%s", dev_name(rvdev->dev.parent), name); > dev_set_drvdata(&rvdev->dev, rvdev); > -- > 2.15.0.276.g89ea799 >