From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 1/3] DRM: ingenic: Use devm_platform_ioremap_resource Date: Sun, 30 Jun 2019 10:18:33 +0200 Message-ID: <20190630081833.GC5081@ravnborg.org> References: <20190627182114.27299-1-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 26814899BB for ; Sun, 30 Jun 2019 08:18:37 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190627182114.27299-1-paul@crapouillou.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Cercueil Cc: David Airlie , dri-devel@lists.freedesktop.org, od@zcrc.me, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgUGF1bC4KCk9uIFRodSwgSnVuIDI3LCAyMDE5IGF0IDA4OjIxOjEyUE0gKzAyMDAsIFBhdWwg Q2VyY3VlaWwgd3JvdGU6Cj4gU2ltcGxpZnkgYSBiaXQgdGhlIHByb2JlIGZ1bmN0aW9uIGJ5IHVz aW5nIHRoZSBuZXdseSBpbnRyb2R1Y2VkCj4gZGV2bV9wbGF0Zm9ybV9pb3JlbWFwX3Jlc291cmNl KCksIGluc3RlYWQgb2YgaGF2aW5nIHRvIGNhbGwKPiBwbGF0Zm9ybV9nZXRfcmVzb3VyY2UoKSBm b2xsb3dlZCBieSBkZXZtX2lvcmVtYXBfcmVzb3VyY2UoKS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBQ YXVsIENlcmN1ZWlsIDxwYXVsQGNyYXBvdWlsbG91Lm5ldD4KPiAtLS0KPiAgZHJpdmVycy9ncHUv ZHJtL2luZ2VuaWMvaW5nZW5pYy1kcm0uYyB8IDQgKy0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMSBp bnNlcnRpb24oKyksIDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pbmdlbmljL2luZ2VuaWMtZHJtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaW5nZW5pYy9pbmdl bmljLWRybS5jCj4gaW5kZXggYTA2OTU3OWNhNzQ5Li4wMmM0Nzg4ZWYxYzcgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2luZ2VuaWMvaW5nZW5pYy1kcm0uYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pbmdlbmljL2luZ2VuaWMtZHJtLmMKPiBAQCAtNTgwLDcgKzU4MCw2IEBAIHN0YXRp YyBpbnQgaW5nZW5pY19kcm1fcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKPiAg CXN0cnVjdCBkcm1fYnJpZGdlICpicmlkZ2U7Cj4gIAlzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbDsK PiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkcm07Cj4gLQlzdHJ1Y3QgcmVzb3VyY2UgKm1lbTsKPiAg CXZvaWQgX19pb21lbSAqYmFzZTsKPiAgCWxvbmcgcGFyZW50X3JhdGU7Cj4gIAlpbnQgcmV0LCBp cnE7Cj4gQEAgLTYxNCw4ICs2MTMsNyBAQCBzdGF0aWMgaW50IGluZ2VuaWNfZHJtX3Byb2JlKHN0 cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIAlkcm0tPm1vZGVfY29uZmlnLm1heF9oZWln aHQgPSA2MDA7Cj4gIAlkcm0tPm1vZGVfY29uZmlnLmZ1bmNzID0gJmluZ2VuaWNfZHJtX21vZGVf Y29uZmlnX2Z1bmNzOwo+ICAKPiAtCW1lbSA9IHBsYXRmb3JtX2dldF9yZXNvdXJjZShwZGV2LCBJ T1JFU09VUkNFX01FTSwgMCk7Cj4gLQliYXNlID0gZGV2bV9pb3JlbWFwX3Jlc291cmNlKGRldiwg bWVtKTsKPiArCWJhc2UgPSBkZXZtX3BsYXRmb3JtX2lvcmVtYXBfcmVzb3VyY2UocGRldiwgMCk7 Cj4gIAlpZiAoSVNfRVJSKGJhc2UpKSB7Cj4gIAkJZGV2X2VycihkZXYsICJGYWlsZWQgdG8gZ2V0 IG1lbW9yeSByZXNvdXJjZSIpOwpDb25zaWRlciB0byBpbmNsdWRlIHRoZSBlcnJvciBjb2RlIGlu IHRoZSBlcnJvciBtZXNzYWdlIGhlcmUuCj4gIAkJcmV0dXJuIFBUUl9FUlIoYmFzZSk7CgpXaXRo IHRoZSBhYm92ZSBmaXhlZC9jb25zaWRlcmVkOgpSZXZpZXdlZC1ieTogU2FtIFJhdm5ib3JnIDxz YW1AcmF2bmJvcmcub3JnPgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWw= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 897CFC5B57E for ; Sun, 30 Jun 2019 08:19:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 595F32089C for ; Sun, 30 Jun 2019 08:19:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbfF3ISi (ORCPT ); Sun, 30 Jun 2019 04:18:38 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:38632 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbfF3ISi (ORCPT ); Sun, 30 Jun 2019 04:18:38 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 8F5C220065; Sun, 30 Jun 2019 10:18:34 +0200 (CEST) Date: Sun, 30 Jun 2019 10:18:33 +0200 From: Sam Ravnborg To: Paul Cercueil Cc: David Airlie , Daniel Vetter , od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/3] DRM: ingenic: Use devm_platform_ioremap_resource Message-ID: <20190630081833.GC5081@ravnborg.org> References: <20190627182114.27299-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190627182114.27299-1-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=7gkXJVJtAAAA:8 a=aVMsacSFOT9BCqWdKMAA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=E9Po1WZjFZOl8hwRPBS3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul. On Thu, Jun 27, 2019 at 08:21:12PM +0200, Paul Cercueil wrote: > Simplify a bit the probe function by using the newly introduced > devm_platform_ioremap_resource(), instead of having to call > platform_get_resource() followed by devm_ioremap_resource(). > > Signed-off-by: Paul Cercueil > --- > drivers/gpu/drm/ingenic/ingenic-drm.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c > index a069579ca749..02c4788ef1c7 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c > @@ -580,7 +580,6 @@ static int ingenic_drm_probe(struct platform_device *pdev) > struct drm_bridge *bridge; > struct drm_panel *panel; > struct drm_device *drm; > - struct resource *mem; > void __iomem *base; > long parent_rate; > int ret, irq; > @@ -614,8 +613,7 @@ static int ingenic_drm_probe(struct platform_device *pdev) > drm->mode_config.max_height = 600; > drm->mode_config.funcs = &ingenic_drm_mode_config_funcs; > > - mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - base = devm_ioremap_resource(dev, mem); > + base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(base)) { > dev_err(dev, "Failed to get memory resource"); Consider to include the error code in the error message here. > return PTR_ERR(base); With the above fixed/considered: Reviewed-by: Sam Ravnborg