From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH 3/3] DRM: ingenic: Add support for panels with 8-bit serial bus Date: Sun, 30 Jun 2019 10:21:50 +0200 Message-ID: <20190630082150.GE5081@ravnborg.org> References: <20190627182114.27299-1-paul@crapouillou.net> <20190627182114.27299-3-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id D7D5089B8F for ; Sun, 30 Jun 2019 08:21:53 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190627182114.27299-3-paul@crapouillou.net> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Cercueil Cc: David Airlie , dri-devel@lists.freedesktop.org, od@zcrc.me, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCBKdW4gMjcsIDIwMTkgYXQgMDg6MjE6MTRQTSArMDIwMCwgUGF1bCBDZXJjdWVpbCB3 cm90ZToKPiBBZGQgc3VwcG9ydCBmb3IgdGhlIExDRCBwYW5lbHMgd2l0aCBhIHNlcmlhbCA4LWJp dCBidXMsIHdoZXJlIHRoZSBjb2xvcgo+IGNvbXBvbmVudHMgb2YgZWFjaCAyNC1iaXQgcGl4ZWwg YXJlIHNlbnQgc2VxdWVudGlhbGx5LgoKVGhlcmUgYXJlIHN0cmFuZ2UgYnVzIGZvcm1hdHMuLi4K Cj4gCj4gU2lnbmVkLW9mZi1ieTogUGF1bCBDZXJjdWVpbCA8cGF1bEBjcmFwb3VpbGxvdS5uZXQ+ ClJldmlld2VkLWJ5OiBTYW0gUmF2bmJvcmcgPHNhbUByYXZuYm9yZy5vcmc+Cgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaW5nZW5pYy9pbmdlbmljLWRybS5jIHwgNCArKysrCj4gIDEgZmlsZSBj aGFuZ2VkLCA0IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2luZ2VuaWMvaW5nZW5pYy1kcm0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pbmdlbmljL2luZ2VuaWMt ZHJtLmMKPiBpbmRleCBkYTk2NmYzZGMxZjcuLmNlMWZhZTNhNzhhOSAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaW5nZW5pYy9pbmdlbmljLWRybS5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2luZ2VuaWMvaW5nZW5pYy1kcm0uYwo+IEBAIC00MjYsNiArNDI2LDkgQEAgc3RhdGljIHZv aWQgaW5nZW5pY19kcm1fZW5jb2Rlcl9hdG9taWNfbW9kZV9zZXQoc3RydWN0IGRybV9lbmNvZGVy ICplbmNvZGVyLAo+ICAJCQljYXNlIE1FRElBX0JVU19GTVRfUkdCODg4XzFYMjQ6Cj4gIAkJCQlj ZmcgfD0gSlpfTENEX0NGR19NT0RFX0dFTkVSSUNfMjRCSVQ7Cj4gIAkJCQlicmVhazsKPiArCQkJ Y2FzZSBNRURJQV9CVVNfRk1UX1JHQjg4OF8zWDg6Cj4gKwkJCQljZmcgfD0gSlpfTENEX0NGR19N T0RFXzhCSVRfU0VSSUFMOwo+ICsJCQkJYnJlYWs7Cj4gIAkJCWRlZmF1bHQ6Cj4gIAkJCQlicmVh azsKPiAgCQkJfQo+IEBAIC00NTEsNiArNDU0LDcgQEAgc3RhdGljIGludCBpbmdlbmljX2RybV9l bmNvZGVyX2F0b21pY19jaGVjayhzdHJ1Y3QgZHJtX2VuY29kZXIgKmVuY29kZXIsCj4gIAljYXNl IE1FRElBX0JVU19GTVRfUkdCNTY1XzFYMTY6Cj4gIAljYXNlIE1FRElBX0JVU19GTVRfUkdCNjY2 XzFYMTg6Cj4gIAljYXNlIE1FRElBX0JVU19GTVRfUkdCODg4XzFYMjQ6Cj4gKwljYXNlIE1FRElB X0JVU19GTVRfUkdCODg4XzNYODoKPiAgCQlyZXR1cm4gMDsKPiAgCWRlZmF1bHQ6Cj4gIAkJcmV0 dXJuIC1FSU5WQUw7Cj4gLS0gCj4gMi4yMS4wLjU5My5nNTExZWMzNDVlMTgKPiAKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IGRyaS1kZXZlbCBtYWls aW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91B3AC06508 for ; Sun, 30 Jun 2019 08:22:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6B104208E3 for ; Sun, 30 Jun 2019 08:22:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbfF3IVz (ORCPT ); Sun, 30 Jun 2019 04:21:55 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:38764 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbfF3IVy (ORCPT ); Sun, 30 Jun 2019 04:21:54 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 19C0220063; Sun, 30 Jun 2019 10:21:52 +0200 (CEST) Date: Sun, 30 Jun 2019 10:21:50 +0200 From: Sam Ravnborg To: Paul Cercueil Cc: David Airlie , Daniel Vetter , od@zcrc.me, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 3/3] DRM: ingenic: Add support for panels with 8-bit serial bus Message-ID: <20190630082150.GE5081@ravnborg.org> References: <20190627182114.27299-1-paul@crapouillou.net> <20190627182114.27299-3-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190627182114.27299-3-paul@crapouillou.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=ER_8r6IbAAAA:8 a=7gkXJVJtAAAA:8 a=e5mUnYsNAAAA:8 a=co-eyZKPhihzPdF-lREA:9 a=CjuIK1q_8ugA:10 a=9LHmKk7ezEChjTCyhBa9:22 a=E9Po1WZjFZOl8hwRPBS3:22 a=Vxmtnl_E_bksehYqCbjh:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 27, 2019 at 08:21:14PM +0200, Paul Cercueil wrote: > Add support for the LCD panels with a serial 8-bit bus, where the color > components of each 24-bit pixel are sent sequentially. There are strange bus formats... > > Signed-off-by: Paul Cercueil Reviewed-by: Sam Ravnborg > --- > drivers/gpu/drm/ingenic/ingenic-drm.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm.c b/drivers/gpu/drm/ingenic/ingenic-drm.c > index da966f3dc1f7..ce1fae3a78a9 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm.c > @@ -426,6 +426,9 @@ static void ingenic_drm_encoder_atomic_mode_set(struct drm_encoder *encoder, > case MEDIA_BUS_FMT_RGB888_1X24: > cfg |= JZ_LCD_CFG_MODE_GENERIC_24BIT; > break; > + case MEDIA_BUS_FMT_RGB888_3X8: > + cfg |= JZ_LCD_CFG_MODE_8BIT_SERIAL; > + break; > default: > break; > } > @@ -451,6 +454,7 @@ static int ingenic_drm_encoder_atomic_check(struct drm_encoder *encoder, > case MEDIA_BUS_FMT_RGB565_1X16: > case MEDIA_BUS_FMT_RGB666_1X18: > case MEDIA_BUS_FMT_RGB888_1X24: > + case MEDIA_BUS_FMT_RGB888_3X8: > return 0; > default: > return -EINVAL; > -- > 2.21.0.593.g511ec345e18 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel