From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71E4AC5B57E for ; Sun, 30 Jun 2019 14:12:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EA0420673 for ; Sun, 30 Jun 2019 14:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726514AbfF3OMd (ORCPT ); Sun, 30 Jun 2019 10:12:33 -0400 Received: from asavdk3.altibox.net ([109.247.116.14]:52257 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726509AbfF3OMc (ORCPT ); Sun, 30 Jun 2019 10:12:32 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id B0DE020063; Sun, 30 Jun 2019 16:12:28 +0200 (CEST) Date: Sun, 30 Jun 2019 16:12:26 +0200 From: Sam Ravnborg To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Kieran Bingham , David Airlie , Daniel Vetter , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v1] drm/shmobile: drop use of drmP.h Message-ID: <20190630141225.GA5444@ravnborg.org> References: <20190630052126.6050-1-sam@ravnborg.org> <20190630112203.GA7043@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190630112203.GA7043@pendragon.ideasonboard.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=4vd3_E1uAmGp2BPvN1gA:9 a=CjuIK1q_8ugA:10 Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Laurent. Thanks for the detailed feedback. > > If patch is OK, please apply to your tree > > as this driver is maintained outside drm-misc. > > > > I am happy to rebase on another tree, just let me know. > > The shmobile driver hasn't seen changes for a long time and I don't have > patches queued in my tree for it. If you don't mind taking this patch > through drm-misc with the rest of the drmP.h removal series it would be > easier for me. Otherwise please let me know and I'll handle it. No problem, I will add to drm-misc when ready. The motivation was alone to avoid later merge conflicts - which in this case is a non-issue. > > diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.h b/drivers/gpu/drm/shmobile/shmob_drm_crtc.h > > index 9ca6920641d8..bd35fe8f9028 100644 > > --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.h > > +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.h > > @@ -10,7 +10,6 @@ > > #ifndef __SHMOB_DRM_CRTC_H__ > > #define __SHMOB_DRM_CRTC_H__ > > > > -#include > > I think you should include drm/drm_connector.h here. It gets pulled > indirectly, but it's one of the top-level headers and I think it should > be explicitly included to avoid future breakages. > > While at it a forward declaration of struct drm_pending_vblank_event and > struct shmob_drm_format_info could also be useful to make the header > self-contained. Good input. I went through all shmobile header files - now gcc is happy with them all when used individually (self-contained). I will post a v2 a bit later today with the below fixup included. Sam diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.h b/drivers/gpu/drm/shmobile/shmob_drm_crtc.h index bd35fe8f9028..21718843f46d 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.h +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.h @@ -11,10 +11,13 @@ #define __SHMOB_DRM_CRTC_H__ #include +#include #include struct backlight_device; +struct drm_pending_vblank_event; struct shmob_drm_device; +struct shmob_drm_format_info; struct shmob_drm_crtc { struct drm_crtc crtc; diff --git a/drivers/gpu/drm/shmobile/shmob_drm_plane.h b/drivers/gpu/drm/shmobile/shmob_drm_plane.h index bae67cc8c628..e72b21a4288f 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_plane.h +++ b/drivers/gpu/drm/shmobile/shmob_drm_plane.h @@ -10,6 +10,7 @@ #ifndef __SHMOB_DRM_PLANE_H__ #define __SHMOB_DRM_PLANE_H__ +struct drm_plane; struct shmob_drm_device; int shmob_drm_plane_create(struct shmob_drm_device *sdev, unsigned int index); diff --git a/drivers/gpu/drm/shmobile/shmob_drm_regs.h b/drivers/gpu/drm/shmobile/shmob_drm_regs.h index 9eb0b3d01df8..058533685c4c 100644 --- a/drivers/gpu/drm/shmobile/shmob_drm_regs.h +++ b/drivers/gpu/drm/shmobile/shmob_drm_regs.h @@ -11,6 +11,9 @@ #define __SHMOB_DRM_REGS_H__ #include +#include + +#include "shmob_drm_drv.h" /* Register definitions */ #define LDDCKPAT1R 0x400 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v1] drm/shmobile: drop use of drmP.h Date: Sun, 30 Jun 2019 16:12:26 +0200 Message-ID: <20190630141225.GA5444@ravnborg.org> References: <20190630052126.6050-1-sam@ravnborg.org> <20190630112203.GA7043@pendragon.ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7199989000 for ; Sun, 30 Jun 2019 14:12:31 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20190630112203.GA7043@pendragon.ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: David Airlie , linux-renesas-soc@vger.kernel.org, Kieran Bingham , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgTGF1cmVudC4KClRoYW5rcyBmb3IgdGhlIGRldGFpbGVkIGZlZWRiYWNrLgoKPiA+IElmIHBh dGNoIGlzIE9LLCBwbGVhc2UgYXBwbHkgdG8geW91ciB0cmVlCj4gPiBhcyB0aGlzIGRyaXZlciBp cyBtYWludGFpbmVkIG91dHNpZGUgZHJtLW1pc2MuCj4gPiAKPiA+IEkgYW0gaGFwcHkgdG8gcmVi YXNlIG9uIGFub3RoZXIgdHJlZSwganVzdCBsZXQgbWUga25vdy4KPiAKPiBUaGUgc2htb2JpbGUg ZHJpdmVyIGhhc24ndCBzZWVuIGNoYW5nZXMgZm9yIGEgbG9uZyB0aW1lIGFuZCBJIGRvbid0IGhh dmUKPiBwYXRjaGVzIHF1ZXVlZCBpbiBteSB0cmVlIGZvciBpdC4gSWYgeW91IGRvbid0IG1pbmQg dGFraW5nIHRoaXMgcGF0Y2gKPiB0aHJvdWdoIGRybS1taXNjIHdpdGggdGhlIHJlc3Qgb2YgdGhl IGRybVAuaCByZW1vdmFsIHNlcmllcyBpdCB3b3VsZCBiZQo+IGVhc2llciBmb3IgbWUuIE90aGVy d2lzZSBwbGVhc2UgbGV0IG1lIGtub3cgYW5kIEknbGwgaGFuZGxlIGl0LgpObyBwcm9ibGVtLCBJ IHdpbGwgYWRkIHRvIGRybS1taXNjIHdoZW4gcmVhZHkuClRoZSBtb3RpdmF0aW9uIHdhcyBhbG9u ZSB0byBhdm9pZCBsYXRlciBtZXJnZSBjb25mbGljdHMgLSB3aGljaCBpbiB0aGlzCmNhc2UgaXMg YSBub24taXNzdWUuCgo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9zaG1vYmlsZS9z aG1vYl9kcm1fY3J0Yy5oIGIvZHJpdmVycy9ncHUvZHJtL3NobW9iaWxlL3NobW9iX2RybV9jcnRj LmgKPiA+IGluZGV4IDljYTY5MjA2NDFkOC4uYmQzNWZlOGY5MDI4IDEwMDY0NAo+ID4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3NobW9iaWxlL3NobW9iX2RybV9jcnRjLmgKPiA+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fY3J0Yy5oCj4gPiBAQCAtMTAsNyArMTAsNiBA QAo+ID4gICNpZm5kZWYgX19TSE1PQl9EUk1fQ1JUQ19IX18KPiA+ICAjZGVmaW5lIF9fU0hNT0Jf RFJNX0NSVENfSF9fCj4gPiAgCj4gPiAtI2luY2x1ZGUgPGRybS9kcm1QLmg+Cj4gCj4gSSB0aGlu ayB5b3Ugc2hvdWxkIGluY2x1ZGUgZHJtL2RybV9jb25uZWN0b3IuaCBoZXJlLiBJdCBnZXRzIHB1 bGxlZAo+IGluZGlyZWN0bHksIGJ1dCBpdCdzIG9uZSBvZiB0aGUgdG9wLWxldmVsIGhlYWRlcnMg YW5kIEkgdGhpbmsgaXQgc2hvdWxkCj4gYmUgZXhwbGljaXRseSBpbmNsdWRlZCB0byBhdm9pZCBm dXR1cmUgYnJlYWthZ2VzLgo+IAo+IFdoaWxlIGF0IGl0IGEgZm9yd2FyZCBkZWNsYXJhdGlvbiBv ZiBzdHJ1Y3QgZHJtX3BlbmRpbmdfdmJsYW5rX2V2ZW50IGFuZAo+IHN0cnVjdCBzaG1vYl9kcm1f Zm9ybWF0X2luZm8gY291bGQgYWxzbyBiZSB1c2VmdWwgdG8gbWFrZSB0aGUgaGVhZGVyCj4gc2Vs Zi1jb250YWluZWQuCkdvb2QgaW5wdXQuCkkgd2VudCB0aHJvdWdoIGFsbCBzaG1vYmlsZSBoZWFk ZXIgZmlsZXMgLSBub3cgZ2NjIGlzIGhhcHB5IHdpdGggdGhlbSBhbGwKd2hlbiB1c2VkIGluZGl2 aWR1YWxseSAoc2VsZi1jb250YWluZWQpLgoKSSB3aWxsIHBvc3QgYSB2MiBhIGJpdCBsYXRlciB0 b2RheSB3aXRoIHRoZSBiZWxvdyBmaXh1cCBpbmNsdWRlZC4KCglTYW0KCmRpZmYgLS1naXQgYS9k cml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2NydGMuaCBiL2RyaXZlcnMvZ3B1L2Ry bS9zaG1vYmlsZS9zaG1vYl9kcm1fY3J0Yy5oCmluZGV4IGJkMzVmZThmOTAyOC4uMjE3MTg4NDNm NDZkIDEwMDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2NydGMu aAorKysgYi9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX2NydGMuaApAQCAtMTEs MTAgKzExLDEzIEBACiAjZGVmaW5lIF9fU0hNT0JfRFJNX0NSVENfSF9fCiAKICNpbmNsdWRlIDxk cm0vZHJtX2NydGMuaD4KKyNpbmNsdWRlIDxkcm0vZHJtX2Nvbm5lY3Rvci5oPgogI2luY2x1ZGUg PGRybS9kcm1fZW5jb2Rlci5oPgogCiBzdHJ1Y3QgYmFja2xpZ2h0X2RldmljZTsKK3N0cnVjdCBk cm1fcGVuZGluZ192YmxhbmtfZXZlbnQ7CiBzdHJ1Y3Qgc2htb2JfZHJtX2RldmljZTsKK3N0cnVj dCBzaG1vYl9kcm1fZm9ybWF0X2luZm87CiAKIHN0cnVjdCBzaG1vYl9kcm1fY3J0YyB7CiAJc3Ry dWN0IGRybV9jcnRjIGNydGM7CmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUv c2htb2JfZHJtX3BsYW5lLmggYi9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX3Bs YW5lLmgKaW5kZXggYmFlNjdjYzhjNjI4Li5lNzJiMjFhNDI4OGYgMTAwNjQ0Ci0tLSBhL2RyaXZl cnMvZ3B1L2RybS9zaG1vYmlsZS9zaG1vYl9kcm1fcGxhbmUuaAorKysgYi9kcml2ZXJzL2dwdS9k cm0vc2htb2JpbGUvc2htb2JfZHJtX3BsYW5lLmgKQEAgLTEwLDYgKzEwLDcgQEAKICNpZm5kZWYg X19TSE1PQl9EUk1fUExBTkVfSF9fCiAjZGVmaW5lIF9fU0hNT0JfRFJNX1BMQU5FX0hfXwogCitz dHJ1Y3QgZHJtX3BsYW5lOwogc3RydWN0IHNobW9iX2RybV9kZXZpY2U7CiAKIGludCBzaG1vYl9k cm1fcGxhbmVfY3JlYXRlKHN0cnVjdCBzaG1vYl9kcm1fZGV2aWNlICpzZGV2LCB1bnNpZ25lZCBp bnQgaW5kZXgpOwpkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3NobW9iaWxlL3NobW9iX2Ry bV9yZWdzLmggYi9kcml2ZXJzL2dwdS9kcm0vc2htb2JpbGUvc2htb2JfZHJtX3JlZ3MuaAppbmRl eCA5ZWIwYjNkMDFkZjguLjA1ODUzMzY4NWM0YyAxMDA2NDQKLS0tIGEvZHJpdmVycy9ncHUvZHJt L3NobW9iaWxlL3NobW9iX2RybV9yZWdzLmgKKysrIGIvZHJpdmVycy9ncHUvZHJtL3NobW9iaWxl L3NobW9iX2RybV9yZWdzLmgKQEAgLTExLDYgKzExLDkgQEAKICNkZWZpbmUgX19TSE1PQl9EUk1f UkVHU19IX18KIAogI2luY2x1ZGUgPGxpbnV4L2lvLmg+CisjaW5jbHVkZSA8bGludXgvamlmZmll cy5oPgorCisjaW5jbHVkZSAic2htb2JfZHJtX2Rydi5oIgogCiAvKiBSZWdpc3RlciBkZWZpbml0 aW9ucyAqLwogI2RlZmluZSBMRERDS1BBVDFSCQkweDQwMAoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVs