From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Ravnborg Subject: Re: [PATCH v5 1/7] dt-bindings: Add panel-timing subnode to simple-panel Date: Sun, 30 Jun 2019 22:02:59 +0200 Message-ID: <20190630200259.GA15102@ravnborg.org> References: <20190401171724.215780-1-dianders@chromium.org> <20190401171724.215780-2-dianders@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190401171724.215780-2-dianders@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Douglas Anderson Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , Jeffy Chen , linux-kernel@vger.kernel.org, Rob Herring , linux-rockchip@lists.infradead.org, Thierry Reding , Sean Paul , dri-devel@lists.freedesktop.org, Boris Brezillon , Enric =?iso-8859-1?Q?Balletb=F2?= , =?iso-8859-1?Q?St=E9phane?= Marchesin , Ezequiel Garcia , mka@chromium.org, Laurent Pinchart List-Id: linux-rockchip.vger.kernel.org SGkgRG91Z2xhcy4KClNvbWUgbG9uZyBvdmVyZHVlIHJldmlldyBmZWVkYmFjay4KCk9uIE1vbiwg QXByIDAxLCAyMDE5IGF0IDEwOjE3OjE4QU0gLTA3MDAsIERvdWdsYXMgQW5kZXJzb24gd3JvdGU6 Cj4gRnJvbTogU2VhbiBQYXVsIDxzZWFucGF1bEBjaHJvbWl1bS5vcmc+Cj4gCj4gVGhpcyBwYXRj aCBhZGRzIGEgbmV3IHN1Ym5vZGUgdG8gc2ltcGxlLXBhbmVsIGFsbG93aW5nIHVzIHRvIG92ZXJy aWRlCj4gdGhlIHR5cGljYWwgdGltaW5nIGV4cHJlc3NlZCBpbiB0aGUgcGFuZWwncyBkaXNwbGF5 X3RpbWluZy4KPiAKPiBDaGFuZ2VzIGluIHYyOgo+ICAtIFNwbGl0IG91dCB0aGUgYmluZGluZyBp bnRvIGEgbmV3IHBhdGNoIChSb2IpCj4gIC0gZGlzcGxheS10aW1pbmdzIGlzIGEgbmV3IHNlY3Rp b24gKFJvYikKPiAgLSBVc2UgdGhlIGZ1bGwgZGlzcGxheS10aW1pbmdzIHN1Ym5vZGUgaW5zdGVh ZCBvZiBwaWNraW5nIHRoZSB0aW1pbmcKPiAgICBvdXQgKFJvYi9UaGllcnJ5KQo+IENoYW5nZXMg aW4gdjM6Cj4gIC0gR28gYmFjayB0byB1c2luZyB0aGUgdGltaW5nIHN1Ym5vZGUgZGlyZWN0bHks IGJ1dCByZW5hbWUgdG8KPiAgICBwYW5lbC10aW1pbmcgKFJvYikKPiBDaGFuZ2VzIGluIHY0Ogo+ ICAtIFNpbXBsaWZ5IGRlc2MuIGZvciB3aGVuIG92ZXJyaWRlIHNob3VsZCBiZSB1c2VkIChUaGll cnJ5L0xhdXJlbnQpCj4gIC0gUmVtb3ZlZCBSb2IgSCByZXZpZXcgc2luY2UgaXQncyBiZWVuIGEg eWVhciBhbmQgd29yZGluZyBjaGFuZ2VkCj4gQ2hhbmdlcyBpbiB2NToKPiAgLSBSZW1vdmVkIGJp dCBhYm91dCBPUyBtYXkgaWdub3JlIChSb2IvRXplcXVpZWwpCj4gCj4gQ2M6IERvdWcgQW5kZXJz b24gPGRpYW5kZXJzQGNocm9taXVtLm9yZz4KPiBDYzogRXJpYyBBbmhvbHQgPGVyaWNAYW5ob2x0 Lm5ldD4KPiBDYzogSGVpa28gU3R1ZWJuZXIgPGhlaWtvQHNudGVjaC5kZT4KPiBDYzogSmVmZnkg Q2hlbiA8amVmZnkuY2hlbkByb2NrLWNoaXBzLmNvbT4KPiBDYzogUm9iIEhlcnJpbmcgPHJvYmgr ZHRAa2VybmVsLm9yZz4KPiBDYzogU3TDqXBoYW5lIE1hcmNoZXNpbiA8bWFyY2hldUBjaHJvbWl1 bS5vcmc+Cj4gQ2M6IFRoaWVycnkgUmVkaW5nIDx0aGllcnJ5LnJlZGluZ0BnbWFpbC5jb20+Cj4g Q2M6IGRldmljZXRyZWVAdmdlci5rZXJuZWwub3JnCj4gQ2M6IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBDYzogbGludXgtcm9ja2NoaXBAbGlzdHMuaW5mcmFkZWFkLm9yZwo+IFNp Z25lZC1vZmYtYnk6IFNlYW4gUGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgo+IFNpZ25lZC1v ZmYtYnk6IERvdWdsYXMgQW5kZXJzb24gPGRpYW5kZXJzQGNocm9taXVtLm9yZz4KPiAtLS0KPiAK PiAgLi4uL2JpbmRpbmdzL2Rpc3BsYXkvcGFuZWwvc2ltcGxlLXBhbmVsLnR4dCAgIHwgMjIgKysr KysrKysrKysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKQo+IAo+ IGRpZmYgLS1naXQgYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9w YW5lbC9zaW1wbGUtcGFuZWwudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdz L2Rpc3BsYXkvcGFuZWwvc2ltcGxlLXBhbmVsLnR4dAo+IGluZGV4IGIyYjg3MmM3MTBmMi4uOTM4 ODIyNjhjMGI5IDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy9kaXNwbGF5L3BhbmVsL3NpbXBsZS1wYW5lbC50eHQKPiArKysgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9wYW5lbC9zaW1wbGUtcGFuZWwudHh0Cj4gQEAgLTE1 LDYgKzE1LDE2IEBAIE9wdGlvbmFsIHByb3BlcnRpZXM6Cj4gICAgKGhvdCBwbHVnIGRldGVjdCkg c2lnbmFsLCBidXQgdGhlIHNpZ25hbCBpc24ndCBob29rZWQgdXAgc28gd2Ugc2hvdWxkCj4gICAg aGFyZGNvZGUgdGhlIG1heCBkZWxheSBmcm9tIHRoZSBwYW5lbCBzcGVjIHdoZW4gcG93ZXJpbmcg dXAgdGhlIHBhbmVsLgo+ICAKPiArcGFuZWwtdGltaW5nIHN1Ym5vZGUKPiArLS0tLS0tLS0tLS0t LS0tLS0tLS0KPiArCj4gK1RoaXMgb3B0aW9uYWwgc3Vibm9kZSBpcyBmb3IgZGV2aWNlcyB3aGlj aCByZXF1aXJlIGEgbW9kZSBkaWZmZXJpbmcKPiArZnJvbSB0aGUgcGFuZWwncyAidHlwaWNhbCIg ZGlzcGxheSB0aW1pbmcuCk1leWJlIGFkZCBoZXJlIHRoYXQgaXQgaXMgZXhwZWN0ZWQgdGhhdCB0 aGUgcGFuZWwgaGFzIGluY2x1ZGVkIHRpbWluZwppbiB0aGUgZHJpdmVyIGl0c2VsZiwgYW5kIG5v dCBhcyBwYXJ0IG9mIERULgpTbyB3aGF0IGlzIHNwZWNpZmllZCBoZXJlIGlzIGEgbW9yZSBwcmVj aXNlIHZhcmlhbnQsIHdpdGhpbiB0aGUgbGltaXRzCm9mIHdoYXQgaXMgc3BlY2lmaWVkIGZvciB0 aGUgcGFuZWwuCgo+ICsKPiArRm9ybWF0IGluZm9ybWF0aW9uIG9uIHRoZSBwYW5lbC10aW1pbmcg c3Vibm9kZSBjYW4gYmUgZm91bmQgaW4KPiArZGlzcGxheS10aW1pbmcudHh0LgpkaXNwbGF5LXRp bWluZyBkZWZpbmVzIG90aW9uYWwgcHJvcGVydGllczoKaHN5bmMtYWN0aXZlLCBwaXhlbGNsay1h Y3RpdmUsIGRvdWJsZXNjYW4gZXRjLgpJdCBpcyBub3QgZnJvbSB0aGUgYWJvdmUgb2J2aW91cyB3 aGljaCBwcm9wZXJ0aWVzIGZyb20gZGlzcGxheS10aW1pbmdzCnRoYXQgY2FuIGJlIHNwZWNpZmll ZCBmb3IgYSBwYW5lbC10aW1pbmcgc3ViLW5vZGUuCk1heWJlIGJlY2F1c2UgdGhleSBjYW4gYWxs IGJlIHNwZWNpZmllZD8KCkRpc3BsYXktdGltaW5nIGFsbG93cyB0aW1pbmdzIHRvIGJlIHNwZWNp ZmllZCBhcyBhIHJhbmdlLgpJZiBpdCBpcyBhbHNvIE9LIHRvIHNwZWNpZnkgYSByYW5nZSBmb3Ig cGFubGUtdGltaW5nIHRoZW4gZXZlcnl0aGlnbiBpcwpmaW5lLiBCdXQgaWYgdGhlIHBhbmVsLXRp bWlnbiBzdWJub2RlIGRvIG5vdCBhbGxvdyByYW5nZXMgdGhpcyBuZWVkcyB0bwpiZSBzcGVjaWZp ZWQuCgo+ICsKPiArCj4gIEV4YW1wbGU6Cj4gIAo+ICAJcGFuZWw6IHBhbmVsIHsKPiBAQCAtMjUs NCArMzUsMTYgQEAgRXhhbXBsZToKPiAgCQllbmFibGUtZ3Bpb3MgPSA8JmdwaW8gOTAgMD47Cj4g IAo+ICAJCWJhY2tsaWdodCA9IDwmYmFja2xpZ2h0PjsKPiArCj4gKwkJcGFuZWwtdGltaW5nIHsK PiArCQkJY2xvY2stZnJlcXVlbmN5ID0gPDI2NjYwNDcyMD47Cj4gKwkJCWhhY3RpdmUgPSA8MjQw MD47Cj4gKwkJCWhmcm9udC1wb3JjaCA9IDw0OD47Cj4gKwkJCWhiYWNrLXBvcmNoID0gPDg0PjsK PiArCQkJaHN5bmMtbGVuID0gPDMyPjsKPiArCQkJdmFjdGl2ZSA9IDwxNjAwPjsKPiArCQkJdmZy b250LXBvcmNoID0gPDM+Owo+ICsJCQl2YmFjay1wb3JjaCA9IDwxMjA+Owo+ICsJCQl2c3luYy1s ZW4gPSA8MTA+Owo+ICsJCX07Cj4gIAl9Owo+IC0tIAo+IDIuMjEuMC4zOTIuZ2Y4ZjY3ODcxNTll LWdvb2cKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f Xwo+IGRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKPiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCj4gaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmkt ZGV2ZWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73DD5C5B576 for ; Sun, 30 Jun 2019 20:03:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5689F2086D for ; Sun, 30 Jun 2019 20:03:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726859AbfF3UDJ (ORCPT ); Sun, 30 Jun 2019 16:03:09 -0400 Received: from asavdk4.altibox.net ([109.247.116.15]:33738 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726719AbfF3UDI (ORCPT ); Sun, 30 Jun 2019 16:03:08 -0400 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id CCB2680426; Sun, 30 Jun 2019 22:03:01 +0200 (CEST) Date: Sun, 30 Jun 2019 22:02:59 +0200 From: Sam Ravnborg To: Douglas Anderson Cc: Thierry Reding , Heiko Stuebner , Sean Paul , Mark Rutland , devicetree@vger.kernel.org, Rob Herring , David Airlie , Jeffy Chen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , Enric =?iso-8859-1?Q?Balletb=F2?= , =?iso-8859-1?Q?St=E9phane?= Marchesin , Ezequiel Garcia , mka@chromium.org Subject: Re: [PATCH v5 1/7] dt-bindings: Add panel-timing subnode to simple-panel Message-ID: <20190630200259.GA15102@ravnborg.org> References: <20190401171724.215780-1-dianders@chromium.org> <20190401171724.215780-2-dianders@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190401171724.215780-2-dianders@chromium.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VcLZwmh9 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=8nJEP1OIZ-IA:10 a=cm27Pg_UAAAA:8 a=-VAfIpHNAAAA:8 a=s8YR1HE3AAAA:8 a=VwQbUJbxAAAA:8 a=pGLkceISAAAA:8 a=e5mUnYsNAAAA:8 a=JfrnYn6hAAAA:8 a=rQ-KyBzUA4MiSMEBMPUA:9 a=wPNLvfGTeEIA:10 a=xmb-EsYY8bH0VWELuYED:22 a=srlwD-8ojaedGGhPAyx8:22 a=jGH_LyMDp9YhSvY-UuyI:22 a=AjGcO6oz07-iQ99wixmX:22 a=Vxmtnl_E_bksehYqCbjh:22 a=1CNFftbPRP8L7MoqJWF3:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Douglas. Some long overdue review feedback. On Mon, Apr 01, 2019 at 10:17:18AM -0700, Douglas Anderson wrote: > From: Sean Paul > > This patch adds a new subnode to simple-panel allowing us to override > the typical timing expressed in the panel's display_timing. > > Changes in v2: > - Split out the binding into a new patch (Rob) > - display-timings is a new section (Rob) > - Use the full display-timings subnode instead of picking the timing > out (Rob/Thierry) > Changes in v3: > - Go back to using the timing subnode directly, but rename to > panel-timing (Rob) > Changes in v4: > - Simplify desc. for when override should be used (Thierry/Laurent) > - Removed Rob H review since it's been a year and wording changed > Changes in v5: > - Removed bit about OS may ignore (Rob/Ezequiel) > > Cc: Doug Anderson > Cc: Eric Anholt > Cc: Heiko Stuebner > Cc: Jeffy Chen > Cc: Rob Herring > Cc: Stéphane Marchesin > Cc: Thierry Reding > Cc: devicetree@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: linux-rockchip@lists.infradead.org > Signed-off-by: Sean Paul > Signed-off-by: Douglas Anderson > --- > > .../bindings/display/panel/simple-panel.txt | 22 +++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/panel/simple-panel.txt b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > index b2b872c710f2..93882268c0b9 100644 > --- a/Documentation/devicetree/bindings/display/panel/simple-panel.txt > +++ b/Documentation/devicetree/bindings/display/panel/simple-panel.txt > @@ -15,6 +15,16 @@ Optional properties: > (hot plug detect) signal, but the signal isn't hooked up so we should > hardcode the max delay from the panel spec when powering up the panel. > > +panel-timing subnode > +-------------------- > + > +This optional subnode is for devices which require a mode differing > +from the panel's "typical" display timing. Meybe add here that it is expected that the panel has included timing in the driver itself, and not as part of DT. So what is specified here is a more precise variant, within the limits of what is specified for the panel. > + > +Format information on the panel-timing subnode can be found in > +display-timing.txt. display-timing defines otional properties: hsync-active, pixelclk-active, doublescan etc. It is not from the above obvious which properties from display-timings that can be specified for a panel-timing sub-node. Maybe because they can all be specified? Display-timing allows timings to be specified as a range. If it is also OK to specify a range for panle-timing then everythign is fine. But if the panel-timign subnode do not allow ranges this needs to be specified. > + > + > Example: > > panel: panel { > @@ -25,4 +35,16 @@ Example: > enable-gpios = <&gpio 90 0>; > > backlight = <&backlight>; > + > + panel-timing { > + clock-frequency = <266604720>; > + hactive = <2400>; > + hfront-porch = <48>; > + hback-porch = <84>; > + hsync-len = <32>; > + vactive = <1600>; > + vfront-porch = <3>; > + vback-porch = <120>; > + vsync-len = <10>; > + }; > }; > -- > 2.21.0.392.gf8f6787159e-goog > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel