From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 862F6C5B57E for ; Sun, 30 Jun 2019 20:47:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 58EF8217D8 for ; Sun, 30 Jun 2019 20:47:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="JvQhk0CY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726829AbfF3Urq (ORCPT ); Sun, 30 Jun 2019 16:47:46 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:48718 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726669AbfF3Urq (ORCPT ); Sun, 30 Jun 2019 16:47:46 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 47CFD255; Sun, 30 Jun 2019 22:47:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1561927663; bh=dBe3yAq6Q1C4VcXG06Vz7nXaIG0pbndeYddXgCeKg/A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JvQhk0CYuLPmvsnXgMfQ54qleQCRDC8h/euYya5WJKEGZT4y8cPE6Qkd/pT7ktb2c BNXwwxE1Vl5Rh76y5JDDSQFISCh4/fpR2a+4HdNPKJdBK14JEHP2ycWds3maKAy/UD Ef8mWClZdv+sgFXvRnCu62dq9xZKjV4vxoaEy31k= Date: Sun, 30 Jun 2019 23:47:23 +0300 From: Laurent Pinchart To: Rob Clark Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, aarch64-laptops@lists.linaro.org, Rob Clark , Ard Biesheuvel , Catalin Marinas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Ingo Molnar , Julien Thierry , "open list:EXTENSIBLE FIRMWARE INTERFACE (EFI)" , open list , Lukas Wunner , Steve Capper , Will Deacon Subject: Re: [PATCH 0/4] drm+dt+efi: support devices with multiple possible panels Message-ID: <20190630204723.GH7043@pendragon.ideasonboard.com> References: <20190630203614.5290-1-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190630203614.5290-1-robdclark@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Rob, Thank you for the patch. On Sun, Jun 30, 2019 at 01:36:04PM -0700, Rob Clark wrote: > From: Rob Clark > > Now that we can deal gracefully with bootloader (firmware) initialized > display on aarch64 laptops[1], the next step is to deal with the fact > that the same model of laptop can have one of multiple different panels. > (For the yoga c630 that I have, I know of at least two possible panels, > there might be a third.) I have to ask the obvious question: why doesn't the boot loader just pass a correct DT to Linux ? There's no point in passing a list of panels that are not there, this seems quite a big hack to me. A proper boot loader should construct the DT based on hardware detection. > This is actually a scenario that comes up frequently in phones and > tablets as well, so it is useful to have an upstream solution for this. > > The basic idea is to add a 'panel-id' property in dt chosen node, and > use that to pick the endpoint we look at when loading the panel driver, > e.g. > > / { > chosen { > panel-id = <0xc4>; > }; > > ivo_panel { > compatible = "ivo,m133nwf4-r0"; > power-supply = <&vlcm_3v3>; > no-hpd; > > ports { > port { > ivo_panel_in_edp: endpoint { > remote-endpoint = <&sn65dsi86_out_ivo>; > }; > }; > }; > }; > > boe_panel { > compatible = "boe,nv133fhm-n61"; > power-supply = <&vlcm_3v3>; > no-hpd; > > ports { > port { > boe_panel_in_edp: endpoint { > remote-endpoint = <&sn65dsi86_out_boe>; > }; > }; > }; > }; > > sn65dsi86: bridge@2c { > compatible = "ti,sn65dsi86"; > > ... > > ports { > #address-cells = <1>; > #size-cells = <0>; > > ... > > port@1 { > #address-cells = <1>; > #size-cells = <0>; > reg = <1>; > > endpoint@c4 { > reg = <0xc4>; > remote-endpoint = <&boe_panel_in_edp>; > }; > > endpoint@c5 { > reg = <0xc5>; > remote-endpoint = <&ivo_panel_in_edp>; > }; > }; > }; > } > }; > > Note that the panel-id is potentially a sparse-int. The values I've > seen so far on aarch64 laptops are: > > * 0xc2 > * 0xc3 > * 0xc4 > * 0xc5 > * 0x8011 > * 0x8012 > * 0x8055 > * 0x8056 > > At least on snapdragon aarch64 laptops, they can be any u32 value. > > However, on these laptops, the bootloader/firmware is not populating the > chosen node, but instead providing an "UEFIDisplayInfo" variable, which > contains the panel id. Unfortunately EFI variables are only available > before ExitBootServices, so the second patch checks for this variable > before EBS and populates the /chosen/panel-id variable. > > [1] https://patchwork.freedesktop.org/series/63001/ > > Rob Clark (4): > dt-bindings: chosen: document panel-id binding > efi/libstub: detect panel-id > drm: add helper to lookup panel-id > drm/bridge: ti-sn65dsi86: use helper to lookup panel-id > > Documentation/devicetree/bindings/chosen.txt | 69 ++++++++++++++++++++ > drivers/firmware/efi/libstub/arm-stub.c | 49 ++++++++++++++ > drivers/firmware/efi/libstub/efistub.h | 2 + > drivers/firmware/efi/libstub/fdt.c | 9 +++ > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 +- > drivers/gpu/drm/drm_of.c | 21 ++++++ > include/drm/drm_of.h | 7 ++ > 7 files changed, 160 insertions(+), 2 deletions(-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 0/4] drm+dt+efi: support devices with multiple possible panels Date: Sun, 30 Jun 2019 23:47:23 +0300 Message-ID: <20190630204723.GH7043@pendragon.ideasonboard.com> References: <20190630203614.5290-1-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190630203614.5290-1-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Rob Clark Cc: Rob Clark , aarch64-laptops-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, "open list:EXTENSIBLE FIRMWARE INTERFACE (EFI)" , Will Deacon , Ard Biesheuvel , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Julien Thierry , open list , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Lukas Wunner , Catalin Marinas , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Ingo Molnar , Steve Capper List-Id: devicetree@vger.kernel.org SGkgUm9iLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBTdW4sIEp1biAzMCwgMjAxOSBh dCAwMTozNjowNFBNIC0wNzAwLCBSb2IgQ2xhcmsgd3JvdGU6Cj4gRnJvbTogUm9iIENsYXJrIDxy b2JkY2xhcmtAY2hyb21pdW0ub3JnPgo+IAo+IE5vdyB0aGF0IHdlIGNhbiBkZWFsIGdyYWNlZnVs bHkgd2l0aCBib290bG9hZGVyIChmaXJtd2FyZSkgaW5pdGlhbGl6ZWQKPiBkaXNwbGF5IG9uIGFh cmNoNjQgbGFwdG9wc1sxXSwgdGhlIG5leHQgc3RlcCBpcyB0byBkZWFsIHdpdGggdGhlIGZhY3QK PiB0aGF0IHRoZSBzYW1lIG1vZGVsIG9mIGxhcHRvcCBjYW4gaGF2ZSBvbmUgb2YgbXVsdGlwbGUg ZGlmZmVyZW50IHBhbmVscy4KPiAoRm9yIHRoZSB5b2dhIGM2MzAgdGhhdCBJIGhhdmUsIEkga25v dyBvZiBhdCBsZWFzdCB0d28gcG9zc2libGUgcGFuZWxzLAo+IHRoZXJlIG1pZ2h0IGJlIGEgdGhp cmQuKQoKSSBoYXZlIHRvIGFzayB0aGUgb2J2aW91cyBxdWVzdGlvbjogd2h5IGRvZXNuJ3QgdGhl IGJvb3QgbG9hZGVyIGp1c3QKcGFzcyBhIGNvcnJlY3QgRFQgdG8gTGludXggPyBUaGVyZSdzIG5v IHBvaW50IGluIHBhc3NpbmcgYSBsaXN0IG9mCnBhbmVscyB0aGF0IGFyZSBub3QgdGhlcmUsIHRo aXMgc2VlbXMgcXVpdGUgYSBiaWcgaGFjayB0byBtZS4gQSBwcm9wZXIKYm9vdCBsb2FkZXIgc2hv dWxkIGNvbnN0cnVjdCB0aGUgRFQgYmFzZWQgb24gaGFyZHdhcmUgZGV0ZWN0aW9uLgoKPiBUaGlz IGlzIGFjdHVhbGx5IGEgc2NlbmFyaW8gdGhhdCBjb21lcyB1cCBmcmVxdWVudGx5IGluIHBob25l cyBhbmQKPiB0YWJsZXRzIGFzIHdlbGwsIHNvIGl0IGlzIHVzZWZ1bCB0byBoYXZlIGFuIHVwc3Ry ZWFtIHNvbHV0aW9uIGZvciB0aGlzLgo+IAo+IFRoZSBiYXNpYyBpZGVhIGlzIHRvIGFkZCBhICdw YW5lbC1pZCcgcHJvcGVydHkgaW4gZHQgY2hvc2VuIG5vZGUsIGFuZAo+IHVzZSB0aGF0IHRvIHBp Y2sgdGhlIGVuZHBvaW50IHdlIGxvb2sgYXQgd2hlbiBsb2FkaW5nIHRoZSBwYW5lbCBkcml2ZXIs Cj4gZS5nLgo+IAo+IC8gewo+IAljaG9zZW4gewo+IAkJcGFuZWwtaWQgPSA8MHhjND47Cj4gCX07 Cj4gCj4gCWl2b19wYW5lbCB7Cj4gCQljb21wYXRpYmxlID0gIml2byxtMTMzbndmNC1yMCI7Cj4g CQlwb3dlci1zdXBwbHkgPSA8JnZsY21fM3YzPjsKPiAJCW5vLWhwZDsKPiAKPiAJCXBvcnRzIHsK PiAJCQlwb3J0IHsKPiAJCQkJaXZvX3BhbmVsX2luX2VkcDogZW5kcG9pbnQgewo+IAkJCQkJcmVt b3RlLWVuZHBvaW50ID0gPCZzbjY1ZHNpODZfb3V0X2l2bz47Cj4gCQkJCX07Cj4gCQkJfTsKPiAJ CX07Cj4gCX07Cj4gCj4gCWJvZV9wYW5lbCB7Cj4gCQljb21wYXRpYmxlID0gImJvZSxudjEzM2Zo bS1uNjEiOwo+IAkJcG93ZXItc3VwcGx5ID0gPCZ2bGNtXzN2Mz47Cj4gCQluby1ocGQ7Cj4gCj4g CQlwb3J0cyB7Cj4gCQkJcG9ydCB7Cj4gCQkJCWJvZV9wYW5lbF9pbl9lZHA6IGVuZHBvaW50IHsK PiAJCQkJCXJlbW90ZS1lbmRwb2ludCA9IDwmc242NWRzaTg2X291dF9ib2U+Owo+IAkJCQl9Owo+ IAkJCX07Cj4gCQl9Owo+IAl9Owo+IAo+IAlzbjY1ZHNpODY6IGJyaWRnZUAyYyB7Cj4gCQljb21w YXRpYmxlID0gInRpLHNuNjVkc2k4NiI7Cj4gCj4gCQkuLi4KPiAKPiAJCXBvcnRzIHsKPiAJCQkj YWRkcmVzcy1jZWxscyA9IDwxPjsKPiAJCQkjc2l6ZS1jZWxscyA9IDwwPjsKPiAKPiAJCQkuLi4K PiAKPiAJCQlwb3J0QDEgewo+IAkJCQkjYWRkcmVzcy1jZWxscyA9IDwxPjsKPiAJCQkJI3NpemUt Y2VsbHMgPSA8MD47Cj4gCQkJCXJlZyA9IDwxPjsKPiAKPiAJCQkJZW5kcG9pbnRAYzQgewo+IAkJ CQkJcmVnID0gPDB4YzQ+Owo+IAkJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZib2VfcGFuZWxfaW5f ZWRwPjsKPiAJCQkJfTsKPiAKPiAJCQkJZW5kcG9pbnRAYzUgewo+IAkJCQkJcmVnID0gPDB4YzU+ Owo+IAkJCQkJcmVtb3RlLWVuZHBvaW50ID0gPCZpdm9fcGFuZWxfaW5fZWRwPjsKPiAJCQkJfTsK PiAJCQl9Owo+IAkJfTsKPiAJfQo+IH07Cj4gCj4gTm90ZSB0aGF0IHRoZSBwYW5lbC1pZCBpcyBw b3RlbnRpYWxseSBhIHNwYXJzZS1pbnQuICBUaGUgdmFsdWVzIEkndmUKPiBzZWVuIHNvIGZhciBv biBhYXJjaDY0IGxhcHRvcHMgYXJlOgo+IAo+ICAgKiAweGMyCj4gICAqIDB4YzMKPiAgICogMHhj NAo+ICAgKiAweGM1Cj4gICAqIDB4ODAxMQo+ICAgKiAweDgwMTIKPiAgICogMHg4MDU1Cj4gICAq IDB4ODA1Ngo+IAo+IEF0IGxlYXN0IG9uIHNuYXBkcmFnb24gYWFyY2g2NCBsYXB0b3BzLCB0aGV5 IGNhbiBiZSBhbnkgdTMyIHZhbHVlLgo+IAo+IEhvd2V2ZXIsIG9uIHRoZXNlIGxhcHRvcHMsIHRo ZSBib290bG9hZGVyL2Zpcm13YXJlIGlzIG5vdCBwb3B1bGF0aW5nIHRoZQo+IGNob3NlbiBub2Rl LCBidXQgaW5zdGVhZCBwcm92aWRpbmcgYW4gIlVFRklEaXNwbGF5SW5mbyIgdmFyaWFibGUsIHdo aWNoCj4gY29udGFpbnMgdGhlIHBhbmVsIGlkLiAgVW5mb3J0dW5hdGVseSBFRkkgdmFyaWFibGVz IGFyZSBvbmx5IGF2YWlsYWJsZQo+IGJlZm9yZSBFeGl0Qm9vdFNlcnZpY2VzLCBzbyB0aGUgc2Vj b25kIHBhdGNoIGNoZWNrcyBmb3IgdGhpcyB2YXJpYWJsZQo+IGJlZm9yZSBFQlMgYW5kIHBvcHVs YXRlcyB0aGUgL2Nob3Nlbi9wYW5lbC1pZCB2YXJpYWJsZS4KPiAKPiBbMV0gaHR0cHM6Ly9wYXRj aHdvcmsuZnJlZWRlc2t0b3Aub3JnL3Nlcmllcy82MzAwMS8KPiAKPiBSb2IgQ2xhcmsgKDQpOgo+ ICAgZHQtYmluZGluZ3M6IGNob3NlbjogZG9jdW1lbnQgcGFuZWwtaWQgYmluZGluZwo+ICAgZWZp L2xpYnN0dWI6IGRldGVjdCBwYW5lbC1pZAo+ICAgZHJtOiBhZGQgaGVscGVyIHRvIGxvb2t1cCBw YW5lbC1pZAo+ICAgZHJtL2JyaWRnZTogdGktc242NWRzaTg2OiB1c2UgaGVscGVyIHRvIGxvb2t1 cCBwYW5lbC1pZAo+IAo+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvY2hvc2Vu LnR4dCB8IDY5ICsrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMvZmlybXdhcmUvZWZpL2xp YnN0dWIvYXJtLXN0dWIuYyAgICAgIHwgNDkgKysrKysrKysrKysrKysKPiAgZHJpdmVycy9maXJt d2FyZS9lZmkvbGlic3R1Yi9lZmlzdHViLmggICAgICAgfCAgMiArCj4gIGRyaXZlcnMvZmlybXdh cmUvZWZpL2xpYnN0dWIvZmR0LmMgICAgICAgICAgIHwgIDkgKysrCj4gIGRyaXZlcnMvZ3B1L2Ry bS9icmlkZ2UvdGktc242NWRzaTg2LmMgICAgICAgIHwgIDUgKy0KPiAgZHJpdmVycy9ncHUvZHJt L2RybV9vZi5jICAgICAgICAgICAgICAgICAgICAgfCAyMSArKysrKysKPiAgaW5jbHVkZS9kcm0v ZHJtX29mLmggICAgICAgICAgICAgICAgICAgICAgICAgfCAgNyArKwo+ICA3IGZpbGVzIGNoYW5n ZWQsIDE2MCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKLS0gClJlZ2FyZHMsCgpMYXVy ZW50IFBpbmNoYXJ0Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCkZyZWVkcmVubyBtYWlsaW5nIGxpc3QKRnJlZWRyZW5vQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ZyZWVkcmVu bw==