From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BF71C5B576 for ; Sun, 30 Jun 2019 21:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC5EA208C3 for ; Sun, 30 Jun 2019 21:17:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Q1hoRxI+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726957AbfF3VRs (ORCPT ); Sun, 30 Jun 2019 17:17:48 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:50104 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726811AbfF3VRs (ORCPT ); Sun, 30 Jun 2019 17:17:48 -0400 Received: from pendragon.ideasonboard.com (dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5C26D255; Sun, 30 Jun 2019 23:17:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1561929465; bh=qhQR3O5AsGUf/DlkqR0aLfys56Lbc2SRqyc65RdPD1w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Q1hoRxI+AArRf6NPjZ0SH5dBwLIj+BUVSB/Qx9IsGPdZjDtqaIErraVoxKLClT5jS Mqyuowa1m9tcV7t5KT3FoyywDZ0GvUS9unghvIbocO/3n8tFW4+WKWM1N5sakBRHUf l1OTO/TFESLE3cy6OkfyDCEuL3VYaVdtCO4YkO3g= Date: Mon, 1 Jul 2019 00:17:26 +0300 From: Laurent Pinchart To: Rob Clark Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, aarch64-laptops@lists.linaro.org, Rob Clark , Andrzej Hajda , David Airlie , Daniel Vetter , linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: use helper to lookup panel-id Message-ID: <20190630211726.GJ7043@pendragon.ideasonboard.com> References: <20190630203614.5290-1-robdclark@gmail.com> <20190630203614.5290-5-robdclark@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20190630203614.5290-5-robdclark@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Rob, Thank you for the patch. On Sun, Jun 30, 2019 at 01:36:08PM -0700, Rob Clark wrote: > From: Rob Clark > > Use the drm_of_find_panel_id() helper to decide which endpoint to use > when looking up panel. This way we can support devices that have > multiple possible panels, such as the aarch64 laptops. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index 2719d9c0864b..56c66a43f1a6 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -790,7 +790,7 @@ static int ti_sn_bridge_probe(struct i2c_client *client, > const struct i2c_device_id *id) > { > struct ti_sn_bridge *pdata; > - int ret; > + int ret, panel_id; > > if (!i2c_check_functionality(client->adapter, I2C_FUNC_I2C)) { > DRM_ERROR("device doesn't support I2C\n"); > @@ -811,7 +811,8 @@ static int ti_sn_bridge_probe(struct i2c_client *client, > > pdata->dev = &client->dev; > > - ret = drm_of_find_panel_or_bridge(pdata->dev->of_node, 1, 0, > + panel_id = drm_of_find_panel_id(); > + ret = drm_of_find_panel_or_bridge(pdata->dev->of_node, 1, panel_id, > &pdata->panel, NULL); > if (ret) { > DRM_ERROR("could not find any panel node\n"); No, I'm sorry, but that's a no-go. We can't patch every single bridge driver to support this hack. We need a solution implemented at another level that will not spread throughout the whole subsystem. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: use helper to lookup panel-id Date: Mon, 1 Jul 2019 00:17:26 +0300 Message-ID: <20190630211726.GJ7043@pendragon.ideasonboard.com> References: <20190630203614.5290-1-robdclark@gmail.com> <20190630203614.5290-5-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20190630203614.5290-5-robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: freedreno-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Freedreno" To: Rob Clark Cc: Rob Clark , aarch64-laptops-cunTk1MwBs8s++Sfvej+rw@public.gmane.org, David Airlie , linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Andrzej Hajda , Daniel Vetter , freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org SGkgUm9iLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBTdW4sIEp1biAzMCwgMjAxOSBh dCAwMTozNjowOFBNIC0wNzAwLCBSb2IgQ2xhcmsgd3JvdGU6Cj4gRnJvbTogUm9iIENsYXJrIDxy b2JkY2xhcmtAY2hyb21pdW0ub3JnPgo+IAo+IFVzZSB0aGUgZHJtX29mX2ZpbmRfcGFuZWxfaWQo KSBoZWxwZXIgdG8gZGVjaWRlIHdoaWNoIGVuZHBvaW50IHRvIHVzZQo+IHdoZW4gbG9va2luZyB1 cCBwYW5lbC4gIFRoaXMgd2F5IHdlIGNhbiBzdXBwb3J0IGRldmljZXMgdGhhdCBoYXZlCj4gbXVs dGlwbGUgcG9zc2libGUgcGFuZWxzLCBzdWNoIGFzIHRoZSBhYXJjaDY0IGxhcHRvcHMuCj4gCj4g U2lnbmVkLW9mZi1ieTogUm9iIENsYXJrIDxyb2JkY2xhcmtAY2hyb21pdW0ub3JnPgo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3RpLXNuNjVkc2k4Ni5jIHwgNSArKystLQo+ICAxIGZp bGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3RpLXNuNjVkc2k4Ni5jIGIvZHJpdmVycy9ncHUv ZHJtL2JyaWRnZS90aS1zbjY1ZHNpODYuYwo+IGluZGV4IDI3MTlkOWMwODY0Yi4uNTZjNjZhNDNm MWE2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2UvdGktc242NWRzaTg2LmMK PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3RpLXNuNjVkc2k4Ni5jCj4gQEAgLTc5MCw3 ICs3OTAsNyBAQCBzdGF0aWMgaW50IHRpX3NuX2JyaWRnZV9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVu dCAqY2xpZW50LAo+ICAJCQkgICAgICBjb25zdCBzdHJ1Y3QgaTJjX2RldmljZV9pZCAqaWQpCj4g IHsKPiAgCXN0cnVjdCB0aV9zbl9icmlkZ2UgKnBkYXRhOwo+IC0JaW50IHJldDsKPiArCWludCBy ZXQsIHBhbmVsX2lkOwo+ICAKPiAgCWlmICghaTJjX2NoZWNrX2Z1bmN0aW9uYWxpdHkoY2xpZW50 LT5hZGFwdGVyLCBJMkNfRlVOQ19JMkMpKSB7Cj4gIAkJRFJNX0VSUk9SKCJkZXZpY2UgZG9lc24n dCBzdXBwb3J0IEkyQ1xuIik7Cj4gQEAgLTgxMSw3ICs4MTEsOCBAQCBzdGF0aWMgaW50IHRpX3Nu X2JyaWRnZV9wcm9iZShzdHJ1Y3QgaTJjX2NsaWVudCAqY2xpZW50LAo+ICAKPiAgCXBkYXRhLT5k ZXYgPSAmY2xpZW50LT5kZXY7Cj4gIAo+IC0JcmV0ID0gZHJtX29mX2ZpbmRfcGFuZWxfb3JfYnJp ZGdlKHBkYXRhLT5kZXYtPm9mX25vZGUsIDEsIDAsCj4gKwlwYW5lbF9pZCA9IGRybV9vZl9maW5k X3BhbmVsX2lkKCk7Cj4gKwlyZXQgPSBkcm1fb2ZfZmluZF9wYW5lbF9vcl9icmlkZ2UocGRhdGEt PmRldi0+b2Zfbm9kZSwgMSwgcGFuZWxfaWQsCj4gIAkJCQkJICAmcGRhdGEtPnBhbmVsLCBOVUxM KTsKPiAgCWlmIChyZXQpIHsKPiAgCQlEUk1fRVJST1IoImNvdWxkIG5vdCBmaW5kIGFueSBwYW5l bCBub2RlXG4iKTsKCk5vLCBJJ20gc29ycnksIGJ1dCB0aGF0J3MgYSBuby1nby4gV2UgY2FuJ3Qg cGF0Y2ggZXZlcnkgc2luZ2xlIGJyaWRnZQpkcml2ZXIgdG8gc3VwcG9ydCB0aGlzIGhhY2suIFdl IG5lZWQgYSBzb2x1dGlvbiBpbXBsZW1lbnRlZCBhdCBhbm90aGVyCmxldmVsIHRoYXQgd2lsbCBu b3Qgc3ByZWFkIHRocm91Z2hvdXQgdGhlIHdob2xlIHN1YnN5c3RlbS4KCi0tIApSZWdhcmRzLAoK TGF1cmVudCBQaW5jaGFydApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwpGcmVlZHJlbm8gbWFpbGluZyBsaXN0CkZyZWVkcmVub0BsaXN0cy5mcmVlZGVza3Rv cC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9mcmVl ZHJlbm8=